mbox series

[v2,0/9] drm/tinydrm: Move mipi_dbi

Message ID 20190722104312.16184-1-noralf@tronnes.org (mailing list archive)
Headers show
Series drm/tinydrm: Move mipi_dbi | expand

Message

Noralf Trønnes July 22, 2019, 10:43 a.m. UTC
This series ticks off the last tinydrm todo entry and moves out mipi_dbi
to be a core helper.

It splits struct mipi_dbi into an interface part and a display pipeline
part (upload framebuffer over SPI). I also took the opportunity to
rename the ambiguous 'mipi' variable name to 'dbi'. This lines up with
the use of the 'dsi' variable name in the MIPI DSI helper.

Changes since v1:
The kbuild test robot alerted me to the fact that I was missing a
dependency on DRM_MIPI_DBI. I also realised that it had a dependency on
the CMA helper as well.

The CMA helper dependency was resolved by open coding a function.

The KMS helper dependency revealed a problem with the BACKLIGHT
dependency. Details in the patch.

I had mistakenly set DRM_MIPI_DBI to bool, this has been changed to
tristate.

Note:
This depends on series: drm/tinydrm: Remove tinydrm.ko

Series is also available here:
https://github.com/notro/linux/tree/move_mipi_dbi

Noralf.

Noralf Trønnes (9):
  drm/tinydrm/mipi-dbi: Move cmdlock mutex init
  drm/tinydrm: Rename variable mipi -> dbi
  drm/tinydrm: Rename remaining variable mipi -> dbidev
  drm/tinydrm: Split struct mipi_dbi in two
  drm/tinydrm/mipi-dbi: Remove CMA helper dependency
  drm/tinydrm/Kconfig: drivers: Select BACKLIGHT_CLASS_DEVICE
  drm/tinydrm/mipi-dbi: Select DRM_KMS_HELPER
  drm/tinydrm: Move mipi-dbi
  MAINTAINERS: Remove tinydrm entry

 Documentation/gpu/drivers.rst                 |   1 -
 Documentation/gpu/drm-kms-helpers.rst         |  12 +
 Documentation/gpu/tinydrm.rst                 |  18 -
 Documentation/gpu/todo.rst                    |  13 -
 MAINTAINERS                                   |  13 +-
 drivers/gpu/drm/Kconfig                       |   4 +
 drivers/gpu/drm/Makefile                      |   1 +
 .../{tinydrm/mipi-dbi.c => drm_mipi_dbi.c}    | 333 +++++++++---------
 drivers/gpu/drm/tinydrm/Kconfig               |  23 +-
 drivers/gpu/drm/tinydrm/Makefile              |   4 -
 drivers/gpu/drm/tinydrm/hx8357d.c             |  61 ++--
 drivers/gpu/drm/tinydrm/ili9225.c             | 171 ++++-----
 drivers/gpu/drm/tinydrm/ili9341.c             |  83 ++---
 drivers/gpu/drm/tinydrm/mi0283qt.c            |  89 ++---
 drivers/gpu/drm/tinydrm/st7586.c              | 104 +++---
 drivers/gpu/drm/tinydrm/st7735r.c             |  77 ++--
 include/drm/drm_mipi_dbi.h                    | 188 ++++++++++
 include/drm/tinydrm/mipi-dbi.h                | 135 -------
 18 files changed, 691 insertions(+), 639 deletions(-)
 delete mode 100644 Documentation/gpu/tinydrm.rst
 rename drivers/gpu/drm/{tinydrm/mipi-dbi.c => drm_mipi_dbi.c} (77%)
 create mode 100644 include/drm/drm_mipi_dbi.h
 delete mode 100644 include/drm/tinydrm/mipi-dbi.h

Comments

Noralf Trønnes July 25, 2019, 8:58 a.m. UTC | #1
Den 22.07.2019 12.43, skrev Noralf Trønnes:
> This series ticks off the last tinydrm todo entry and moves out mipi_dbi
> to be a core helper.
> 
> It splits struct mipi_dbi into an interface part and a display pipeline
> part (upload framebuffer over SPI). I also took the opportunity to
> rename the ambiguous 'mipi' variable name to 'dbi'. This lines up with
> the use of the 'dsi' variable name in the MIPI DSI helper.
> 
> Changes since v1:
> The kbuild test robot alerted me to the fact that I was missing a
> dependency on DRM_MIPI_DBI. I also realised that it had a dependency on
> the CMA helper as well.
> 
> The CMA helper dependency was resolved by open coding a function.
> 
> The KMS helper dependency revealed a problem with the BACKLIGHT
> dependency. Details in the patch.
> 
> I had mistakenly set DRM_MIPI_DBI to bool, this has been changed to
> tristate.
> 
> Note:
> This depends on series: drm/tinydrm: Remove tinydrm.ko
> 
> Series is also available here:
> https://github.com/notro/linux/tree/move_mipi_dbi
> 
> Noralf.
> 
> Noralf Trønnes (9):
>   drm/tinydrm/mipi-dbi: Move cmdlock mutex init
>   drm/tinydrm: Rename variable mipi -> dbi
>   drm/tinydrm: Rename remaining variable mipi -> dbidev
>   drm/tinydrm: Split struct mipi_dbi in two
>   drm/tinydrm/mipi-dbi: Remove CMA helper dependency
>   drm/tinydrm/Kconfig: drivers: Select BACKLIGHT_CLASS_DEVICE
>   drm/tinydrm/mipi-dbi: Select DRM_KMS_HELPER
>   drm/tinydrm: Move mipi-dbi
>   MAINTAINERS: Remove tinydrm entry
> 

Series applied to drm-misc-next, thanks for reviewing!

Noralf.

>  Documentation/gpu/drivers.rst                 |   1 -
>  Documentation/gpu/drm-kms-helpers.rst         |  12 +
>  Documentation/gpu/tinydrm.rst                 |  18 -
>  Documentation/gpu/todo.rst                    |  13 -
>  MAINTAINERS                                   |  13 +-
>  drivers/gpu/drm/Kconfig                       |   4 +
>  drivers/gpu/drm/Makefile                      |   1 +
>  .../{tinydrm/mipi-dbi.c => drm_mipi_dbi.c}    | 333 +++++++++---------
>  drivers/gpu/drm/tinydrm/Kconfig               |  23 +-
>  drivers/gpu/drm/tinydrm/Makefile              |   4 -
>  drivers/gpu/drm/tinydrm/hx8357d.c             |  61 ++--
>  drivers/gpu/drm/tinydrm/ili9225.c             | 171 ++++-----
>  drivers/gpu/drm/tinydrm/ili9341.c             |  83 ++---
>  drivers/gpu/drm/tinydrm/mi0283qt.c            |  89 ++---
>  drivers/gpu/drm/tinydrm/st7586.c              | 104 +++---
>  drivers/gpu/drm/tinydrm/st7735r.c             |  77 ++--
>  include/drm/drm_mipi_dbi.h                    | 188 ++++++++++
>  include/drm/tinydrm/mipi-dbi.h                | 135 -------
>  18 files changed, 691 insertions(+), 639 deletions(-)
>  delete mode 100644 Documentation/gpu/tinydrm.rst
>  rename drivers/gpu/drm/{tinydrm/mipi-dbi.c => drm_mipi_dbi.c} (77%)
>  create mode 100644 include/drm/drm_mipi_dbi.h
>  delete mode 100644 include/drm/tinydrm/mipi-dbi.h
>