From patchwork Mon Jul 22 18:24:35 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 11053243 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 99AE613A4 for ; Mon, 22 Jul 2019 18:25:06 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8887328434 for ; Mon, 22 Jul 2019 18:25:06 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 76C4A2821F; Mon, 22 Jul 2019 18:25:06 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 282EB2821F for ; Mon, 22 Jul 2019 18:25:06 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C5BD589DB0; Mon, 22 Jul 2019 18:25:04 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-pl1-x642.google.com (mail-pl1-x642.google.com [IPv6:2607:f8b0:4864:20::642]) by gabe.freedesktop.org (Postfix) with ESMTPS id 05F0689DB0 for ; Mon, 22 Jul 2019 18:25:04 +0000 (UTC) Received: by mail-pl1-x642.google.com with SMTP id az7so19517783plb.5 for ; Mon, 22 Jul 2019 11:25:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=x8c0DPCRMv9IW9PP1p4HBNy16Fzp3nQIOkgwmBpQwpo=; b=Kv0sZNwySuFYi+9+E2iyx7uuvDWHAM5357ppjDN8AeB32R9aKP9fDPk6mbIldoFlOq AiV7t/sGx7LkPYs14RB1lZRZ6xxDP+6LBkdQuF31mepbVVLYbvgfKHcuWRqs30pMQszc Ud7MAchC75ng32rURQSA0B8LuXwfBBDeWv+ZO/xqdIWK6WCD51q/oNJJs9bu/62YIhkh bR03lrDJn5BUGvZOIS2Uz8kqpgQX1ml/UAGq9XUWhLrBrJA7/ex9CnA9lHgn8NOj/+TI iSmqL4UCNMRuJTzZjffFoXESOV0azDKgD4oeEZVGgsyU9HTl+dvjY3oOAY14hL7uTCyP XpIQ== X-Gm-Message-State: APjAAAWrnqz6X+y+JlH7rL6Pyww0H7IkaHSmsdOd0thYlhupdxCttgoT 3nz1bQwabGcwpIry4Qr+Xr1d6g== X-Google-Smtp-Source: APXvYqwyyl3J3Mb8JWQgZSDuxJTdfEQ/qKsf4Mi5pmNYAuIsVFOtUl3uWg6CUWJmNS9uHBU4AAA4AQ== X-Received: by 2002:a17:902:7448:: with SMTP id e8mr76695940plt.85.1563819903648; Mon, 22 Jul 2019 11:25:03 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:202:1:24fa:e766:52c9:e3b2]) by smtp.gmail.com with ESMTPSA id a3sm36117683pfl.145.2019.07.22.11.25.02 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 22 Jul 2019 11:25:03 -0700 (PDT) From: Douglas Anderson To: Bartlomiej Zolnierkiewicz , Thierry Reding , Sam Ravnborg Subject: [PATCH 0/4] video: of: display_timing: Adjust err printing of of_get_display_timing() Date: Mon, 22 Jul 2019 11:24:35 -0700 Message-Id: <20190722182439.44844-1-dianders@chromium.org> X-Mailer: git-send-email 2.22.0.657.g960e92d24f-goog MIME-Version: 1.0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=x8c0DPCRMv9IW9PP1p4HBNy16Fzp3nQIOkgwmBpQwpo=; b=FfZ6mG6bnACwo8lgLXr1zYGkAj7V4iNwkTU4H5ELO+CqHQDbFy8TPLhLV8XtPvILqW TowJOHAi23SCQrrxtT2YTfMTfZT0utOVqKKuvQM9feJUKIT7JNt7M+zJZk8pj3Ja4Z0d xtriekUe46UMlYaBOMlvThIUciUDwEHKz3k6E= X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, David Airlie , linux-kernel@vger.kernel.org, Russell King , dri-devel@lists.freedesktop.org, Douglas Anderson , Tomi Valkeinen , Laurent Pinchart Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP As reported by Sam Ravnborg [1], after commit b8a2948fa2b3 ("drm/panel: simple: Add ability to override typical timing") we now see a pointless error message printed on every boot for many systems. Let's fix that by adjusting who is responsible for printing error messages when of_get_display_timing() is used. Most certainly we can bikeshed the topic about whether this is the right fix or we should instead add logic to panel_simple_probe() to avoid calling of_get_display_timing() in the case where there is no "panel-timing" sub-node. If there is consensus that I should move the fix to panel_simple_probe() I'm happy to spin this series. In that case we probably should _remove_ the extra prints that were already present in the other two callers of of_get_display_timing(). While at it, fix a missing of_node_put() found by code inspection. NOTE: amba-clcd and panel-lvds were only compile-tested. [1] https://lkml.kernel.org/r/20190721093815.GA4375@ravnborg.org Douglas Anderson (4): video: of: display_timing: Add of_node_put() in of_get_display_timing() video: of: display_timing: Don't yell if no timing node is present drm: panel-lvds: Spout an error if of_get_display_timing() gives an error video: amba-clcd: Spout an error if of_get_display_timing() gives an error drivers/gpu/drm/panel/panel-lvds.c | 5 ++++- drivers/video/fbdev/amba-clcd.c | 4 +++- drivers/video/of_display_timing.c | 11 +++++++---- 3 files changed, 14 insertions(+), 6 deletions(-) Reviewed-by: Sam Ravnborg