From patchwork Wed Aug 7 13:37:43 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lionel Landwerlin X-Patchwork-Id: 11082159 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 13AE2112C for ; Wed, 7 Aug 2019 13:38:43 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 015791FF66 for ; Wed, 7 Aug 2019 13:38:43 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E90A4289FF; Wed, 7 Aug 2019 13:38:42 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 707D11FF66 for ; Wed, 7 Aug 2019 13:38:42 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6765389CE3; Wed, 7 Aug 2019 13:38:39 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4279689CE3 for ; Wed, 7 Aug 2019 13:38:38 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Aug 2019 06:37:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,357,1559545200"; d="scan'208";a="176196862" Received: from unknown (HELO delly.ger.corp.intel.com) ([10.252.52.138]) by fmsmga007.fm.intel.com with ESMTP; 07 Aug 2019 06:37:49 -0700 From: Lionel Landwerlin To: dri-devel@lists.freedesktop.org Subject: [PATCH 0/2] drm/syncobj: add syncobj sideband payload for threaded submission Date: Wed, 7 Aug 2019 16:37:43 +0300 Message-Id: <20190807133745.4110-1-lionel.g.landwerlin@intel.com> X-Mailer: git-send-email 2.23.0.rc1 MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: zhoucm1@amd.com, Christian.Koenig@amd.com, jason@jlekstrand.net Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP Hi, The goal of this feature is to solve an issue that was seen in our testing. After discussing on [1] I thought we could solve this problem with stalling the application thread after each vkQueueSubmit() call where a binary semaphore is signaled but I don't think it's a good option because of performance impacts on the application. Unfortunately there isn't a good way to reproduce this problem 100% because it essentially exposes a race between the application thread and the submission thread. I've uploaded tests in the Khronos repository to try to expose the issue. Thanks, [1] : https://lists.freedesktop.org/archives/dri-devel/2019-August/229188.html Lionel Landwerlin (2): drm/syncobj: add sideband payload drm/syncobj: add submit point query capability drivers/gpu/drm/drm_syncobj.c | 132 ++++++++++++++++++++++------------ include/drm/drm_syncobj.h | 9 +++ include/uapi/drm/drm.h | 5 +- 3 files changed, 100 insertions(+), 46 deletions(-) --- 2.23.0.rc1