From patchwork Mon Oct 7 03:31:53 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 11176853 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B1DDE14DB for ; Mon, 7 Oct 2019 07:02:18 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9A80920867 for ; Mon, 7 Oct 2019 07:02:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9A80920867 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EE8D56E461; Mon, 7 Oct 2019 07:01:52 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-pg1-x543.google.com (mail-pg1-x543.google.com [IPv6:2607:f8b0:4864:20::543]) by gabe.freedesktop.org (Postfix) with ESMTPS id B63296E44D for ; Mon, 7 Oct 2019 03:32:03 +0000 (UTC) Received: by mail-pg1-x543.google.com with SMTP id e1so7331827pgj.6 for ; Sun, 06 Oct 2019 20:32:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=m6ZVj+HV49loAv95ReQOh5GSunOnE35wX2Bc+0q93oo=; b=OIiCRy4yyPODH8ZrdIZZ0PK1PzhsksmGrnPSYQyHU3ov2PR3F4kofr1k15chqCxqIT bffFLnsn3UDCDMTgNvPCaL9uZi0rCqLVqsaQ1cnpbSywE4zNQC5p7n484EYcxmGtNETS bo7s3CiFYRoPVDACzWco27ZxZjDk2DCD2qcMUUUOfh0twmhUvL/uDuAYEEdjMqCMq6Xq Czi+mdV9D9X5/iRUIK9Hf36KMaruD0/NFkBon1l4MOnTiq3VpOFCzVKMdPJG3qqM4Yg/ NjmAaOIEDnh63xJC6IktEG/QK5E3OPGrW9TSIJoDszkBbm1yvVa5fWJl5IQp/v0MBgU0 W+SQ== X-Gm-Message-State: APjAAAW5AghsEXVlMRmX8jzre2mvR4+BhOkeJmSKcL3CMSwvu8pVlWEh 0y0L18ByKKbRK9qoCVosO27hUQ== X-Google-Smtp-Source: APXvYqzOOwyanRyMiJGsVbmq0P686Fa+QDrzb4QYm1IDHlrNgzTjC4nRJtm6F85fOzT8iD4OWtQP0g== X-Received: by 2002:a17:90a:3387:: with SMTP id n7mr29905561pjb.26.1570419123161; Sun, 06 Oct 2019 20:32:03 -0700 (PDT) Received: from debian-brgl.local (96-95-220-76-static.hfc.comcastbusiness.net. [96.95.220.76]) by smtp.gmail.com with ESMTPSA id x10sm16377720pfr.44.2019.10.06.20.32.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Oct 2019 20:32:02 -0700 (PDT) From: Bartosz Golaszewski To: Yoshinori Sato , Rich Felker , Lee Jones , Daniel Thompson , Jingoo Han , Bartlomiej Zolnierkiewicz , Linus Walleij , Andy Shevchenko , Jacopo Mondi Subject: [PATCH v5 0/7] backlight: gpio: simplify the driver Date: Mon, 7 Oct 2019 05:31:53 +0200 Message-Id: <20191007033200.13443-1-brgl@bgdev.pl> X-Mailer: git-send-email 2.23.0 MIME-Version: 1.0 X-Mailman-Approved-At: Mon, 07 Oct 2019 07:01:51 +0000 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=m6ZVj+HV49loAv95ReQOh5GSunOnE35wX2Bc+0q93oo=; b=KpBM+zmvrOzbdWsfbpdXfUOh/HlwxVlM6JtPhdxdQrGG/iNat1s44Xk1dIe5G0yytN g4uFYUJgcL/7ZzJwYBoBSxbzLFp1yUnec+Kny7Hh9U0uLRzHbCgQ1JisnLiswN2gc5KV uWItlqydSYWsSq6Bfpsfzu9YC5jWFxlOelQ4GueEHJkh+czXgYhKgiYvDM0mMVsRgkXu 9rm2kFk2xxohwng1/1LGytYCrVv7SpCWybwGabJEkzbE2+w5xiJQCpuU5Qy5ywjhif9l aAYdY0MmHol877lte5vNPlPFhXptGVMnqp1pXpQ37tF8TGcxxvOs7VAB08YCFBw63bvU jpmw== X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bartosz Golaszewski , linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-sh@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" From: Bartosz Golaszewski While working on my other series related to gpio-backlight[1] I noticed that we could simplify the driver if we made the only user of platform data use GPIO lookups and device properties. This series tries to do that. The first patch adds all necessary data structures to ecovec24. Patch 2/7 unifies much of the code for both pdata and non-pdata cases. Patches 3-4/7 remove unused platform data fields. Last three patches contain additional improvements for the GPIO backlight driver while we're already modifying it. I don't have access to this HW but hopefully this works. Only compile tested. [1] https://lkml.org/lkml/2019/6/25/900 v1 -> v2: - rebased on top of v5.3-rc1 and adjusted to the recent changes from Andy - added additional two patches with minor improvements v2 -> v3: - in patch 7/7: used initializers to set values for pdata and dev local vars v3 -> v4: - rebased on top of v5.4-rc1 - removed changes that are no longer relevant after commit ec665b756e6f ("backlight: gpio-backlight: Correct initial power state handling") - added patch 7/7 v4 ->V5: - in patch 7/7: added a comment replacing the name of the function being pulled into probe() Bartosz Golaszewski (7): backlight: gpio: remove unneeded include sh: ecovec24: add additional properties to the backlight device backlight: gpio: simplify the platform data handling sh: ecovec24: don't set unused fields in platform data backlight: gpio: remove unused fields from platform data backlight: gpio: use a helper variable for &pdev->dev backlight: gpio: pull gpio_backlight_initial_power_state() into probe arch/sh/boards/mach-ecovec24/setup.c | 33 ++++-- drivers/video/backlight/gpio_backlight.c | 108 +++++-------------- include/linux/platform_data/gpio_backlight.h | 3 - 3 files changed, 53 insertions(+), 91 deletions(-) Tested-by: Jacopo Mondi