mbox series

[v2,0/7] PCI: Prefer pcie_capability_read_word()

Message ID 20191121140220.38030-1-helgaas@kernel.org (mailing list archive)
Headers show
Series PCI: Prefer pcie_capability_read_word() | expand

Message

Bjorn Helgaas Nov. 21, 2019, 2:02 p.m. UTC
From: Bjorn Helgaas <bhelgaas@google.com>

Use pcie_capability_read_word() and similar instead of using
pci_read_config_word() directly.  Add #defines to replace some magic
numbers.  Fix typos in use of Transmit Margin field.

These are currently on my pci/misc branch for v5.5.  Let me know if you see
any issues.


Bjorn Helgaas (5):
  PCI: Add #defines for Enter Compliance, Transmit Margin
  drm/amdgpu: Correct Transmit Margin masks
  drm/amdgpu: Replace numbers with PCI_EXP_LNKCTL2 definitions
  drm/radeon: Correct Transmit Margin masks
  drm/radeon: Replace numbers with PCI_EXP_LNKCTL2 definitions

Frederick Lawler (2):
  drm/amdgpu: Prefer pcie_capability_read_word()
  drm/radeon: Prefer pcie_capability_read_word()

 drivers/gpu/drm/amd/amdgpu/cik.c | 95 +++++++++++++++++++------------
 drivers/gpu/drm/amd/amdgpu/si.c  | 97 ++++++++++++++++++++------------
 drivers/gpu/drm/radeon/cik.c     | 94 +++++++++++++++++++------------
 drivers/gpu/drm/radeon/si.c      | 97 ++++++++++++++++++++------------
 include/uapi/linux/pci_regs.h    |  2 +
 5 files changed, 243 insertions(+), 142 deletions(-)

Comments

Alex Deucher Nov. 21, 2019, 4:37 p.m. UTC | #1
> -----Original Message-----
> From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of
> Bjorn Helgaas
> Sent: Thursday, November 21, 2019 9:02 AM
> To: linux-pci@vger.kernel.org
> Cc: Zhou, David(ChunMing) <David1.Zhou@amd.com>; Frederick Lawler
> <fred@fredlawl.com>; Dave Airlie <airlied@linux.ie>; linux-
> kernel@vger.kernel.org; dri-devel@lists.freedesktop.org; Bjorn Helgaas
> <bhelgaas@google.com>; amd-gfx@lists.freedesktop.org; Daniel Vetter
> <daniel@ffwll.ch>; Alex Deucher <alexdeucher@gmail.com>; Koenig,
> Christian <Christian.Koenig@amd.com>
> Subject: [PATCH v2 0/7] PCI: Prefer pcie_capability_read_word()
> 
> From: Bjorn Helgaas <bhelgaas@google.com>
> 
> Use pcie_capability_read_word() and similar instead of using
> pci_read_config_word() directly.  Add #defines to replace some magic
> numbers.  Fix typos in use of Transmit Margin field.
> 
> These are currently on my pci/misc branch for v5.5.  Let me know if you see
> any issues.
> 

Series is:
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>

> 
> Bjorn Helgaas (5):
>   PCI: Add #defines for Enter Compliance, Transmit Margin
>   drm/amdgpu: Correct Transmit Margin masks
>   drm/amdgpu: Replace numbers with PCI_EXP_LNKCTL2 definitions
>   drm/radeon: Correct Transmit Margin masks
>   drm/radeon: Replace numbers with PCI_EXP_LNKCTL2 definitions
> 
> Frederick Lawler (2):
>   drm/amdgpu: Prefer pcie_capability_read_word()
>   drm/radeon: Prefer pcie_capability_read_word()
> 
>  drivers/gpu/drm/amd/amdgpu/cik.c | 95 +++++++++++++++++++------------
> drivers/gpu/drm/amd/amdgpu/si.c  | 97 ++++++++++++++++++++------------
>  drivers/gpu/drm/radeon/cik.c     | 94 +++++++++++++++++++------------
>  drivers/gpu/drm/radeon/si.c      | 97 ++++++++++++++++++++------------
>  include/uapi/linux/pci_regs.h    |  2 +
>  5 files changed, 243 insertions(+), 142 deletions(-)
> 
> --
> 2.24.0.432.g9d3f5f5b63-goog
> 
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx