[0/9] *** virtgpu cleanups ***

Message

Gurchetan Singh Dec. 18, 2019, 12:59 a.m. UTC

With so many new features on the horizon, perhaps it's
time to do a little "winter cleaning" beforehand. Enjoy!

Gurchetan Singh (9):
  drm/virtio: static-ify virtio_fence_signaled
  drm/virtio: static-ify virtio_gpu_framebuffer_init
  drm/virtio: get rid of drm_encoder_to_virtio_gpu_output
  drm/virtio: simplify getting fake offset
  drm/virtio: remove virtgpu_gem_prime_import_sg_table
  drm/virtio: move to_virtio_fence inside virtgpu_fence
  drm/virtio: move drm_connector_to_virtio_gpu_output to virtgpu_display
  drm/virtio: split out vq functions from virtgpu_drv.h
  drm/virtio: split out gem functions from virtgpu_drv.h

 drivers/gpu/drm/virtio/Makefile          |   2 +-
 drivers/gpu/drm/virtio/virtgpu_display.c |   6 +-
 drivers/gpu/drm/virtio/virtgpu_drv.c     |   4 +-
 drivers/gpu/drm/virtio/virtgpu_drv.h     | 137 +----------------------
 drivers/gpu/drm/virtio/virtgpu_fence.c   |   5 +-
 drivers/gpu/drm/virtio/virtgpu_gem.c     |   6 +-
 drivers/gpu/drm/virtio/virtgpu_gem.h     |  52 +++++++++
 drivers/gpu/drm/virtio/virtgpu_ioctl.c   |   2 +
 drivers/gpu/drm/virtio/virtgpu_kms.c     |   2 +
 drivers/gpu/drm/virtio/virtgpu_object.c  |   2 +
 drivers/gpu/drm/virtio/virtgpu_plane.c   |   2 +
 drivers/gpu/drm/virtio/virtgpu_prime.c   |  38 -------
 drivers/gpu/drm/virtio/virtgpu_vq.c      |   2 +
 drivers/gpu/drm/virtio/virtgpu_vq.h      | 100 +++++++++++++++++
 14 files changed, 178 insertions(+), 182 deletions(-)
 create mode 100644 drivers/gpu/drm/virtio/virtgpu_gem.h
 delete mode 100644 drivers/gpu/drm/virtio/virtgpu_prime.c
 create mode 100644 drivers/gpu/drm/virtio/virtgpu_vq.h

Comments

Gerd Hoffmann Dec. 18, 2019, 8:31 a.m. UTC | #1

On Tue, Dec 17, 2019 at 04:59:20PM -0800, Gurchetan Singh wrote:
> With so many new features on the horizon, perhaps it's
> time to do a little "winter cleaning" beforehand. Enjoy!
> 
>   drm/virtio: static-ify virtio_gpu_framebuffer_init

Doesn't apply cleanly.  What kernel is this against?

>   drm/virtio: remove virtgpu_gem_prime_import_sg_table

I'd prefer to keep that.  Once we have blob resource support we can
actually handle dma-buf imports.

>   drm/virtio: split out vq functions from virtgpu_drv.h
>   drm/virtio: split out gem functions from virtgpu_drv.h

Hmm, I'd prefer to have everything in one header, and the file isn't
that big that it is unmanageable...

The other patches look fine to me.  Didn't test whenever they apply
though, tried only the whole series which stopped at patch #2).

cheers,
  Gerd