| Message ID | 20200106151655.311413-1-christian.gmeiner@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | update hwdw for gc400 | expand |
Hi Christian On Mon, Jan 06, 2020 at 04:16:45PM +0100, Christian Gmeiner wrote: > This patch series extends the hwdb for an entry for the gc400 found > in the ST STM32 SoC. With this patches we report the same limits and > features for this GPU as the galcore kernel driver does. For future patches can you please incldue a small changelog within each patch. Something like v2: - Drop redundant newlines (Lucas) This serves several purposes: - It explains what was changed since last version - It allow the reader to focus on changed parts - It attributes who requested a specific change - It gives a good idea of the history of a patch In the DRM sub-subsystem the idea is that if it is written it should be visible in git too. So include the changelog part in the normal commit-message. Sam > > Christian Gmeiner (6): > drm/etnaviv: update hardware headers from rnndb > drm/etnaviv: determine product, customer and eco id > drm/etnaviv: show identity information in debugfs > drm/etnaviv: update gc7000 chip identity entry > drm/etnaviv: update hwdb selection logic > drm/etnaviv: add hwdb entry for gc400 found in STM32 > > drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 18 ++++++++++- > drivers/gpu/drm/etnaviv/etnaviv_gpu.h | 6 ++-- > drivers/gpu/drm/etnaviv/etnaviv_hwdb.c | 42 +++++++++++++++++++++++++- > drivers/gpu/drm/etnaviv/state_hi.xml.h | 29 +++++++++++------- > 4 files changed, 79 insertions(+), 16 deletions(-) > > -- > 2.24.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
Hi Sam, > For future patches can you please incldue a small changelog > within each patch. > > Something like > > v2: > - Drop redundant newlines (Lucas) > > This serves several purposes: > - It explains what was changed since last version > - It allow the reader to focus on changed parts > - It attributes who requested a specific change > - It gives a good idea of the history of a patch > > In the DRM sub-subsystem the idea is that if it is written it > should be visible in git too. So include the changelog part in the > normal commit-message. > To be honest.. I forgot the change log thing this time - sorry. So the rule is to have the change log in the normal commit message? Funny - Lucas told me something different: "Please move those changelogs below the 3 dashes, so they don't end up in the commit message. They don't really add any value to the persistent kernel history." https://lkml.org/lkml/2019/9/13/107
Hi Christian. > To be honest.. I forgot the change log thing this time - sorry. It was small changes - so no worries. > So the rule > is to have the change log in the normal commit message? This is what Danial Vetter tell people - but it is not documented as far as I can tell. > Funny - Lucas told me something different: > > "Please move those changelogs below the 3 dashes, so they don't end up > in the commit message. They don't really add any value to the > persistent kernel history." > https://lkml.org/lkml/2019/9/13/107 Lucas is maintainer of etnaviv driver - so do as he says. Keep up the good work on etnaviv in mesa too! Sam
gentle ping