| Message ID | 20200116140900.26363-1-b.zolnierkie@samsung.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | video: fbdev: controlfb: small cleanup | expand |
Hi Bartlomiej On Thu, Jan 16, 2020 at 03:08:54PM +0100, Bartlomiej Zolnierkiewicz wrote: > Hi, > > Small cleanup for controlfb driver: > > - fix sparse warnings > - remove not working module support > - add COMPILE_TEST support > - remove redundant function prototypes Nice cleanup - with a few comments. The last three patches are the good ones. With my comments considered - and then up to you if you cahnge anything - then all patches are: Acked-by: Sam Ravnborg <sam@ravnborg.org> > > Best regards, > -- > Bartlomiej Zolnierkiewicz > Samsung R&D Institute Poland > Samsung Electronics > > > Bartlomiej Zolnierkiewicz (6): > video: fbdev: controlfb: fix sparse warning about using incorrect type > video: fbdev: controlfb: remove obsolete module support > video: fbdev: controlfb: add COMPILE_TEST support > video: fbdev: controlfb: remove function prototypes part #1 > video: fbdev: controlfb: remove function prototypes part #2 > video: fbdev: controlfb: remove function prototypes part #3 > > drivers/video/fbdev/Kconfig | 2 +- > drivers/video/fbdev/controlfb.c | 810 +++++++++++++++----------------- > 2 files changed, 383 insertions(+), 429 deletions(-) > > -- > 2.24.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel