mbox series

[v4,0/2] Add support for ASUS Z00T TM5P5 NT35596 panel

Message ID 20200506210957.344590-1-konradybcio@gmail.com (mailing list archive)
Headers show
Series Add support for ASUS Z00T TM5P5 NT35596 panel | expand

Message

Konrad Dybcio May 6, 2020, 9:09 p.m. UTC
changes since v3:
- fix dt-bindings issue

changes since v2:
- fix Kconfig indentation

changes since v1:
- make `backlight_properties props` constant
- a couple of line breaks
- change name and compatible to reflect ASUS being the vendor
- remove a redundant TODO

Konrad Dybcio (2):
  drivers: drm: panel: Add ASUS TM5P5 NT35596 panel driver
  dt-bindings: display: Document ASUS Z00T TM5P5 NT35596 panel
    compatible

 .../panel/asus,z00t-tm5p5-nt35596.yaml        |  56 +++
 drivers/gpu/drm/panel/Kconfig                 |  10 +
 drivers/gpu/drm/panel/Makefile                |   1 +
 .../drm/panel/panel-asus-z00t-tm5p5-n35596.c  | 367 ++++++++++++++++++
 4 files changed, 434 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/panel/asus,z00t-tm5p5-nt35596.yaml
 create mode 100644 drivers/gpu/drm/panel/panel-asus-z00t-tm5p5-n35596.c

Comments

Sam Ravnborg May 7, 2020, 7:58 p.m. UTC | #1
Hi Konrad.

On Wed, May 06, 2020 at 11:09:54PM +0200, Konrad Dybcio wrote:
> changes since v3:
> - fix dt-bindings issue
> 
> changes since v2:
> - fix Kconfig indentation
> 
> changes since v1:
> - make `backlight_properties props` constant
> - a couple of line breaks
> - change name and compatible to reflect ASUS being the vendor
> - remove a redundant TODO
> 
> Konrad Dybcio (2):
>   drivers: drm: panel: Add ASUS TM5P5 NT35596 panel driver
>   dt-bindings: display: Document ASUS Z00T TM5P5 NT35596 panel
>     compatible

Thanks, applied in the reverse order to have the binding before the
driver.
Fixed a few checkpatch warnings while applying.
We use --strict for code in drivers/gpu/*

	Sam

> 
>  .../panel/asus,z00t-tm5p5-nt35596.yaml        |  56 +++
>  drivers/gpu/drm/panel/Kconfig                 |  10 +
>  drivers/gpu/drm/panel/Makefile                |   1 +
>  .../drm/panel/panel-asus-z00t-tm5p5-n35596.c  | 367 ++++++++++++++++++
>  4 files changed, 434 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/panel/asus,z00t-tm5p5-nt35596.yaml
>  create mode 100644 drivers/gpu/drm/panel/panel-asus-z00t-tm5p5-n35596.c
> 
> -- 
> 2.26.2