From patchwork Tue Jun 16 21:21:23 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lubomir Rintel X-Patchwork-Id: 11609233 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E5B9D90 for ; Wed, 17 Jun 2020 07:26:56 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CEC8C20786 for ; Wed, 17 Jun 2020 07:26:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CEC8C20786 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=v3.sk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 976136EA9F; Wed, 17 Jun 2020 07:26:06 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from v6.sk (v6.sk [167.172.42.174]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2D2826E99F; Tue, 16 Jun 2020 21:22:03 +0000 (UTC) Received: from localhost (v6.sk [IPv6:::1]) by v6.sk (Postfix) with ESMTP id 8B6DE61634; Tue, 16 Jun 2020 21:21:31 +0000 (UTC) From: Lubomir Rintel To: Lucas Stach Subject: [RESEND PATCH v2 0/4] drm/etnaviv: Tidy up clocks handling Date: Tue, 16 Jun 2020 23:21:23 +0200 Message-Id: <20200616212127.986410-1-lkundrak@v3.sk> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 X-Mailman-Approved-At: Wed, 17 Jun 2020 07:26:02 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, Russell King , dri-devel@lists.freedesktop.org, etnaviv@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi, please consider applying patches that are chained to this message. They make getting/enabling the clocks in the etnaviv driver slightly nicer, first two also fix potential problems. Compared to v1, patch 2/4 was fixed and patch 3/4 was added. As it was pointed out in response to v1, the clocks documented as mandatory by the binding document are different from what the driver enforces. Moreover, there is no agreement on which clocks must be present in the device tree, so I'm leaving the binding document until it's cleared up. In any case, the "core" clock is always present so it's safe to make it mandatory and regardless of what ends up happening to the binding documentation, the other clocks can't be enforced without regressions. At most a comment or a warning could be added. I'm leaving it as it is. Thank you Lubo