[v3,0/1] drm/bridge: ps8640: Make sure all needed is powered to get the EDID

Message

Enric Balletbo i Serra Aug. 27, 2020, 8:59 a.m. UTC

The first 4 patches of the series version 2:
  - drm/bridge_connector: Set default status connected for eDP connectors
  - drm/bridge: ps8640: Get the EDID from eDP control
  - drm/bridge: ps8640: Return an error for incorrect attach flags
  - drm/bridge: ps8640: Print an error if VDO control fails

Are already applied to drm-misc-next, so I removed from this series. The
pending patch is part of the original series and is a rework of the power
handling to get the EDID. Basically, we need to make sure all the
needed is powered to be able to get the EDID. Before, we saw that getting
the EDID failed as explained in the third patch.

[1] https://lkml.org/lkml/2020/6/15/1208

Changes in v3:
- Make poweron/poweroff and pre_enable/post_disable reverse one to each other (Sam Ravnborg)

Changes in v2:
- Use drm_bridge_chain_pre_enable/post_disable() helpers (Sam Ravnborg)

Enric Balletbo i Serra (1):
  drm/bridge: ps8640: Rework power state handling

 drivers/gpu/drm/bridge/parade-ps8640.c | 68 ++++++++++++++++++++++----
 1 file changed, 58 insertions(+), 10 deletions(-)

Comments

Enric Balletbo i Serra Sept. 15, 2020, 12:40 p.m. UTC | #1

Hi Sam,

On 27/8/20 10:59, Enric Balletbo i Serra wrote:
> The first 4 patches of the series version 2:
>   - drm/bridge_connector: Set default status connected for eDP connectors
>   - drm/bridge: ps8640: Get the EDID from eDP control
>   - drm/bridge: ps8640: Return an error for incorrect attach flags
>   - drm/bridge: ps8640: Print an error if VDO control fails
> 
> Are already applied to drm-misc-next, so I removed from this series. The
> pending patch is part of the original series and is a rework of the power
> handling to get the EDID. Basically, we need to make sure all the
> needed is powered to be able to get the EDID. Before, we saw that getting
> the EDID failed as explained in the third patch.
> 
> [1] https://lkml.org/lkml/2020/6/15/1208
> 
> Changes in v3:
> - Make poweron/poweroff and pre_enable/post_disable reverse one to each other (Sam Ravnborg)
> 
> Changes in v2:
> - Use drm_bridge_chain_pre_enable/post_disable() helpers (Sam Ravnborg)
> 
> Enric Balletbo i Serra (1):
>   drm/bridge: ps8640: Rework power state handling
> 
>  drivers/gpu/drm/bridge/parade-ps8640.c | 68 ++++++++++++++++++++++----
>  1 file changed, 58 insertions(+), 10 deletions(-)
> 

A gentle ping on this patch. Would be nice land this together with the already
accepted patches.

Thanks,
  Enric

Neil Armstrong Sept. 15, 2020, 1:10 p.m. UTC | #2

Hi,

On 15/09/2020 14:40, Enric Balletbo i Serra wrote:
> Hi Sam,
> 
> On 27/8/20 10:59, Enric Balletbo i Serra wrote:
>> The first 4 patches of the series version 2:
>>   - drm/bridge_connector: Set default status connected for eDP connectors
>>   - drm/bridge: ps8640: Get the EDID from eDP control
>>   - drm/bridge: ps8640: Return an error for incorrect attach flags
>>   - drm/bridge: ps8640: Print an error if VDO control fails
>>
>> Are already applied to drm-misc-next, so I removed from this series. The
>> pending patch is part of the original series and is a rework of the power
>> handling to get the EDID. Basically, we need to make sure all the
>> needed is powered to be able to get the EDID. Before, we saw that getting
>> the EDID failed as explained in the third patch.
>>
>> [1] https://lkml.org/lkml/2020/6/15/1208
>>
>> Changes in v3:
>> - Make poweron/poweroff and pre_enable/post_disable reverse one to each other (Sam Ravnborg)
>>
>> Changes in v2:
>> - Use drm_bridge_chain_pre_enable/post_disable() helpers (Sam Ravnborg)
>>
>> Enric Balletbo i Serra (1):
>>   drm/bridge: ps8640: Rework power state handling
>>
>>  drivers/gpu/drm/bridge/parade-ps8640.c | 68 ++++++++++++++++++++++----
>>  1 file changed, 58 insertions(+), 10 deletions(-)
>>
> 
> A gentle ping on this patch. Would be nice land this together with the already
> accepted patches.

Applying it to drm-misc-next

Thanks,
Neil

> 
> Thanks,
>   Enric
>