mbox series

[v2,0/4] Revert "drm/amd/display: Expose new CRC window property" and changes associated with this commit

Message ID 20210112145508.1564863-1-Rodrigo.Siqueira@amd.com (mailing list archive)
Headers show
Series Revert "drm/amd/display: Expose new CRC window property" and changes associated with this commit | expand

Message

Rodrigo Siqueira Jordao Jan. 12, 2021, 2:55 p.m. UTC
Hi,

In the V1, Wayne pointed out two problems:

1. The revert patch included one extra line that does not belong to it;
2. The original patch also had other fixes in the same commit;

I removed the extra line from the reverted patch for tackling this
issue, and I added one additional patch to this series that includes the
other fix requested by Wayne.

Thanks

Original cover letter:
A couple of weeks ago, Daniel highlighted  [1] some issue related to a
patch entitle "drm/amd/display: Expose new CRC window property". After
discussion, we realize that we can revert that patch because we will
need to create a debugfs or full UAPI for CRC soon, which will make this
code obsolete. We got two other patches related to this same code; for
this reason, this patchset reverts all changes associated with that
specific commit.

Rodrigo Siqueira (3):
  Revert "drm/amd/display: Fix unused variable warning"
  Revert "drm/amdgpu/disply: fix documentation warnings in display
    manager"
  Revert "drm/amd/display: Expose new CRC window property"

Wayne Lin (1):
  drm/amd/display: Fix to be able to stop crc calculation

 .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 142 ++----------------
 .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h |  38 -----
 .../drm/amd/display/amdgpu_dm/amdgpu_dm_crc.c |  54 +------
 .../drm/amd/display/amdgpu_dm/amdgpu_dm_crc.h |   5 +-
 4 files changed, 11 insertions(+), 228 deletions(-)

Comments

Alex Deucher Jan. 12, 2021, 3:02 p.m. UTC | #1
On Tue, Jan 12, 2021 at 9:55 AM Rodrigo Siqueira
<Rodrigo.Siqueira@amd.com> wrote:
>
> Hi,
>
> In the V1, Wayne pointed out two problems:
>
> 1. The revert patch included one extra line that does not belong to it;
> 2. The original patch also had other fixes in the same commit;
>
> I removed the extra line from the reverted patch for tackling this
> issue, and I added one additional patch to this series that includes the
> other fix requested by Wayne.
>
> Thanks
>
> Original cover letter:
> A couple of weeks ago, Daniel highlighted  [1] some issue related to a
> patch entitle "drm/amd/display: Expose new CRC window property". After
> discussion, we realize that we can revert that patch because we will
> need to create a debugfs or full UAPI for CRC soon, which will make this
> code obsolete. We got two other patches related to this same code; for
> this reason, this patchset reverts all changes associated with that
> specific commit.
>
> Rodrigo Siqueira (3):
>   Revert "drm/amd/display: Fix unused variable warning"
>   Revert "drm/amdgpu/disply: fix documentation warnings in display
>     manager"
>   Revert "drm/amd/display: Expose new CRC window property"
>
> Wayne Lin (1):
>   drm/amd/display: Fix to be able to stop crc calculation
>

Series is:
Acked-by: Alex Deucher <alexander.deucher@amd.com>

>  .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 142 ++----------------
>  .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h |  38 -----
>  .../drm/amd/display/amdgpu_dm/amdgpu_dm_crc.c |  54 +------
>  .../drm/amd/display/amdgpu_dm/amdgpu_dm_crc.h |   5 +-
>  4 files changed, 11 insertions(+), 228 deletions(-)
>
> --
> 2.25.1
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Wayne Lin Jan. 13, 2021, 9:19 a.m. UTC | #2
Thanks Siqueira.

Series is:
Reviewed-by: Wayne Lin<Wayne.Lin@amd.com>

On 1/12/21 10:55 PM, Rodrigo Siqueira wrote:
> Hi,
>
> In the V1, Wayne pointed out two problems:
>
> 1. The revert patch included one extra line that does not belong to it;
> 2. The original patch also had other fixes in the same commit;
>
> I removed the extra line from the reverted patch for tackling this
> issue, and I added one additional patch to this series that includes the
> other fix requested by Wayne.
>
> Thanks
>
> Original cover letter:
> A couple of weeks ago, Daniel highlighted  [1] some issue related to a
> patch entitle "drm/amd/display: Expose new CRC window property". After
> discussion, we realize that we can revert that patch because we will
> need to create a debugfs or full UAPI for CRC soon, which will make this
> code obsolete. We got two other patches related to this same code; for
> this reason, this patchset reverts all changes associated with that
> specific commit.
>
> Rodrigo Siqueira (3):
>    Revert "drm/amd/display: Fix unused variable warning"
>    Revert "drm/amdgpu/disply: fix documentation warnings in display
>      manager"
>    Revert "drm/amd/display: Expose new CRC window property"
>
> Wayne Lin (1):
>    drm/amd/display: Fix to be able to stop crc calculation
>
>   .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 142 ++----------------
>   .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h |  38 -----
>   .../drm/amd/display/amdgpu_dm/amdgpu_dm_crc.c |  54 +------
>   .../drm/amd/display/amdgpu_dm/amdgpu_dm_crc.h |   5 +-
>   4 files changed, 11 insertions(+), 228 deletions(-)
>