From patchwork Tue Jan 12 14:55:04 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rodrigo Siqueira Jordao X-Patchwork-Id: 12013669 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D55EC433E6 for ; Tue, 12 Jan 2021 14:55:55 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D0B03221EC for ; Tue, 12 Jan 2021 14:55:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D0B03221EC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=amd.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 992DA6E252; Tue, 12 Jan 2021 14:55:53 +0000 (UTC) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2067.outbound.protection.outlook.com [40.107.244.67]) by gabe.freedesktop.org (Postfix) with ESMTPS id A30B46E23B; Tue, 12 Jan 2021 14:55:52 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dTw6CV9qHnumGjULcP4NrfCGSfLg9YvALO+xsFx+PMwAPiy6akHdzv/y0PEVx7hzsG0gkMjxA+Ghjra8eoERmYlikmCc9uGkzYHwo/VtbZ8Ph1gtdo/3WT6wcNOM6HoBwHPuhyGm0wm/zPezdtNWdHEphgBbfOikPhP6OAiu0KffTji7HIf5OrK/IAEF6j4oEI4y8Yg01tdzQUvKAKzkfsmMOsCvL6K3OZ0aQSuv3AzCFrsrf9G3VunXIvQXFfgfIkOpLG0Cb5ENYiSn0jywEOLI6NsrIEQdxcC9TCcEBw7HAnS+oSiTS+p49TnFlvddpaVOSFYTYRDu8a1oEf81Hg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Nlec4M4dz0fHAOeUVWmoLQbgcDT9sQ9Hs/Sxdf4i4IM=; b=WjTAJdJbm+ZU9FXsNvLFHYk7dXb4xnx/ixrthiVfovQ6FC6FtFfNbJA/tGZgD4cMeYGoROxcxRo5X2i1H4zbQSLDRU2kwghMGhDBU3aq46lZdWMJaS/+Hy106dCdv9vGXczdpXTGibsVFax02o9bhteTxW91Wcl9MfPFRrHBCzXLEMnbWTiubfbF9wPx3h2CUM0XMqnOsDHZOxJzQwidfEGUkvUApxQpBen2ZJ4ofeUTXTNyN9XFwtKRufYoKbyyHBofxoCc05GCcNW6/+1ow1UxXyeJ2+8yO3Zi3Mdgo3pd+JkMfEqQJGvJtdN3W913Tm1Pcp5aQat0dB6tbyUpJA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Nlec4M4dz0fHAOeUVWmoLQbgcDT9sQ9Hs/Sxdf4i4IM=; b=znLz1/IX1W8eyiiNBGDiO8BZo0rgi08U9ZqtpvU0YMe1384Gpbe3ExtjsKOg71mdo5SaGLL+xJZpsy0IG0sUXw+QuA7q2+buCI3PmDfnxbNoXwr5iRJredyz7QrcdxarCrpJWpHBLY966xuYjJ4/9u+3kkTCp6LLDI0fe5OWgJ0= Authentication-Results: lists.freedesktop.org; dkim=none (message not signed) header.d=none; lists.freedesktop.org; dmarc=none action=none header.from=amd.com; Received: from DM5PR12MB1753.namprd12.prod.outlook.com (2603:10b6:3:10d::16) by DM5PR1201MB2490.namprd12.prod.outlook.com (2603:10b6:3:e3::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3742.6; Tue, 12 Jan 2021 14:55:51 +0000 Received: from DM5PR12MB1753.namprd12.prod.outlook.com ([fe80::1cf5:9c9e:7374:4540]) by DM5PR12MB1753.namprd12.prod.outlook.com ([fe80::1cf5:9c9e:7374:4540%12]) with mapi id 15.20.3742.012; Tue, 12 Jan 2021 14:55:51 +0000 From: Rodrigo Siqueira To: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: [PATCH v2 0/4] Revert "drm/amd/display: Expose new CRC window property" and changes associated with this commit Date: Tue, 12 Jan 2021 09:55:04 -0500 Message-Id: <20210112145508.1564863-1-Rodrigo.Siqueira@amd.com> X-Mailer: git-send-email 2.25.1 X-Originating-IP: [2607:fea8:56e0:6d60:24ef:ec9:b88:9a22] X-ClientProxiedBy: BN8PR16CA0011.namprd16.prod.outlook.com (2603:10b6:408:4c::24) To DM5PR12MB1753.namprd12.prod.outlook.com (2603:10b6:3:10d::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from atma2.hitronhub.home (2607:fea8:56e0:6d60:24ef:ec9:b88:9a22) by BN8PR16CA0011.namprd16.prod.outlook.com (2603:10b6:408:4c::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3763.9 via Frontend Transport; Tue, 12 Jan 2021 14:55:50 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 55040de1-c058-40cb-737d-08d8b70a276d X-MS-TrafficTypeDiagnostic: DM5PR1201MB2490: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2803; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dnL+32VYb6ltm4yhcLL3+FyGAoltXpCOk804tQ4wCEL+yYlfxMY3BQHf47zMu/iI8lRNT4PLqh+tj5khbEmPzTWqdeEUEfYeWfRz0C5lGnYtkJz2jUzu85fBUrJQxKXuiYtSm24aNmZxnURDW2+lNIfQrVYIil7LLSoBl4UfkYl2xUeRve9jBPcBUTJAAIGSmscNwcv/03C0WDtHgkpjix4LM6AxHEkwIm34xjsZYDUKpfDjYuP7Wgt913Zv8TqJ2HbWCguR6TqPMyRy0GMafOyhbPoiyU6uu8kWEtxeMohgecTMktzwwP+HUMIxeGo9Jul0hRX9ueGXPtaHBPJEf6MXEcMmlM0wSt0vEfX6hM++zt3RP8BX0rJguPZoY8ugKYfxRmmM0mlJ3jjlWNAxyw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR12MB1753.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(396003)(346002)(39860400002)(136003)(376002)(54906003)(186003)(6666004)(6506007)(6512007)(8936002)(86362001)(52116002)(66946007)(83380400001)(16526019)(8676002)(5660300002)(6486002)(2906002)(316002)(4326008)(1076003)(478600001)(66476007)(66556008)(36756003)(2616005); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: v7qyejyZF2ieZSVJfI7p6J4nfOZ04+xv/tkHi/y+vWD/v7JNZvBlrFjngqOz2HdXLxAhV43jPcsxXYtlf6XD6jr9N6b6tQ1KIBuMdydb072o58/8p0SmnfyOYlCnToL9OWOx9QEdXhBgpgr53LsT4yqZyizQBi1QQpQh0wrCqVhm/ZgFxKhSwY2Cu10c0cW6f/PNJkDUGY3Y55+1yNGiRBTyAr/JS3TKuaO7kNMDPVkxSsJs4/MgQ826WxXc+x9rOQ5ZrTkSbTqUmv/xFWtzwlABW8iZ0luP3wvy5qv9b5scNVqt3v/ps3/3389lxBfWshILDySz8P7CGhzxo9PlCMmaEubJOKMp5wLtjZBe5zrEolrcuSbVJyui6FH8BIDgctMZF9C8iVYysYHUJs36ye4WyfgwRujhsqgB4RQJPdVNDiNX6eIvmVQAp9JAkYIfNEzEvti2D1+PyO0xY1/tGo0rmJwT4bEdBaRlZc0ennIGDSrvLzjEwpNQjUzwY0B6P81UMhof1It2LSae+MAqPDBV9Kh+yL6MSk6DYYUYipUV3/K0/xLSzbVxT8zDUKGGj82fgg/gK7OI2qrRMEnzTuZJ8vKaff94dCixhzz2kcacErSzFOE00Q2LA4a/aaSvVjunJgyjZ7udU8OrupfyEaURACuUg7mZoWDWh4PLnh8rnCig38uJc4H/qfkr+WIc78s4cQWFzU2gU87D/apBbIjJwRwARRrn8kKH7j6fGhhkhjDi1RD3NTLzwUT/BeTRxpGmdsFX35/kryHI9w9/KVdT4hBIJbmUr3XoME0yKTfYJgCImJcOp15hqVIj2HE3OC7XWApe+Skyga2zZnl5vQivQyEeYQsXPY2fViXEOMUCbP5NMfkLL+9wwIQodWs5Eti3OGWPiZS7LJ4CtB39ieRPwGrY9/B1Pzquqd30khjz7Fz+UD6PrS5pVXAwLI1V+CshyqXz+H638OZMf2GnGwf6K7WYxUV0uuiydl/odrypKvycrWVaMeE30W2zqZFMkVJWHd0q5TEyfCUBY85MtYHE67Y7HZriUWdb2jOckIUyw2uXTCmSef07bTsicJ+W X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthSource: DM5PR12MB1753.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2021 14:55:51.0666 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-Network-Message-Id: 55040de1-c058-40cb-737d-08d8b70a276d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: isYqqvkQu4xI+ppAWnt3Sew+6oW+ZvygJ72OzbJyojkZt81/Uykox8wF96XBlha6JgsxwrPwGigQHitGjuuFFg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1201MB2490 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Roman Li , Wayne Lin , Alexander Deucher , Bindu R Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi, In the V1, Wayne pointed out two problems: 1. The revert patch included one extra line that does not belong to it; 2. The original patch also had other fixes in the same commit; I removed the extra line from the reverted patch for tackling this issue, and I added one additional patch to this series that includes the other fix requested by Wayne. Thanks Original cover letter: A couple of weeks ago, Daniel highlighted [1] some issue related to a patch entitle "drm/amd/display: Expose new CRC window property". After discussion, we realize that we can revert that patch because we will need to create a debugfs or full UAPI for CRC soon, which will make this code obsolete. We got two other patches related to this same code; for this reason, this patchset reverts all changes associated with that specific commit. Rodrigo Siqueira (3): Revert "drm/amd/display: Fix unused variable warning" Revert "drm/amdgpu/disply: fix documentation warnings in display manager" Revert "drm/amd/display: Expose new CRC window property" Wayne Lin (1): drm/amd/display: Fix to be able to stop crc calculation .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 142 ++---------------- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 38 ----- .../drm/amd/display/amdgpu_dm/amdgpu_dm_crc.c | 54 +------ .../drm/amd/display/amdgpu_dm/amdgpu_dm_crc.h | 5 +- 4 files changed, 11 insertions(+), 228 deletions(-) Acked-by: Alex Deucher Reviewed-by: Wayne Lin