mbox series

[0/2] Add support for querying hw info that UMDs need

Message ID 20210727022145.157343-1-John.C.Harrison@Intel.com (mailing list archive)
Headers show
Series Add support for querying hw info that UMDs need | expand

Message

John Harrison July 27, 2021, 2:21 a.m. UTC
From: John Harrison <John.C.Harrison@Intel.com>

Various UMDs require hardware configuration information about the
current platform. A bunch of static information is available in a
fixed table that can be retrieved from the GuC.

Test-with: 20210727002812.43469-2-John.C.Harrison@Intel.com
UMD: https://github.com/intel/compute-runtime/pull/432/files

Signed-off-by: John Harrison <John.C.Harrison@Intel.com>


John Harrison (1):
  drm/i915/guc: Add fetch of hwconfig table

Rodrigo Vivi (1):
  drm/i915/uapi: Add query for hwconfig table

 drivers/gpu/drm/i915/Makefile                 |   1 +
 .../gpu/drm/i915/gt/uc/abi/guc_actions_abi.h  |   1 +
 .../gpu/drm/i915/gt/uc/abi/guc_errors_abi.h   |   4 +
 drivers/gpu/drm/i915/gt/uc/intel_guc.c        |   3 +-
 drivers/gpu/drm/i915/gt/uc/intel_guc.h        |   2 +
 .../gpu/drm/i915/gt/uc/intel_guc_hwconfig.c   | 156 ++++++++++++++++++
 .../gpu/drm/i915/gt/uc/intel_guc_hwconfig.h   |  19 +++
 drivers/gpu/drm/i915/gt/uc/intel_uc.c         |   6 +
 drivers/gpu/drm/i915/i915_query.c             |  23 +++
 include/uapi/drm/i915_drm.h                   |   1 +
 10 files changed, 215 insertions(+), 1 deletion(-)
 create mode 100644 drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c
 create mode 100644 drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.h

Comments

Daniel Vetter July 27, 2021, 9:49 a.m. UTC | #1
On Mon, Jul 26, 2021 at 07:21:43PM -0700, John.C.Harrison@Intel.com wrote:
> From: John Harrison <John.C.Harrison@Intel.com>
> 
> Various UMDs require hardware configuration information about the
> current platform. A bunch of static information is available in a
> fixed table that can be retrieved from the GuC.
> 
> Test-with: 20210727002812.43469-2-John.C.Harrison@Intel.com
> UMD: https://github.com/intel/compute-runtime/pull/432/files
> 
> Signed-off-by: John Harrison <John.C.Harrison@Intel.com>

Can you pls submit this with all the usual suspect from the umd side (so
also media-driver and mesa) cced?

Also do the mesa/media-driver patches exist somewhere? Afaiui this isn't
very useful without those bits in place too.
-Daniel

> 
> 
> John Harrison (1):
>   drm/i915/guc: Add fetch of hwconfig table
> 
> Rodrigo Vivi (1):
>   drm/i915/uapi: Add query for hwconfig table
> 
>  drivers/gpu/drm/i915/Makefile                 |   1 +
>  .../gpu/drm/i915/gt/uc/abi/guc_actions_abi.h  |   1 +
>  .../gpu/drm/i915/gt/uc/abi/guc_errors_abi.h   |   4 +
>  drivers/gpu/drm/i915/gt/uc/intel_guc.c        |   3 +-
>  drivers/gpu/drm/i915/gt/uc/intel_guc.h        |   2 +
>  .../gpu/drm/i915/gt/uc/intel_guc_hwconfig.c   | 156 ++++++++++++++++++
>  .../gpu/drm/i915/gt/uc/intel_guc_hwconfig.h   |  19 +++
>  drivers/gpu/drm/i915/gt/uc/intel_uc.c         |   6 +
>  drivers/gpu/drm/i915/i915_query.c             |  23 +++
>  include/uapi/drm/i915_drm.h                   |   1 +
>  10 files changed, 215 insertions(+), 1 deletion(-)
>  create mode 100644 drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c
>  create mode 100644 drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.h
> 
> -- 
> 2.25.1
>
John Harrison July 27, 2021, 6:46 p.m. UTC | #2
On 7/27/2021 02:49, Daniel Vetter wrote:
> On Mon, Jul 26, 2021 at 07:21:43PM -0700, John.C.Harrison@Intel.com wrote:
>> From: John Harrison <John.C.Harrison@Intel.com>
>>
>> Various UMDs require hardware configuration information about the
>> current platform. A bunch of static information is available in a
>> fixed table that can be retrieved from the GuC.
>>
>> Test-with: 20210727002812.43469-2-John.C.Harrison@Intel.com
>> UMD: https://github.com/intel/compute-runtime/pull/432/files
>>
>> Signed-off-by: John Harrison <John.C.Harrison@Intel.com>
> Can you pls submit this with all the usual suspect from the umd side (so
> also media-driver and mesa) cced?
Do you have a list of names that you would like included?

>
> Also do the mesa/media-driver patches exist somewhere? Afaiui this isn't
> very useful without those bits in place too.
I don't know about mesa but the media team have the support in place in 
their internal tree and (as per compute) are waiting for us to push the 
kernel side. This also comes under the headings of both new platforms 
and platforms which are POR for GuC submission. So I believe a lot of 
the UMD side changes for the config table are wrapped up in their 
support for the new platforms/GuC as a whole and thus not yet ready for 
upstream.

John.


> -Daniel
>
>>
>> John Harrison (1):
>>    drm/i915/guc: Add fetch of hwconfig table
>>
>> Rodrigo Vivi (1):
>>    drm/i915/uapi: Add query for hwconfig table
>>
>>   drivers/gpu/drm/i915/Makefile                 |   1 +
>>   .../gpu/drm/i915/gt/uc/abi/guc_actions_abi.h  |   1 +
>>   .../gpu/drm/i915/gt/uc/abi/guc_errors_abi.h   |   4 +
>>   drivers/gpu/drm/i915/gt/uc/intel_guc.c        |   3 +-
>>   drivers/gpu/drm/i915/gt/uc/intel_guc.h        |   2 +
>>   .../gpu/drm/i915/gt/uc/intel_guc_hwconfig.c   | 156 ++++++++++++++++++
>>   .../gpu/drm/i915/gt/uc/intel_guc_hwconfig.h   |  19 +++
>>   drivers/gpu/drm/i915/gt/uc/intel_uc.c         |   6 +
>>   drivers/gpu/drm/i915/i915_query.c             |  23 +++
>>   include/uapi/drm/i915_drm.h                   |   1 +
>>   10 files changed, 215 insertions(+), 1 deletion(-)
>>   create mode 100644 drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c
>>   create mode 100644 drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.h
>>
>> -- 
>> 2.25.1
>>