| Message ID | 20210731082458.1962043-1-desmondcheongzx@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | locking/lockdep, drm: apply new lockdep assert in drm_auth.c | expand |
On Sat, Jul 31, 2021 at 04:24:56PM +0800, Desmond Cheong Zhi Xi wrote: > Hi, > > Following a discussion on the patch ("drm: use the lookup lock in > drm_is_current_master") [1], Peter Zijlstra proposed new lockdep_assert > helpers to make it convenient to compose lockdep checks together. > > This series includes the patch that introduces the new lockdep helpers, > then utilizes these helpers in drm_is_current_master_locked in the > following patch. > > v1 -> v2: > Patch 2: > - Updated the kerneldoc on the lock design of drm_file.master to explain > the use of lockdep_assert(). As suggested by Boqun Feng. > > Link: https://lore.kernel.org/lkml/20210722092929.244629-2-desmondcheongzx@gmail.com/ [1] Can you pls also cc: this to intel-gfx so the local CI there can pick it up and verify? Just to check we got it all. -Daniel > > Best wishes, > Desmond > > Desmond Cheong Zhi Xi (1): > drm: add lockdep assert to drm_is_current_master_locked > > Peter Zijlstra (1): > locking/lockdep: Provide lockdep_assert{,_once}() helpers > > drivers/gpu/drm/drm_auth.c | 6 +++--- > include/drm/drm_file.h | 4 ++++ > include/linux/lockdep.h | 41 +++++++++++++++++++------------------- > 3 files changed, 28 insertions(+), 23 deletions(-) > > -- > 2.25.1 >
On Mon, Aug 02, 2021 at 10:26:16AM +0200, Daniel Vetter wrote: > On Sat, Jul 31, 2021 at 04:24:56PM +0800, Desmond Cheong Zhi Xi wrote: > > Hi, > > > > Following a discussion on the patch ("drm: use the lookup lock in > > drm_is_current_master") [1], Peter Zijlstra proposed new lockdep_assert > > helpers to make it convenient to compose lockdep checks together. > > > > This series includes the patch that introduces the new lockdep helpers, > > then utilizes these helpers in drm_is_current_master_locked in the > > following patch. > > > > v1 -> v2: > > Patch 2: > > - Updated the kerneldoc on the lock design of drm_file.master to explain > > the use of lockdep_assert(). As suggested by Boqun Feng. > > > > Link: https://lore.kernel.org/lkml/20210722092929.244629-2-desmondcheongzx@gmail.com/ [1] > > Can you pls also cc: this to intel-gfx so the local CI there can pick it > up and verify? Just to check we got it all. Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org> Feel free to take it through the drm tree.
On 2/8/21 4:26 pm, Daniel Vetter wrote: > On Sat, Jul 31, 2021 at 04:24:56PM +0800, Desmond Cheong Zhi Xi wrote: >> Hi, >> >> Following a discussion on the patch ("drm: use the lookup lock in >> drm_is_current_master") [1], Peter Zijlstra proposed new lockdep_assert >> helpers to make it convenient to compose lockdep checks together. >> >> This series includes the patch that introduces the new lockdep helpers, >> then utilizes these helpers in drm_is_current_master_locked in the >> following patch. >> >> v1 -> v2: >> Patch 2: >> - Updated the kerneldoc on the lock design of drm_file.master to explain >> the use of lockdep_assert(). As suggested by Boqun Feng. >> >> Link: https://lore.kernel.org/lkml/20210722092929.244629-2-desmondcheongzx@gmail.com/ [1] > > Can you pls also cc: this to intel-gfx so the local CI there can pick it > up and verify? Just to check we got it all. > -Daniel > Oops my bad, I missed out the CI for this series. Will resend with the proper cc. Best wishes, Desmond > >> >> Best wishes, >> Desmond >> >> Desmond Cheong Zhi Xi (1): >> drm: add lockdep assert to drm_is_current_master_locked >> >> Peter Zijlstra (1): >> locking/lockdep: Provide lockdep_assert{,_once}() helpers >> >> drivers/gpu/drm/drm_auth.c | 6 +++--- >> include/drm/drm_file.h | 4 ++++ >> include/linux/lockdep.h | 41 +++++++++++++++++++------------------- >> 3 files changed, 28 insertions(+), 23 deletions(-) >> >> -- >> 2.25.1 >> >
Hi, Following a discussion on the patch ("drm: use the lookup lock in drm_is_current_master") [1], Peter Zijlstra proposed new lockdep_assert helpers to make it convenient to compose lockdep checks together. This series includes the patch that introduces the new lockdep helpers, then utilizes these helpers in drm_is_current_master_locked in the following patch. v1 -> v2: Patch 2: - Updated the kerneldoc on the lock design of drm_file.master to explain the use of lockdep_assert(). As suggested by Boqun Feng. Link: https://lore.kernel.org/lkml/20210722092929.244629-2-desmondcheongzx@gmail.com/ [1] Best wishes, Desmond Desmond Cheong Zhi Xi (1): drm: add lockdep assert to drm_is_current_master_locked Peter Zijlstra (1): locking/lockdep: Provide lockdep_assert{,_once}() helpers drivers/gpu/drm/drm_auth.c | 6 +++--- include/drm/drm_file.h | 4 ++++ include/linux/lockdep.h | 41 +++++++++++++++++++------------------- 3 files changed, 28 insertions(+), 23 deletions(-)