| Message ID | 20210824225427.2065517-1-nathan@kernel.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | drm/i915: Enable -Wsometimes-uninitialized | expand |
On Tue, Aug 24, 2021 at 03:54:24PM -0700, Nathan Chancellor wrote: > Commit 46e2068081e9 ("drm/i915: Disable some extra clang warnings") > disabled -Wsometimes-uninitialized as noisy but there have been a few > fixes to clang that make the false positive rate fairly low so it should > be enabled to help catch obvious mistakes. The first two patches fix > revent instances of this warning then enables it for i915 like the rest > of the tree. > > Cheers, > Nathan > > Nathan Chancellor (3): > drm/i915/selftests: Do not use import_obj uninitialized > drm/i915/selftests: Always initialize err in > igt_dmabuf_import_same_driver_lmem() > drm/i915: Enable -Wsometimes-uninitialized > > drivers/gpu/drm/i915/Makefile | 1 - > drivers/gpu/drm/i915/gem/selftests/i915_gem_dmabuf.c | 7 ++++--- > 2 files changed, 4 insertions(+), 4 deletions(-) > > > base-commit: fb43ebc83e069625cfeeb2490efc3ffa0013bfa4 > -- > 2.33.0 > > Ping, could this be picked up for an -rc as these are very clearly bugs? Cheers, Nathan
On Mon, 13 Sep 2021, Nathan Chancellor <nathan@kernel.org> wrote: > On Tue, Aug 24, 2021 at 03:54:24PM -0700, Nathan Chancellor wrote: >> Commit 46e2068081e9 ("drm/i915: Disable some extra clang warnings") >> disabled -Wsometimes-uninitialized as noisy but there have been a few >> fixes to clang that make the false positive rate fairly low so it should >> be enabled to help catch obvious mistakes. The first two patches fix >> revent instances of this warning then enables it for i915 like the rest >> of the tree. >> >> Cheers, >> Nathan >> >> Nathan Chancellor (3): >> drm/i915/selftests: Do not use import_obj uninitialized >> drm/i915/selftests: Always initialize err in >> igt_dmabuf_import_same_driver_lmem() >> drm/i915: Enable -Wsometimes-uninitialized >> >> drivers/gpu/drm/i915/Makefile | 1 - >> drivers/gpu/drm/i915/gem/selftests/i915_gem_dmabuf.c | 7 ++++--- >> 2 files changed, 4 insertions(+), 4 deletions(-) >> >> >> base-commit: fb43ebc83e069625cfeeb2490efc3ffa0013bfa4 >> -- >> 2.33.0 >> >> > > Ping, could this be picked up for an -rc as these are very clearly bugs? Thanks for the patches and review. Pushed to drm-intel-gt-next and cherry-picked to drm-intel-fixes, header to -rc2. BR, Jani.
On Tue, Sep 14, 2021 at 08:10:14PM +0300, Jani Nikula wrote: > On Mon, 13 Sep 2021, Nathan Chancellor <nathan@kernel.org> wrote: > > On Tue, Aug 24, 2021 at 03:54:24PM -0700, Nathan Chancellor wrote: > >> Commit 46e2068081e9 ("drm/i915: Disable some extra clang warnings") > >> disabled -Wsometimes-uninitialized as noisy but there have been a few > >> fixes to clang that make the false positive rate fairly low so it should > >> be enabled to help catch obvious mistakes. The first two patches fix > >> revent instances of this warning then enables it for i915 like the rest > >> of the tree. > >> > >> Cheers, > >> Nathan > >> > >> Nathan Chancellor (3): > >> drm/i915/selftests: Do not use import_obj uninitialized > >> drm/i915/selftests: Always initialize err in > >> igt_dmabuf_import_same_driver_lmem() > >> drm/i915: Enable -Wsometimes-uninitialized > >> > >> drivers/gpu/drm/i915/Makefile | 1 - > >> drivers/gpu/drm/i915/gem/selftests/i915_gem_dmabuf.c | 7 ++++--- > >> 2 files changed, 4 insertions(+), 4 deletions(-) > >> > >> > >> base-commit: fb43ebc83e069625cfeeb2490efc3ffa0013bfa4 > >> -- > >> 2.33.0 > >> > >> > > > > Ping, could this be picked up for an -rc as these are very clearly bugs? > > Thanks for the patches and review. Pushed to drm-intel-gt-next and > cherry-picked to drm-intel-fixes, header to -rc2. Thanks a lot! Cheers, Nathan
Commit 46e2068081e9 ("drm/i915: Disable some extra clang warnings") disabled -Wsometimes-uninitialized as noisy but there have been a few fixes to clang that make the false positive rate fairly low so it should be enabled to help catch obvious mistakes. The first two patches fix revent instances of this warning then enables it for i915 like the rest of the tree. Cheers, Nathan Nathan Chancellor (3): drm/i915/selftests: Do not use import_obj uninitialized drm/i915/selftests: Always initialize err in igt_dmabuf_import_same_driver_lmem() drm/i915: Enable -Wsometimes-uninitialized drivers/gpu/drm/i915/Makefile | 1 - drivers/gpu/drm/i915/gem/selftests/i915_gem_dmabuf.c | 7 ++++--- 2 files changed, 4 insertions(+), 4 deletions(-) base-commit: fb43ebc83e069625cfeeb2490efc3ffa0013bfa4