From patchwork Wed Sep 1 20:19:18 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 12470213 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57189C432BE for ; Wed, 1 Sep 2021 20:20:29 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 18BB060FC0 for ; Wed, 1 Sep 2021 20:20:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 18BB060FC0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 838066E2A3; Wed, 1 Sep 2021 20:20:28 +0000 (UTC) Received: from mail-pf1-x42f.google.com (mail-pf1-x42f.google.com [IPv6:2607:f8b0:4864:20::42f]) by gabe.freedesktop.org (Postfix) with ESMTPS id A10EA6E29D for ; Wed, 1 Sep 2021 20:20:26 +0000 (UTC) Received: by mail-pf1-x42f.google.com with SMTP id s29so738999pfw.5 for ; Wed, 01 Sep 2021 13:20:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=+u2QuOkRRMX/DqMZWfX/UVRQi9noRYZC06sr4Cz0Hp8=; b=ZMMPana7L7vTDCgu/jp5FKD2Lrbrz0jK26GBO0aS5kFqX8ZWAwDd8LGVRgMmKIW4cy pM4/1N42XKs3Esi1gnR1zGqKA++SzJlDvfQrVg5j28Z5B5k6XohhNOknkTV7aRkmINrK CmPERtsKo0Rsb/rb2L17uz6Xg8W52l6oAnoOY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=+u2QuOkRRMX/DqMZWfX/UVRQi9noRYZC06sr4Cz0Hp8=; b=hiHXN+eG87VMkGVNystQlqXbda1QT3RiDbuJpbBgC0ceXZALYGmxOiKZ+gpf3wRB8j jlx6fhriEfUHR8yks1D8bPL6Y8+Z6MjDCGS06Q2cNg2T6tMTYj/s5+QzT/h4FoRmkBPJ 5/X+im9zEUghSGAfwUUNvCoCuVxbsOIJuCpiR2FYy6bIfFDH/IwkcrIjpD9RORFdL5bl SDJQ6JkVtMPracUL0bxaSDLoBd6K4xmU1jXsCbXITHTe/XLAzrDKKvbnrgD6kKD9hIeN 74gkNvvYtZODnewKqgH6mAGcw6HTet0l0is8o/xFazzGCgiCz96APQbBXjnVqKkPVTgM HHRw== X-Gm-Message-State: AOAM532cKEvTqieRDmoiPOrMiwdx/O1tKKeLD4QUkdLP+BfWYkEfRAMk /zDZ+nIhwiL2PK9RbyVYc/sX5Q== X-Google-Smtp-Source: ABdhPJzep5JI+YTg6jYwfIvOqV7EJbMgqrs4tymTqpHRzn2sts2yu7nyKA3inirB5PAxwEJh4dOyVA== X-Received: by 2002:a65:6642:: with SMTP id z2mr790331pgv.240.1630527626154; Wed, 01 Sep 2021 13:20:26 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:202:201:958b:b561:a735:e774]) by smtp.gmail.com with ESMTPSA id x15sm321178pfq.31.2021.09.01.13.20.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Sep 2021 13:20:25 -0700 (PDT) From: Douglas Anderson To: Thierry Reding , Rob Herring , Sam Ravnborg Cc: Maarten Lankhorst , linux-arm-msm@vger.kernel.org, Bjorn Andersson , Linus W , Daniel Vetter , devicetree@vger.kernel.org, Steev Klimaszewski , Thomas Zimmermann , Maxime Ripard , David Airlie , dri-devel@lists.freedesktop.org, Douglas Anderson , Al Viro , Alexandre Belloni , Alexandre Torgue , Andreas Kemnade , Andrey Zhizhikin , Anson Huang , Arnd Bergmann , Catalin Marinas , Chen-Yu Tsai , Claudiu Beznea , Codrin Ciubotariu , Corentin Labbe , Daniel Thompson , Dmitry Baryshkov , Dmitry Osipenko , Emil Velikov , Enric Balletbo i Serra , Eugen Hristev , Fabio Estevam , Fabrice Gasnier , Florian Fainelli , Geert Uytterhoeven , Grygorii Strashko , =?utf-8?q?Guido_G=C3=BCnther?= , Jagan Teki , Jernej Skrabec , Joel Stanley , Jonathan Hunter , Kees Cook , Krzysztof Kozlowski , Krzysztof Kozlowski , Lionel Debieve , Liviu Dudau , Lorenzo Pieralisi , Ludovic Desroches , Magnus Damm , Manivannan Sadhasivam , Marek Szyprowski , =?utf-8?q?Martin_J=C3=BCcker?= , Michael Walle , NXP Linux Team , Nicolas Ferre , Nishanth Menon , Olivier Moysan , Olof Johansson , Otavio Salvador , Paul Cercueil , Pengutronix Kernel Team , Razvan Stefanescu , Robert Richter , Russell King , Sascha Hauer , Shawn Guo , Stefan Wahren , Sudeep Holla , Thomas Bogendoerfer , Tony Lindgren , Tudor Ambarus , Vinod Koul , Viresh Kumar , Vladimir Zapolskiy , Will Deacon , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-omap@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, =?utf-8?q?=C5=81ukasz_Stelmach?= Subject: [PATCH v3 00/16] eDP: Support probing eDP panels dynamically instead of hardcoding Date: Wed, 1 Sep 2021 13:19:18 -0700 Message-Id: <20210901201934.1084250-1-dianders@chromium.org> X-Mailer: git-send-email 2.33.0.259.gc128427fd7-goog MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The goal of this patch series is to move away from hardcoding exact eDP panels in device tree files. As discussed in the various patches in this series (I'm not repeating everything here), most eDP panels are 99% probable and we can get that last 1% by allowing two "power up" delays to be specified in the device tree file and then using the panel ID (found in the EDID) to look up additional power sequencing delays for the panel. This patch series is the logical contiunation of a previous patch series where I proposed solving this problem by adding a board-specific compatible string [1]. In the discussion that followed it sounded like people were open to something like the solution proposed in this new series. In version 2 I got rid of the idea that we could have a "fallback" compatible string that we'd use if we didn't recognize the ID in the EDID. This simplifies the bindings a lot and the implementation somewhat. As a result of not having a "fallback", though, I'm not confident in transitioning any existing boards over to this since we'll have to fallback to very conservative timings if we don't recognize the ID from the EDID and I can't guarantee that I've seen every panel that might have shipped on an existing product. The plan is to use "edp-panel" only on new boards or new revisions of old boards where we can guarantee that every EDID that ships out of the factory has an ID in the table. Version 3 of this series now splits out all eDP panels to their own driver and adds the generic eDP panel support to this new driver. I believe this is what Sam was looking for [2]. [1] https://lore.kernel.org/r/YFKQaXOmOwYyeqvM@google.com/ [2] https://lore.kernel.org/r/YRTsFNTn%2FT8fLxyB@ravnborg.org/ Changes in v3: - Decode hex product ID w/ same endianness as everyone else. - ("Reorder logicpd_type_28...") patch new for v3. - Split eDP panels patch new for v3. - Move wayward panels patch new for v3. - ("Non-eDP panels don't need "HPD" handling") new for v3. - Split the delay structure out patch just on eDP now. - ("Better describe eDP panel delays") new for v3. - Fix "prepare_to_enable" patch new for v3. - ("Don't re-read the EDID every time") moved to eDP only patch. - Generic "edp-panel" handled by the eDP panel driver now. - Change init order to we power at the end. - Adjust endianness of product ID. - Fallback to conservative delays if panel not recognized. - Add Sharp LQ116M1JW10 to table. - Add AUO B116XAN06.1 to table. - Rename delays more generically so they can be reused. Changes in v2: - No longer allow fallback to panel-simple. - Add "-ms" suffix to delays. - Don't support a "fallback" panel. Probed panels must be probed. - Not based on patch to copy "desc"--just allocate for probed panels. - Add "-ms" suffix to delays. Douglas Anderson (16): dt-bindings: drm/panel-simple-edp: Introduce generic eDP panels drm/edid: Break out reading block 0 of the EDID drm/edid: Allow the querying/working with the panel ID from the EDID drm/panel-simple: Reorder logicpd_type_28 / mitsubishi_aa070mc01 drm/panel-simple-edp: Split eDP panels out of panel-simple ARM: configs: Everyone who had PANEL_SIMPLE now gets PANEL_SIMPLE_EDP arm64: defconfig: Everyone who had PANEL_SIMPLE now gets PANEL_SIMPLE_EDP MIPS: configs: Everyone who had PANEL_SIMPLE now gets PANEL_SIMPLE_EDP drm/panel-simple-edp: Move some wayward panels to the eDP driver drm/panel-simple: Non-eDP panels don't need "HPD" handling drm/panel-simple-edp: Split the delay structure out drm/panel-simple-edp: Better describe eDP panel delays drm/panel-simple-edp: hpd_reliable shouldn't be subtraced from hpd_absent drm/panel-simple-edp: Fix "prepare_to_enable" if panel doesn't handle HPD drm/panel-simple-edp: Don't re-read the EDID every time we power off the panel drm/panel-simple-edp: Implement generic "edp-panel"s probed by EDID .../bindings/display/panel/panel-edp.yaml | 188 ++ arch/arm/configs/at91_dt_defconfig | 1 + arch/arm/configs/exynos_defconfig | 1 + arch/arm/configs/imx_v6_v7_defconfig | 1 + arch/arm/configs/lpc32xx_defconfig | 1 + arch/arm/configs/multi_v5_defconfig | 1 + arch/arm/configs/multi_v7_defconfig | 1 + arch/arm/configs/omap2plus_defconfig | 1 + arch/arm/configs/qcom_defconfig | 1 + arch/arm/configs/realview_defconfig | 1 + arch/arm/configs/sama5_defconfig | 1 + arch/arm/configs/shmobile_defconfig | 1 + arch/arm/configs/sunxi_defconfig | 1 + arch/arm/configs/tegra_defconfig | 1 + arch/arm/configs/versatile_defconfig | 1 + arch/arm/configs/vexpress_defconfig | 1 + arch/arm64/configs/defconfig | 1 + arch/mips/configs/qi_lb60_defconfig | 1 + arch/mips/configs/rs90_defconfig | 1 + drivers/gpu/drm/drm_edid.c | 121 +- drivers/gpu/drm/panel/Kconfig | 16 +- drivers/gpu/drm/panel/Makefile | 1 + drivers/gpu/drm/panel/panel-simple-edp.c | 1895 +++++++++++++++++ drivers/gpu/drm/panel/panel-simple.c | 1100 +--------- include/drm/drm_edid.h | 47 + 25 files changed, 2293 insertions(+), 1093 deletions(-) create mode 100644 Documentation/devicetree/bindings/display/panel/panel-edp.yaml create mode 100644 drivers/gpu/drm/panel/panel-simple-edp.c Acked-by: Sam Ravnborg