[0/3] drm/omap: add crtc properties

Message

Neil Armstrong Sept. 21, 2021, 2:16 p.m. UTC

This patchset adds the following CRTC properties:
- background color
- transparency keying property
- alpha blender on DSS3

Tomi Valkeinen (3):
  drm/omap: add crtc background property
  drm/omap: add crtc transparency key property
  drm/omap: add alpha blender property

 drivers/gpu/drm/omapdrm/dss/dispc.c   |  4 +-
 drivers/gpu/drm/omapdrm/dss/omapdss.h |  2 +-
 drivers/gpu/drm/omapdrm/omap_crtc.c   | 85 ++++++++++++++++++++++++++-
 drivers/gpu/drm/omapdrm/omap_drv.c    | 30 ++++++++++
 drivers/gpu/drm/omapdrm/omap_drv.h    |  6 ++
 5 files changed, 121 insertions(+), 6 deletions(-)

Comments

Tomi Valkeinen Sept. 21, 2021, 2:28 p.m. UTC | #1

Hi Neil,

On 21/09/2021 17:16, Neil Armstrong wrote:
> This patchset adds the following CRTC properties:
> - background color
> - transparency keying property
> - alpha blender on DSS3
> 
> Tomi Valkeinen (3):
>    drm/omap: add crtc background property
>    drm/omap: add crtc transparency key property
>    drm/omap: add alpha blender property

Nack, these don't comply with DRM uAPI rules. That's why I never sent 
them upstream.

https://www.kernel.org/doc/html/latest/gpu/drm-uapi.html#open-source-userspace-requirements

  Tomi

Neil Armstrong Sept. 21, 2021, 2:30 p.m. UTC | #2

Hi Tomi,

On 21/09/2021 16:28, Tomi Valkeinen wrote:
> Hi Neil,
> 
> On 21/09/2021 17:16, Neil Armstrong wrote:
>> This patchset adds the following CRTC properties:
>> - background color
>> - transparency keying property
>> - alpha blender on DSS3
>>
>> Tomi Valkeinen (3):
>>    drm/omap: add crtc background property
>>    drm/omap: add crtc transparency key property
>>    drm/omap: add alpha blender property
> 
> Nack, these don't comply with DRM uAPI rules. That's why I never sent them upstream.
> 
> https://www.kernel.org/doc/html/latest/gpu/drm-uapi.html#open-source-userspace-requirements

Thanks for the reply, I was wondering why !

Neil

> 
>  Tomi