mbox series

[0/4] drm/i915: Make the driver not oops on load on old machines

Message ID 20211014090941.12159-1-ville.syrjala@linux.intel.com (mailing list archive)
Headers show
Series drm/i915: Make the driver not oops on load on old machines | expand

Message

Ville Syrjälä Oct. 14, 2021, 9:09 a.m. UTC
From: Ville Syrjälä <ville.syrjala@linux.intel.com>

Fix a pile of regression on older machines which just oops the driver
on load.

Cc: Dave Airlie <airlied@redhat.com>
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>

Ville Syrjälä (4):
  drm/i915: Replace the unconditional clflush with
    drm_clflush_virt_range()
  drm/i915: Convert unconditional clflush to drm_clflush_virt_range()
  drm/i915: Catch yet another unconditioal clflush
  drm/i915: Fix oops on platforms w/o hpd support

 drivers/gpu/drm/i915/display/intel_hotplug.c    | 3 ++-
 drivers/gpu/drm/i915/gt/intel_ring_submission.c | 2 +-
 drivers/gpu/drm/i915/gt/intel_timeline.c        | 4 ++--
 3 files changed, 5 insertions(+), 4 deletions(-)

Comments

Dave Airlie Oct. 17, 2021, 11:54 p.m. UTC | #1
On Thu, 14 Oct 2021 at 19:09, Ville Syrjala
<ville.syrjala@linux.intel.com> wrote:
>
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Fix a pile of regression on older machines which just oops the driver
> on load.
>

For all 4:

Reviewed-by: Dave Airlie <airlied@redhat.com>

though it would be nice if the clflushes has more justifications on
initial patch submission/review, maybe something for gt team to keep
an eye for patches coming out from internal.

Dave.
Ville Syrjälä Oct. 19, 2021, 9:08 a.m. UTC | #2
On Mon, Oct 18, 2021 at 09:54:59AM +1000, Dave Airlie wrote:
> On Thu, 14 Oct 2021 at 19:09, Ville Syrjala
> <ville.syrjala@linux.intel.com> wrote:
> >
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > Fix a pile of regression on older machines which just oops the driver
> > on load.
> >
> 
> For all 4:
> 
> Reviewed-by: Dave Airlie <airlied@redhat.com>
> 
> though it would be nice if the clflushes has more justifications on
> initial patch submission/review, maybe something for gt team to keep
> an eye for patches coming out from internal.

Thanks. clflush fixes pushed to drm-intel-gt-next. The hpd fix
I pushed to drm-intel-next already earlier.