From patchwork Mon Jan 24 21:03:17 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Helge Deller X-Patchwork-Id: 12722949 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D55FAC433F5 for ; Mon, 24 Jan 2022 21:04:51 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BF99810E147; Mon, 24 Jan 2022 21:04:50 +0000 (UTC) Received: from mout.gmx.net (mout.gmx.net [212.227.15.18]) by gabe.freedesktop.org (Postfix) with ESMTPS id F0CF410E147 for ; Mon, 24 Jan 2022 21:04:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1643058269; bh=Ec1E+XVbmVaZkoonfqus3Ied9jzwitQE64DgeYRcJ58=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date; b=SXmhUWQ1CRWaNWJ9KeqXwp3cEMR4JpqMknuHKQTpE2Ku65iaeIz0Kq7Sn8V2KzFLK XC2EVFoL2fI+8sb0leh3Ou1NfBsnomk8UH747CkEDXleOwmXqV5sJuDM4eLZIUl1we aIFuEWrexXiwOCzd1005n4PkEweyW+CWl1iH2p2w= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from ls3530.fritz.box ([92.116.165.96]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MgeoI-1me8CO3qrE-00h5pr; Mon, 24 Jan 2022 22:04:29 +0100 From: Helge Deller To: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org Subject: [PATCH v2 0/2] Fix regression introduced by disabling accelerated scrolling in fbcon Date: Mon, 24 Jan 2022 22:03:17 +0100 Message-Id: <20220124210319.325512-1-deller@gmx.de> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 X-Provags-ID: V03:K1:6FEDwYEykD2AOXr/nEQNj6xwhFHj/FdHKryvnHfF3emq2u1Ux8U SCBo/ypmBPN+TerQ3D8Vdyf+RD/HISBfpRglhojRAnBRGWsI1IFxN1J8e50EJu8PqYDo9kR tvi5lRY6NDsqmqVlxWTQpkwsJbBXtdKMXADp7LtZ8UVFk96aC+croFew1lnMVWnKaf8dG0r PsRdWUYwHaES2Yfi6MjHg== X-UI-Out-Filterresults: notjunk:1;V03:K0:lgwjfMC5XkQ=:w2BWauQ+JigdFMoVP/KZ+w HWFXAax0fMJH+uM6gdbk8RtDmh1Pb8iYZKn1XtEvXpM9zLTpxeYqRN2DBMTDGEdj274GZtvbJ sluAuboGYPFvyINtfXYM7R8f/yPF3fm1RqMAExGFqmcax05mrLHSi+Gg3FzTb7gHzi0R2pdv/ rQAXHG1SVZUIRaOT9fvuyCUxOx9hev+6ntoj9XY1Uuai2KeFykEDxUUugEqivyG/QGQQSOb57 fzoSDYM4N/NYiEAhD//QEV5/0gaOOWIQA7KveGSRiqzEIBdL+X73yWWqVhBMl2Wq+FKLFC3u1 vRERligauulv/2sFsQ8zT0d1d3BaX8+MAyWGjXOmSflk4mX5qRh3Uj1YMS4fSog/wbL/D5aJT 2+IRnEVvTieyVagL9mPBmnxFplt5s1JQZzUcMi4IItvT3/ymdEsZmV1nmnUdTtzzq6Z3f6iW4 TEexfwLvQLXIJK7WRvRqNj0GV1kF/UrlX5hfTyQ+5OfuJn1fr2+oHpTMVYWd4QGOPUpgXZUY1 mJYXZCAvJjzB/Lmic+azvkck5qYUZcuj3DL/DzbJHsVEPnnJSbPx/T4jKFSENpcFR3wo2Pycn ZsqIHBjMJT2PIrtJ5G/iuOfZz/PmpKdN7Cq2BB2evYcipAYqXqg25tSIIgy3Rw7H7ecfA/Gio x/6pog60QXv/ROTgSADpCryr6uielpB3ufFAKhZ26EmWze3myfRpOhjHMEiozm1DQpJZM5GO9 /2G5wrX496KA2ckmwVffqpoksH1A4aEBUrMrEtnaXqtsmdVcY+WK33Uzt37H/StUKJ1c+mUui fGoyT7rU2M7UafTuVkH2M2s+lohQnPJA/ZOEzAcNRWCHdJ+lIRvUeOUGCdaDOGDKtPd1hJQge kVFR7nepF+CFn9gualAvrzsvu+jgdHVaWBRE7WGWqSlqBcmyBjKyQOSThp67qyCODIwDSRl/c LYHFvu2x8KJwu3nnI17o7ZgH0dqy5fhYQ/1pHvFpKrUR1amSn9JHCLywJHt4pjVOBlsW7colX Bph4YuajvA5p5DIvOjphiTPQ14HjpZWJBPxliTcEIY3DLWmwdzDmTkhnJK6LQjAN2k664RA+k XfWcd2KXUPC8Vc= X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Pavel Machek , Sam Ravnborg , Greg Kroah-Hartman , Sven Schnelle , Javier Martinez Canillas , linux-kernel@vger.kernel.org, Tomi Valkeinen , Claudio Suarez , Gerd Hoffmann , Thomas Zimmermann , Daniel Vetter , Geert Uytterhoeven , Linus Torvalds Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" This series reverts two patches which disabled scrolling acceleration in fbcon/fbdev. Those patches introduced a regression for fbdev-supported graphic cards because of the performance penalty by doing screen scrolling by software instead of using existing 2D hardware acceleration. This series has been discussed on linux-fbdev, dri-devel and linux-kernel mailing lists. The consensus is that they will be reverted, but in addition it's being worked on to find a solution which allows to disable parts of the classic fbdev hardware acceleration code which isn't needed in DRM-only configurations. The patchset is planned to be kept in fbdev's for-next git branch and later pushed into kernel v5.18 if no issues are found until then. Helge --- Changes in v2 compared to v1: - adjusted the stable tags (one v5.10+, the other v5.16+) - moved the analysis and reasoning why those should be reverted into the commit message. That simplifies to analyze later why they were reverted. - resorted the To an Cc mail recipient lists Helge Deller (2): Revert "fbdev: Garbage collect fbdev scrolling acceleration, part 1 (from TODO list)" Revert "fbcon: Disable accelerated scrolling" Documentation/gpu/todo.rst | 24 -- drivers/video/fbdev/core/bitblit.c | 16 + drivers/video/fbdev/core/fbcon.c | 540 +++++++++++++++++++++++- drivers/video/fbdev/core/fbcon.h | 59 +++ drivers/video/fbdev/core/fbcon_ccw.c | 28 +- drivers/video/fbdev/core/fbcon_cw.c | 28 +- drivers/video/fbdev/core/fbcon_rotate.h | 9 + drivers/video/fbdev/core/fbcon_ud.c | 37 +- drivers/video/fbdev/core/tileblit.c | 16 + drivers/video/fbdev/skeletonfb.c | 12 +- include/linux/fb.h | 2 +- 11 files changed, 703 insertions(+), 68 deletions(-)