From patchwork Wed Feb 2 13:55:28 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Helge Deller X-Patchwork-Id: 12732960 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 59FB6C433F5 for ; Wed, 2 Feb 2022 13:55:37 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9E8DE10E338; Wed, 2 Feb 2022 13:55:36 +0000 (UTC) Received: from mout.gmx.net (mout.gmx.net [212.227.15.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id DAC3010E338 for ; Wed, 2 Feb 2022 13:55:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1643810132; bh=9kPU2SgWIl2EzJNwN4/tE9rBG4gYJqWzuyVOZfzz6uM=; h=X-UI-Sender-Class:From:To:Subject:Date; b=SlEb6IJoXKAm+U2H0YtzCnntK6PkYt6udTk8afaC8dGYr4S+gz2JZlvCEm0nTzv+3 GQKXRLbN1ZXfGqMvXcsqxtupPgdRzohdV0XPGIGayqjHi2U9NHghTkR3MOqsAX2M+Z VHORuUKys5RbAOPyZVSh0TFccLV9ozjyvSEyt8Rw= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from p100.fritz.box ([92.116.163.171]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1M6lpM-1n9DQY1VJG-008Jeb; Wed, 02 Feb 2022 14:55:32 +0100 From: Helge Deller To: Daniel Vetter , linux-fbdev@vger.kernel.org, DRI Development Subject: [PATCH v4 0/3] Fix regression introduced by disabling accelerated scrolling in fbcon Date: Wed, 2 Feb 2022 14:55:28 +0100 Message-Id: <20220202135531.92183-1-deller@gmx.de> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Provags-ID: V03:K1:nnGqynUr7n1KN1v8NmrpEx2V/sKRynbcFTjY/ZnC29V/hPI9t+x 6oltBpYzf3LNuSCM2EdUclQk362M4o5XtyKj506kKzq6fJ8r2sxjVlniG7VM0/9eSPhZFS8 rsJa2yUI9ZmTPD0rLJx9XPpHplYvQfNHNXUZp/Tqk/tNeNNNRcyvMxuFuvZNlYsx8PgoUBF O2uQnm6Gmx6F2UwigiKWA== X-UI-Out-Filterresults: notjunk:1;V03:K0:t6QzmaGKEdg=:WadYA2o7BhHzHXXZ6B8vD+ VzlL6EiDhAdUL3W9aCk9nby8kMVJkCyfaEj0fmOnxXUCkZReTXXE+xAK9tgCGfAI5wKMMWk/r qhwRTdXw/7nH/an/XtX2+rs3e2KyozSURFFMnx9ymeGWa/wTPH1jgVCclyR1rJpJQgC1zW3H0 is4RIpgduTx5EeHqKP3tUGRIIeFTgheO1ZHXKYz7cguVHsPafsI9PRJpEIpvi0ktUPo+fX0mn 9fACs/Nf3WZrnnRZHNaowUyXNytNNGXOu0pimw7N9S0pnfpFQUDyqFDpARnzM28a0RdIDCUfd +Zg4XnvPl2cRfiGH+DkndPst2CG/w/cZGhuzn2DIspannSZNHiO4aKuvbhpBVI7ZBoOYeeH8d pzzgRnhvwcEKItZgGBYv9KlXOy9fuwnK8vFQxznxjI+GocFbzPkeWLeVXi3CIjTiQ2egDJYnz cJ7Enh6pF6vP7ZzKdZVcHu2vfO4Dn/NXjBAsniC/lqPPMt8qJnaOrqzWVk+5a1v5cQ+I9dIXU ALUag0+TTk2UJGFaHRbPdFnqHUbqXz2iTWowvaX6Y2J81Eq9V2+zQGZCrTaMlRY58VcQ833r9 VvVLG3PBiq/B/dsBX1TqX2yoB4mtmppkm3jNw6iyhitPq+Sl5uO+7b4NKrz7HXx4OFXeVcL3l 2kPnie6N8r8/SbCt0Tok6++RGghcRaUhF4LkaRWY4e+N5VTR0gltc+PrQBqyb7eIbgUHr1QGe /ZtukWU/JNfQm9OfEohx6QV720cTPDJJKqY7cI8lg57zH/u1U6szbYp1Farj7ZkjRDWyGG/2x 645N+2QUYLtf9hHhoITMoEBE6Ftc92scmedQDIBAvxlqy7NpH0gdrT5UsJRdXejV89GqKxVHP XzdNfC0DFT4OFS8GdBXI5r+NrO/yEugyV/z2/3/XR5oQUIShEGipYrpQrX0v1uS1m5tqjOosK bcR1MaxVx+/8ErhtxbyAAmHk3KRzLI3b/iTM9xSkRTwPCxge58Q7sN2BOIHJjNYMIMWnGs+zx +duZEALKgVGvuvgQlgowMURZoPQOwqmzvG+tD+h5JhXY+jxSQKZIjmqZ/++saq2G3+fcrbh5z s8hTdafn43XXUc= X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" This series reverts two patches which disabled scrolling acceleration in fbcon/fbdev. Those patches introduced a regression for fbdev-supported graphic cards because of the performance penalty by doing screen scrolling by software instead of using existing 2D hardware acceleration. The third patch introduces a new config option CONFIG_FRAMEBUFFER_CONSOLE_LEGACY_ACCELERATION, which -if enabled- switches fbcon to utilize the bitblt and fillrect hardware acceleration in the framebuffer console. If disabled, such acceleration will not be used, even if it is supported by the graphics hardware driver. This series is being discussed on linux-fbdev and dri-devel mailing lists. Updates in v3: - respin with fixes to build rotation code Updates in v4: - changed the Kconfig option and Kconfig help text Helge Deller (3): Revert "fbdev: Garbage collect fbdev scrolling acceleration, part 1 (from TODO list)" Revert "fbcon: Disable accelerated scrolling" fbcon: Add option to enable legacy hardware acceleration Documentation/gpu/todo.rst | 24 - drivers/video/console/Kconfig | 20 + drivers/video/fbdev/core/bitblit.c | 16 + drivers/video/fbdev/core/fbcon.c | 557 +++++++++++++++++++++++- drivers/video/fbdev/core/fbcon.h | 72 +++ drivers/video/fbdev/core/fbcon_ccw.c | 28 +- drivers/video/fbdev/core/fbcon_cw.c | 28 +- drivers/video/fbdev/core/fbcon_rotate.h | 9 + drivers/video/fbdev/core/fbcon_ud.c | 37 +- drivers/video/fbdev/core/tileblit.c | 16 + drivers/video/fbdev/skeletonfb.c | 12 +- include/linux/fb.h | 2 +- 12 files changed, 753 insertions(+), 68 deletions(-)