| Message ID | 20220317081830.1211400-1-geert@linux-m68k.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | drm: Fix monochrome conversion for sdd130x | expand |
Hello Geert, On 3/17/22 09:18, Geert Uytterhoeven wrote: > Hi all, > > This patch series contains fixes and improvements for the XRGB888 to > monochrome conversion in the DRM core, and for its users. > > This has been tested on an Adafruit FeatherWing 128x32 OLED, connected > to an OrangeCrab ECP5 FPGA board running a 64 MHz VexRiscv RISC-V > softcore, using a text console with 4x6, 7x14 and 8x8 fonts. > > Thanks! > > Geert Uytterhoeven (5): > drm/format-helper: Rename drm_fb_xrgb8888_to_mono_reversed() > drm/format-helper: Fix XRGB888 to monochrome conversion > drm/ssd130x: Fix rectangle updates > drm/ssd130x: Reduce temporary buffer sizes > drm/repaper: Reduce temporary buffer size in repaper_fb_dirty() > Thanks for re-spinning this series and again for fixing my bugs! I pushed patches 1-4 to drm-misc (drm-misc-next) but left patch 5 since would like to give Noralf the opportunity to review/test before pushing. By the way, you should probably request commit access to the drm-misc tree: https://drm.pages.freedesktop.org/maintainer-tools/commit-access.html
On Thu, Mar 17, 2022 at 12:39:57PM +0100, Javier Martinez Canillas wrote: > On 3/17/22 09:18, Geert Uytterhoeven wrote: > By the way, you should probably request commit access to the drm-misc tree: > > https://drm.pages.freedesktop.org/maintainer-tools/commit-access.html Does it really work? I tried and no one replied to request. Keeping silent is a bad service. If people don't want a person to have such access it should be well communicated.
On Fri, Mar 18, 2022 at 03:42:48PM +0200, Andy Shevchenko wrote: > On Thu, Mar 17, 2022 at 12:39:57PM +0100, Javier Martinez Canillas wrote: > > On 3/17/22 09:18, Geert Uytterhoeven wrote: > > > By the way, you should probably request commit access to the drm-misc tree: > > > > https://drm.pages.freedesktop.org/maintainer-tools/commit-access.html > > Does it really work? I tried and no one replied to request. > Keeping silent is a bad service. If people don't want a person > to have such access it should be well communicated. I don't see any issue on Gitlab to request commit access, so I'm not sure what you did exactly but it's not surprising you didn't get any answer. Maxime
On Fri, Mar 18, 2022 at 03:21:45PM +0100, Maxime Ripard wrote: > On Fri, Mar 18, 2022 at 03:42:48PM +0200, Andy Shevchenko wrote: > > On Thu, Mar 17, 2022 at 12:39:57PM +0100, Javier Martinez Canillas wrote: > > > On 3/17/22 09:18, Geert Uytterhoeven wrote: > > > > > By the way, you should probably request commit access to the drm-misc tree: > > > > > > https://drm.pages.freedesktop.org/maintainer-tools/commit-access.html > > > > Does it really work? I tried and no one replied to request. > > Keeping silent is a bad service. If people don't want a person > > to have such access it should be well communicated. > > I don't see any issue on Gitlab to request commit access, so I'm not > sure what you did exactly but it's not surprising you didn't get any > answer. https://gitlab.freedesktop.org/freedesktop/freedesktop/-/issues/311
On Fri, Mar 18, 2022 at 04:33:19PM +0200, Andy Shevchenko wrote: > On Fri, Mar 18, 2022 at 03:21:45PM +0100, Maxime Ripard wrote: > > On Fri, Mar 18, 2022 at 03:42:48PM +0200, Andy Shevchenko wrote: > > > On Thu, Mar 17, 2022 at 12:39:57PM +0100, Javier Martinez Canillas wrote: > > > > On 3/17/22 09:18, Geert Uytterhoeven wrote: > > > > > > > By the way, you should probably request commit access to the drm-misc tree: > > > > > > > > https://drm.pages.freedesktop.org/maintainer-tools/commit-access.html > > > > > > Does it really work? I tried and no one replied to request. > > > Keeping silent is a bad service. If people don't want a person > > > to have such access it should be well communicated. > > > > I don't see any issue on Gitlab to request commit access, so I'm not > > sure what you did exactly but it's not surprising you didn't get any > > answer. > > https://gitlab.freedesktop.org/freedesktop/freedesktop/-/issues/311 Indeed, I wasn't expecting it to be that old. I'm not sure why it fell through the cracks, sorry for that. That being said, the criteria for requesting drm-misc commit access are listed here: https://drm.pages.freedesktop.org/maintainer-tools/commit-access.html#drm-misc And looking at your commit history so far, I'm not sure you qualifies yet for the first criteria. All your patches to drivers/gpu/drm, while definitely useful, only seem to be conversions to helpers and general best practices changes, which could be classified as trivial. Maxime
On Fri, Apr 08, 2022 at 03:54:13PM +0200, Maxime Ripard wrote: > On Fri, Mar 18, 2022 at 04:33:19PM +0200, Andy Shevchenko wrote: > > On Fri, Mar 18, 2022 at 03:21:45PM +0100, Maxime Ripard wrote: > > > On Fri, Mar 18, 2022 at 03:42:48PM +0200, Andy Shevchenko wrote: > > > > On Thu, Mar 17, 2022 at 12:39:57PM +0100, Javier Martinez Canillas wrote: > > > > > On 3/17/22 09:18, Geert Uytterhoeven wrote: > > > > > > > > > By the way, you should probably request commit access to the drm-misc tree: > > > > > > > > > > https://drm.pages.freedesktop.org/maintainer-tools/commit-access.html > > > > > > > > Does it really work? I tried and no one replied to request. > > > > Keeping silent is a bad service. If people don't want a person > > > > to have such access it should be well communicated. > > > > > > I don't see any issue on Gitlab to request commit access, so I'm not > > > sure what you did exactly but it's not surprising you didn't get any > > > answer. > > > > https://gitlab.freedesktop.org/freedesktop/freedesktop/-/issues/311 > > Indeed, I wasn't expecting it to be that old. That's part of "non-working" process. > I'm not sure why it fell through the cracks, sorry for that. > > That being said, the criteria for requesting drm-misc commit access are > listed here: > https://drm.pages.freedesktop.org/maintainer-tools/commit-access.html#drm-misc > > And looking at your commit history so far, I'm not sure you qualifies > yet for the first criteria. All your patches to drivers/gpu/drm, while > definitely useful, only seem to be conversions to helpers and general > best practices changes, which could be classified as trivial. Can you, please, comment it there then and close the request?