mbox series

[v2,0/2] drm: bridge: adv7511: CEC support for ADV7535

Message ID 20220423120854.1503163-1-alvin@pqrs.dk (mailing list archive)
Headers show
Series drm: bridge: adv7511: CEC support for ADV7535 | expand

Message

Alvin Šipraga April 23, 2022, 12:08 p.m. UTC
From: Alvin Šipraga <alsi@bang-olufsen.dk>

Changes:

v1->v2:
  - add Robert's r-b
  - fix up 'case XXX...YYY+14' statements to read nicer in the 2nd patch


We have an ADV7535 which is nominally supported by this driver. These
two patches fix up the driver to get CEC working too.

The first adds the basic support by correcting some register offsets.

The second addresses an issue we saw with CEC RX on the ADV7535. It
hasn't been tested with the other chips (e.g. ADV7533), although it
should be compatible. I'm sending it against drm-misc-next because the
issue wasn't reported for other chips, and ADV7535 didn't have CEC
support before. But feel free to take it into -fixes instead.


Alvin Šipraga (2):
  drm: bridge: adv7511: enable CEC support for ADV7535
  drm: bridge: adv7511: use non-legacy mode for CEC RX

 drivers/gpu/drm/bridge/adv7511/adv7511.h     |  27 ++++-
 drivers/gpu/drm/bridge/adv7511/adv7511_cec.c | 116 +++++++++++++------
 drivers/gpu/drm/bridge/adv7511/adv7511_drv.c |  19 ++-
 3 files changed, 116 insertions(+), 46 deletions(-)

Comments

Robert Foss May 2, 2022, 2:39 p.m. UTC | #1
On Sat, 23 Apr 2022 at 14:09, Alvin Šipraga <alvin@pqrs.dk> wrote:
>
> From: Alvin Šipraga <alsi@bang-olufsen.dk>
>
> Changes:
>
> v1->v2:
>   - add Robert's r-b
>   - fix up 'case XXX...YYY+14' statements to read nicer in the 2nd patch
>
>
> We have an ADV7535 which is nominally supported by this driver. These
> two patches fix up the driver to get CEC working too.
>
> The first adds the basic support by correcting some register offsets.
>
> The second addresses an issue we saw with CEC RX on the ADV7535. It
> hasn't been tested with the other chips (e.g. ADV7533), although it
> should be compatible. I'm sending it against drm-misc-next because the
> issue wasn't reported for other chips, and ADV7535 didn't have CEC
> support before. But feel free to take it into -fixes instead.
>
>
> Alvin Šipraga (2):
>   drm: bridge: adv7511: enable CEC support for ADV7535
>   drm: bridge: adv7511: use non-legacy mode for CEC RX
>
>  drivers/gpu/drm/bridge/adv7511/adv7511.h     |  27 ++++-
>  drivers/gpu/drm/bridge/adv7511/adv7511_cec.c | 116 +++++++++++++------
>  drivers/gpu/drm/bridge/adv7511/adv7511_drv.c |  19 ++-
>  3 files changed, 116 insertions(+), 46 deletions(-)

Applied to drm-misc-next.