| Message ID | 20220427165550.3636686-1-John.C.Harrison@Intel.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Initial GuC firmware release for DG2 | expand |
John.C.Harrison@Intel.com kirjoitti 27.4.2022 klo 19.55: > From: John Harrison <John.C.Harrison@Intel.com> > > Add GuC firmware for DG2. > > Note that an older version of this patch exists in the CI topic > branch. Hence this set includes a revert of that patch before applying > the new version. When merging, the revert would simply be dropped and > the corresponding patch in the topic branch would also be dropped. > > Signed-off-by: John Harrison <John.C.Harrison@Intel.com> > > > John Harrison (2): > Revert "drm/i915/dg2: Define GuC firmware version for DG2" > drm/i915/dg2: Define GuC firmware version for DG2 > > drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > The firmware is not public yet, though? Shouldn't it have been sent upstream already? Same complaint applies to DMC.
On 4/27/2022 11:24, Timo Aaltonen wrote: > John.C.Harrison@Intel.com kirjoitti 27.4.2022 klo 19.55: >> From: John Harrison <John.C.Harrison@Intel.com> >> >> Add GuC firmware for DG2. >> >> Note that an older version of this patch exists in the CI topic >> branch. Hence this set includes a revert of that patch before applying >> the new version. When merging, the revert would simply be dropped and >> the corresponding patch in the topic branch would also be dropped. >> >> Signed-off-by: John Harrison <John.C.Harrison@Intel.com> >> >> >> John Harrison (2): >> Revert "drm/i915/dg2: Define GuC firmware version for DG2" >> drm/i915/dg2: Define GuC firmware version for DG2 >> >> drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> > > The firmware is not public yet, though? Shouldn't it have been sent > upstream already? Same complaint applies to DMC. > > Not sure about the DMC team, but for i915 we upload the firmware to an FDO repo so that the CI system can find it and run the pre-merge testing with it. However, we don't send the final pull request for the real linux firmware repo until we have merged the i915 patch to drm-gt-intel-next and it is definitely going upstream. Otherwise, we might end up pushing firmwares to the linux repo that never get used. John.
On Wed, Apr 27, 2022 at 03:14:16PM -0700, John Harrison wrote: >On 4/27/2022 11:24, Timo Aaltonen wrote: >>John.C.Harrison@Intel.com kirjoitti 27.4.2022 klo 19.55: >>>From: John Harrison <John.C.Harrison@Intel.com> >>> >>>Add GuC firmware for DG2. >>> >>>Note that an older version of this patch exists in the CI topic >>>branch. Hence this set includes a revert of that patch before applying >>>the new version. When merging, the revert would simply be dropped and >>>the corresponding patch in the topic branch would also be dropped. >>> >>>Signed-off-by: John Harrison <John.C.Harrison@Intel.com> >>> >>> >>>John Harrison (2): >>> Revert "drm/i915/dg2: Define GuC firmware version for DG2" >>> drm/i915/dg2: Define GuC firmware version for DG2 >>> >>> drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >> >>The firmware is not public yet, though? Shouldn't it have been sent >>upstream already? Same complaint applies to DMC. >> >> >Not sure about the DMC team, but for i915 we upload the firmware to an >FDO repo so that the CI system can find it and run the pre-merge >testing with it. However, we don't send the final pull request for the >real linux firmware repo until we have merged the i915 patch to >drm-gt-intel-next and it is definitely going upstream. Otherwise, we >might end up pushing firmwares to the linux repo that never get used. we don't want to risk sending a pull request to drm if the firmware is not in linux-firmware repo yet though, so we need to be careful with this workflow. We still have some weeks, which should be sufficient time if it's sent to linux-firmware asap. 2nd patch pushed to drm-intel-gt-next. 1st patch I removed from topic/core-for-CI. Thanks Lucas De Marchi > >John. >