From patchwork Thu May 5 11:31:23 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Javier Martinez Canillas X-Patchwork-Id: 12839412 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 07975C433F5 for ; Thu, 5 May 2022 11:31:41 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4E75110F639; Thu, 5 May 2022 11:31:41 +0000 (UTC) Received: from us-smtp-delivery-74.mimecast.com (us-smtp-delivery-74.mimecast.com [170.10.129.74]) by gabe.freedesktop.org (Postfix) with ESMTPS id 754F510F639 for ; Thu, 5 May 2022 11:31:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1651750299; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=bN3Uh2LhXlJZ1HGDsbuHnMTmS7+4/Zex2TjyKUB51Mw=; b=eEp9zm/k1tbWVvOEt6dv/ZFj/hq3GnIvWHBhmH/FPBI2N05nbtGV326yWUEKrAZSNhklkE nvLlXACG8OTRq9gumH+xhlLc1egkSXIHp1NybaXqDBQ3MlKIxi0DACcULkMCgnxcE79ntC 3A+cnGIaKXz6gXKaFrYxtmv9fLtZD6w= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-455-3ocdGEiANOK4zH8NFnS0rg-1; Thu, 05 May 2022 07:31:38 -0400 X-MC-Unique: 3ocdGEiANOK4zH8NFnS0rg-1 Received: by mail-wr1-f70.google.com with SMTP id u11-20020a056000038b00b0020c9ea8b64fso86357wrf.2 for ; Thu, 05 May 2022 04:31:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=bN3Uh2LhXlJZ1HGDsbuHnMTmS7+4/Zex2TjyKUB51Mw=; b=4EJnTZZRanvc9+SyfT9mWKR4veLn+1mrNvBoMbmM0lAbNN+dgl4oMGYJAWyli93Zi8 s3M2LYKOfxM+QoTOiU2tSp99y3y+KtTAPkkKvW9hogDqm6Z1ihdXeQ+YgISifG7Vfmmm Ba3odakJjqaEZ19sY3MdgYaUeuJCBC+uoEcHmk+1uDJAS0s9V4ox+TcBQOZ9TRGrttq3 pxGpsJzKpy2n0q5xwb9iwNrtpLhI0y7XKNDAyS82UcgK6NI4xW5olrBZo2mS//ynW8Ky fuepiWjN8wrsuITFnaN/ox2FpeHrmD5Bzxl+FConuXjFkPukHYVC2r0B/VdOw2G4jlZo GUtQ== X-Gm-Message-State: AOAM530mGvvrm/k59Uaf8O4Qh6jShE4/6VE5w+3+BzEYyu7nF5ZmwOX5 Sd8/OZWm0DwtoKugecGK/e4yOo9qDbtwmP9ukQBBBjHmvAYbrUhukhcc7WNrnwyBe3SzD1bEE7c Yde7XMEc2gzDEDr0xUsCAN4yR0tSH X-Received: by 2002:a05:600c:1e8a:b0:394:a8:234 with SMTP id be10-20020a05600c1e8a00b0039400a80234mr4310547wmb.117.1651750296622; Thu, 05 May 2022 04:31:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyYkJhU3npy2RP0EYd+TCS/YRsPqKFjNBTxwh4iOfYuxwgG9V/BfOG8Dx2RoPJjNmCfU8QlfQ== X-Received: by 2002:a05:600c:1e8a:b0:394:a8:234 with SMTP id be10-20020a05600c1e8a00b0039400a80234mr4310517wmb.117.1651750296280; Thu, 05 May 2022 04:31:36 -0700 (PDT) Received: from minerva.. ([90.167.94.135]) by smtp.gmail.com with ESMTPSA id k1-20020a5d5181000000b0020c5253d8f5sm995809wrv.65.2022.05.05.04.31.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 May 2022 04:31:35 -0700 (PDT) From: Javier Martinez Canillas To: linux-kernel@vger.kernel.org Subject: [PATCH v2 0/4] fbdev: Fix use-after-free caused by wrong fb_info cleanup in drivers Date: Thu, 5 May 2022 13:31:23 +0200 Message-Id: <20220505113128.264963-1-javierm@redhat.com> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=javierm@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, Helge Deller , Javier Martinez Canillas , dri-devel@lists.freedesktop.org, Hans de Goede , Peter Jones Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hello, This series contains patches suggested by Daniel Vetter to fix a use-after-free error in the fb_release() function, due a fb_info associated with a fbdev being freed too early while a user-space process still has the fbdev dev node opened. That is caused by a wrong management of the struct fb_info lifetime in drivers, but the fbdev core can also be made more resilient about it an leak This can easily be reproduced with the simplefb driver doing the following: $ cat < /dev/fb0 & $ echo simple-framebuffer.0 > /sys/bus/platform/drivers/simple-framebuffer/unbind $ kill %1 [ 257.490471] ------------[ cut here ]------------ ... [ 257.495125] refcount_t: underflow; use-after-free. [ 257.495222] WARNING: CPU: 0 PID: 975 at lib/refcount.c:28 refcount_warn_saturate+0xf4/0x144 ... [ 257.637482] pstate: 80400005 (Nzcv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--) [ 257.644441] pc : refcount_warn_saturate+0xf4/0x144 [ 257.649226] lr : refcount_warn_saturate+0xf4/0x144 [ 257.654009] sp : ffff80000a06bbf0 [ 257.657315] x29: ffff80000a06bbf0 x28: 000000000000000a x27: 000000000000000a [ 257.664448] x26: 0000000000000000 x25: ffff470b88c6a180 x24: 000000000000000a [ 257.671581] x23: ffff470b81706480 x22: ffff470b808c2160 x21: ffff470b8922ba20 [ 257.678713] x20: ffff470b891f5810 x19: ffff470b891f5800 x18: ffffffffffffffff [ 257.685846] x17: 3a725f7463656a62 x16: ffffbb18c6465fd4 x15: 0720072007200720 [ 257.692978] x14: 0720072d072d072d x13: 0a2e656572662d72 x12: 657466612d657375 [ 257.700110] x11: 203b776f6c667265 x10: 646e75203a745f74 x9 : ffffbb18c58f6c90 [ 257.707242] x8 : 75203b776f6c6672 x7 : 65646e75203a745f x6 : 0000000000000001 [ 257.714373] x5 : ffff470bff8ec418 x4 : 0000000000000000 x3 : 0000000000000027 [ 257.721506] x2 : 0000000000000000 x1 : 0000000000000027 x0 : 0000000000000026 [ 257.728638] Call trace: [ 257.731075] refcount_warn_saturate+0xf4/0x144 [ 257.735513] put_fb_info+0x70/0x7c [ 257.738916] fb_release+0x60/0x74 [ 257.742225] __fput+0x88/0x240 [ 257.745276] ____fput+0x1c/0x30 [ 257.748410] task_work_run+0xc4/0x21c [ 257.752066] do_exit+0x170/0x370 [ 257.755288] do_group_exit+0x40/0xb4 [ 257.758858] get_signal+0x8e0/0x90c [ 257.762339] do_signal+0x1a0/0x280 [ 257.765733] do_notify_resume+0xc8/0x390 [ 257.769650] el0_da+0xe8/0xf0 [ 257.772613] el0t_64_sync_handler+0xe8/0x130 [ 257.776877] el0t_64_sync+0x190/0x194 [ 257.780534] ---[ end trace 0000000000000000 ]--- Patch #1 adds a WARN_ON() to framebuffer_release() to prevent the use-after-free to happen. Patch #2, #3 and #4 fix the simplefb, efifb and vesafb drivers respectively, to free the resources at the correct place. Changes in v2: - Also do the change for vesafb (Thomas Zimmermann). Daniel Vetter (1): fbdev: Prevent possible use-after-free in fb_release() Javier Martinez Canillas (3): fbdev: simplefb: Cleanup fb_info in .fb_destroy rather than .remove fbdev: efifb: Cleanup fb_info in .fb_destroy rather than .remove fbdev: vesafb: Cleanup fb_info in .fb_destroy rather than .remove drivers/video/fbdev/core/fbsysfs.c | 4 ++++ drivers/video/fbdev/efifb.c | 9 ++++++++- drivers/video/fbdev/simplefb.c | 8 +++++++- drivers/video/fbdev/vesafb.c | 14 +++++++++++--- 4 files changed, 30 insertions(+), 5 deletions(-)