mbox series

[0/7] Add HWMON support

Message ID 20220926175211.3473371-1-badal.nilawar@intel.com (mailing list archive)
Headers show
Series Add HWMON support | expand

Message

Nilawar, Badal Sept. 26, 2022, 5:52 p.m. UTC 
This series adds the HWMON support for DGFX

Test-with: 20220919144408.251981-1-riana.tauro@intel.com

v2:
  - Reorganized series. Created first patch as infrastructure patch
    followed by feature patches. (Ashutosh)
  - Fixed review comments (Jani)
  - Fixed review comments (Ashutosh)

v3:
  - Fixed review comments from Guenter
  - Exposed energy inferface as standard hwmon interface (Ashutosh)
  - For power interface added entries for critical power and maintained
    standard interface for all the entries except 
    power1_max_interval
  - Extended support for XEHPSDV (Ashutosh)

v4:
  - Fixed review comment from Guenter
  - Cleaned up unused code

v5:
  - Fixed review comments (Jani)

v6: 
  - Fixed review comments (Ashutosh)
  - Updated date and kernel version in documentation

v7:
  - Fixed review comments (Anshuman)
  - KernelVersion: 6.2, Date: February 2023 in doc (Tvrtko) 

v8: s/hwmon_device_register_with_info/
      devm_hwmon_device_register_with_info/ (Ashutosh)

Ashutosh Dixit (2):
  drm/i915/hwmon: Expose card reactive critical power
  drm/i915/hwmon: Expose power1_max_interval

Dale B Stimson (4):
  drm/i915/hwmon: Add HWMON infrastructure
  drm/i915/hwmon: Power PL1 limit and TDP setting
  drm/i915/hwmon: Show device level energy usage
  drm/i915/hwmon: Extend power/energy for XEHPSDV

Riana Tauro (1):
  drm/i915/hwmon: Add HWMON current voltage support

 .../ABI/testing/sysfs-driver-intel-i915-hwmon |  75 ++
 drivers/gpu/drm/i915/Makefile                 |   3 +
 drivers/gpu/drm/i915/gt/intel_gt_regs.h       |   8 +
 drivers/gpu/drm/i915/i915_driver.c            |   5 +
 drivers/gpu/drm/i915/i915_drv.h               |   2 +
 drivers/gpu/drm/i915/i915_hwmon.c             | 736 ++++++++++++++++++
 drivers/gpu/drm/i915/i915_hwmon.h             |  20 +
 drivers/gpu/drm/i915/i915_reg.h               |   6 +
 drivers/gpu/drm/i915/intel_mchbar_regs.h      |  21 +
 9 files changed, 876 insertions(+)
 create mode 100644 Documentation/ABI/testing/sysfs-driver-intel-i915-hwmon
 create mode 100644 drivers/gpu/drm/i915/i915_hwmon.c
 create mode 100644 drivers/gpu/drm/i915/i915_hwmon.h

Comments

Guenter Roeck Sept. 26, 2022, 9:09 p.m. UTC | #1 
On 9/26/22 10:52, Badal Nilawar wrote:
> This series adds the HWMON support for DGFX
> 
> Test-with: 20220919144408.251981-1-riana.tauro@intel.com
> 
> v2:
>    - Reorganized series. Created first patch as infrastructure patch
>      followed by feature patches. (Ashutosh)
>    - Fixed review comments (Jani)
>    - Fixed review comments (Ashutosh)
> 
> v3:
>    - Fixed review comments from Guenter
>    - Exposed energy inferface as standard hwmon interface (Ashutosh)
>    - For power interface added entries for critical power and maintained
>      standard interface for all the entries except
>      power1_max_interval
>    - Extended support for XEHPSDV (Ashutosh)
> 
> v4:
>    - Fixed review comment from Guenter
>    - Cleaned up unused code
> 
> v5:
>    - Fixed review comments (Jani)
> 
> v6:
>    - Fixed review comments (Ashutosh)
>    - Updated date and kernel version in documentation
> 
> v7:
>    - Fixed review comments (Anshuman)
>    - KernelVersion: 6.2, Date: February 2023 in doc (Tvrtko)
> 
> v8: s/hwmon_device_register_with_info/
>        devm_hwmon_device_register_with_info/ (Ashutosh)
> 

Is there some reason for not actually versioning this patch series ?
Just wondering.

Thanks,
Guenter

> Ashutosh Dixit (2):
>    drm/i915/hwmon: Expose card reactive critical power
>    drm/i915/hwmon: Expose power1_max_interval
> 
> Dale B Stimson (4):
>    drm/i915/hwmon: Add HWMON infrastructure
>    drm/i915/hwmon: Power PL1 limit and TDP setting
>    drm/i915/hwmon: Show device level energy usage
>    drm/i915/hwmon: Extend power/energy for XEHPSDV
> 
> Riana Tauro (1):
>    drm/i915/hwmon: Add HWMON current voltage support
> 
>   .../ABI/testing/sysfs-driver-intel-i915-hwmon |  75 ++
>   drivers/gpu/drm/i915/Makefile                 |   3 +
>   drivers/gpu/drm/i915/gt/intel_gt_regs.h       |   8 +
>   drivers/gpu/drm/i915/i915_driver.c            |   5 +
>   drivers/gpu/drm/i915/i915_drv.h               |   2 +
>   drivers/gpu/drm/i915/i915_hwmon.c             | 736 ++++++++++++++++++
>   drivers/gpu/drm/i915/i915_hwmon.h             |  20 +
>   drivers/gpu/drm/i915/i915_reg.h               |   6 +
>   drivers/gpu/drm/i915/intel_mchbar_regs.h      |  21 +
>   9 files changed, 876 insertions(+)
>   create mode 100644 Documentation/ABI/testing/sysfs-driver-intel-i915-hwmon
>   create mode 100644 drivers/gpu/drm/i915/i915_hwmon.c
>   create mode 100644 drivers/gpu/drm/i915/i915_hwmon.h
>
Nilawar, Badal Sept. 27, 2022, 4:03 a.m. UTC | #2 
On 27-09-2022 02:39, Guenter Roeck wrote:
> On 9/26/22 10:52, Badal Nilawar wrote:
>> This series adds the HWMON support for DGFX
>>
>> Test-with: 20220919144408.251981-1-riana.tauro@intel.com
>>
>> v2:
>>    - Reorganized series. Created first patch as infrastructure patch
>>      followed by feature patches. (Ashutosh)
>>    - Fixed review comments (Jani)
>>    - Fixed review comments (Ashutosh)
>>
>> v3:
>>    - Fixed review comments from Guenter
>>    - Exposed energy inferface as standard hwmon interface (Ashutosh)
>>    - For power interface added entries for critical power and maintained
>>      standard interface for all the entries except
>>      power1_max_interval
>>    - Extended support for XEHPSDV (Ashutosh)
>>
>> v4:
>>    - Fixed review comment from Guenter
>>    - Cleaned up unused code
>>
>> v5:
>>    - Fixed review comments (Jani)
>>
>> v6:
>>    - Fixed review comments (Ashutosh)
>>    - Updated date and kernel version in documentation
>>
>> v7:
>>    - Fixed review comments (Anshuman)
>>    - KernelVersion: 6.2, Date: February 2023 in doc (Tvrtko)
>>
>> v8: s/hwmon_device_register_with_info/
>>        devm_hwmon_device_register_with_info/ (Ashutosh)
>>
> 
> Is there some reason for not actually versioning this patch series ?
> Just wondering.
Sorry I miss typed cover letter title. I will correct the title as 
"drm/i915: Add HWMON support" and resend the series to maintain versioning.

Please ignore this series.

Regards,
Badal
> 
> Thanks,
> Guenter
> 
>> Ashutosh Dixit (2):
>>    drm/i915/hwmon: Expose card reactive critical power
>>    drm/i915/hwmon: Expose power1_max_interval
>>
>> Dale B Stimson (4):
>>    drm/i915/hwmon: Add HWMON infrastructure
>>    drm/i915/hwmon: Power PL1 limit and TDP setting
>>    drm/i915/hwmon: Show device level energy usage
>>    drm/i915/hwmon: Extend power/energy for XEHPSDV
>>
>> Riana Tauro (1):
>>    drm/i915/hwmon: Add HWMON current voltage support
>>
>>   .../ABI/testing/sysfs-driver-intel-i915-hwmon |  75 ++
>>   drivers/gpu/drm/i915/Makefile                 |   3 +
>>   drivers/gpu/drm/i915/gt/intel_gt_regs.h       |   8 +
>>   drivers/gpu/drm/i915/i915_driver.c            |   5 +
>>   drivers/gpu/drm/i915/i915_drv.h               |   2 +
>>   drivers/gpu/drm/i915/i915_hwmon.c             | 736 ++++++++++++++++++
>>   drivers/gpu/drm/i915/i915_hwmon.h             |  20 +
>>   drivers/gpu/drm/i915/i915_reg.h               |   6 +
>>   drivers/gpu/drm/i915/intel_mchbar_regs.h      |  21 +
>>   9 files changed, 876 insertions(+)
>>   create mode 100644 
>> Documentation/ABI/testing/sysfs-driver-intel-i915-hwmon
>>   create mode 100644 drivers/gpu/drm/i915/i915_hwmon.c
>>   create mode 100644 drivers/gpu/drm/i915/i915_hwmon.h
>>
>