| Message ID | 20221026155934.125294-1-dakr@redhat.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | drm/arm/malidp: use drm managed resources | expand |
On Wed, Oct 26, 2022 at 05:59:29PM +0200, Danilo Krummrich wrote: > Hi, Hi Danilo, Sorry for the additional delay in reviewing and testing this series. I've now managed to get enough of both to be happy with the series. For the whole series: Reviewed-by: Liviu Dudau <liviu.dudau@arm.com> I will push the series today to drm-misc-next. Best regards, Liviu > > This patch series converts the driver to use drm managed resources to prevent > potential use-after-free issues on driver unbind/rebind and to get rid of the > usage of deprecated APIs. > > Changes in v2: > - While protecting critical sections with drm_dev_{enter,exit} I forgot to > handle alternate return paths within the read-side critical sections, hence > fix them. > - Add a patch to remove explicit calls to drm_mode_config_cleanup() and switch > to drmm_mode_config_init() explicitly. > > Changes in v3: > - Remove patches to protect platform device bound resources with > drm_dev_{enter,exit}, since this would leave the hardware enabled when > regularly unloading the driver e.g. via rmmod. > Instead do this in a later series, once we got drm_dev_unplug() in place > to deal with a regular driver shutdown. > > Danilo Krummrich (5): > drm/arm/malidp: use drmm_* to allocate driver structures > drm/arm/malidp: replace drm->dev_private with drm_to_malidp() > drm/arm/malidp: crtc: use drmm_crtc_init_with_planes() > drm/arm/malidp: plane: use drm managed resources > drm/arm/malidp: remove calls to drm_mode_config_cleanup() > > drivers/gpu/drm/arm/malidp_crtc.c | 7 ++- > drivers/gpu/drm/arm/malidp_drv.c | 69 +++++++++++------------------ > drivers/gpu/drm/arm/malidp_drv.h | 2 + > drivers/gpu/drm/arm/malidp_hw.c | 10 ++--- > drivers/gpu/drm/arm/malidp_mw.c | 6 +-- > drivers/gpu/drm/arm/malidp_planes.c | 32 ++++--------- > 6 files changed, 48 insertions(+), 78 deletions(-) > > > base-commit: e1e7bc481d49c3e3ada11029ce0d9b85a0a539d7 > -- > 2.37.3 >
Hi Liviu, hi Daniel, Thanks for submitting the patch series. Unfortunately, I wasn't able to finish the work to make drm_dev_unplug() deal properly with non-hotunplug cases before my vacation, since I was working on another series. I'll finalize and submit it once I'm back in two weeks. - Danilo
Hi, This patch series converts the driver to use drm managed resources to prevent potential use-after-free issues on driver unbind/rebind and to get rid of the usage of deprecated APIs. Changes in v2: - While protecting critical sections with drm_dev_{enter,exit} I forgot to handle alternate return paths within the read-side critical sections, hence fix them. - Add a patch to remove explicit calls to drm_mode_config_cleanup() and switch to drmm_mode_config_init() explicitly. Changes in v3: - Remove patches to protect platform device bound resources with drm_dev_{enter,exit}, since this would leave the hardware enabled when regularly unloading the driver e.g. via rmmod. Instead do this in a later series, once we got drm_dev_unplug() in place to deal with a regular driver shutdown. Danilo Krummrich (5): drm/arm/malidp: use drmm_* to allocate driver structures drm/arm/malidp: replace drm->dev_private with drm_to_malidp() drm/arm/malidp: crtc: use drmm_crtc_init_with_planes() drm/arm/malidp: plane: use drm managed resources drm/arm/malidp: remove calls to drm_mode_config_cleanup() drivers/gpu/drm/arm/malidp_crtc.c | 7 ++- drivers/gpu/drm/arm/malidp_drv.c | 69 +++++++++++------------------ drivers/gpu/drm/arm/malidp_drv.h | 2 + drivers/gpu/drm/arm/malidp_hw.c | 10 ++--- drivers/gpu/drm/arm/malidp_mw.c | 6 +-- drivers/gpu/drm/arm/malidp_planes.c | 32 ++++--------- 6 files changed, 48 insertions(+), 78 deletions(-) base-commit: e1e7bc481d49c3e3ada11029ce0d9b85a0a539d7