From patchwork Fri Nov 18 01:58:53 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Harrison X-Patchwork-Id: 13047636 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BADD6C4332F for ; Fri, 18 Nov 2022 01:59:32 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D660E10E6D7; Fri, 18 Nov 2022 01:59:18 +0000 (UTC) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1012D10E6D7; Fri, 18 Nov 2022 01:59:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1668736755; x=1700272755; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=ChZ2kpyYxQNwBlrGQM/5l8potdmZPG9r088A3AOdrh8=; b=XrPwJYrr1wdUspee6vLvirr3BcBEqC5zHrPyJBH2hYWIZDMZMANv4CFO m2hhIzOT28XkkN/iqchTgOZxlVd5JmkyKidTLfSEg1cGi7de4Gbum8rxX ARGXFZpT8NDI8/RDCN9+gVfsjjkemMDdNwqzvi1bFGSnYT06vwoHiGS99 J8a8RfBZc4z0uYsaeJFO21+QgYf4B8jZC3cCoGASUiUzw6HMHMhtRCKXj 9BYFURn1nIm/nuyOXgPv5qKGLRf5AOW7gsNHndS1fqvT1e0LlONTZT59V zlq9lz7ZiOuLeSJRsIe/TrDzvAZOiO0xvMfV3B+MYwzu34qRWUPn8ERRR Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10534"; a="300565825" X-IronPort-AV: E=Sophos;i="5.96,172,1665471600"; d="scan'208";a="300565825" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Nov 2022 17:59:13 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10534"; a="703563410" X-IronPort-AV: E=Sophos;i="5.96,172,1665471600"; d="scan'208";a="703563410" Received: from relo-linux-5.jf.intel.com ([10.165.21.143]) by fmsmga008.fm.intel.com with ESMTP; 17 Nov 2022 17:59:13 -0800 From: John.C.Harrison@Intel.com To: Intel-GFX@Lists.FreeDesktop.Org Subject: [PATCH v2 0/5] Add module oriented dmesg output Date: Thu, 17 Nov 2022 17:58:53 -0800 Message-Id: <20221118015858.2548106-1-John.C.Harrison@Intel.com> X-Mailer: git-send-email 2.37.3 MIME-Version: 1.0 Organization: Intel Corporation (UK) Ltd. - Co. Reg. #1134945 - Pipers Way, Swindon SN3 1RJ X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: John Harrison , DRI-Devel@Lists.FreeDesktop.Org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" From: John Harrison When trying to analyse bug reports from CI, customers, etc. it can be difficult to work out exactly what is happening on which GT in a multi-GT system. So add GT oriented debug/error message wrappers. If used instead of the drm_ equivalents, you get the same output but with a GT# prefix on it. It was also requested to extend this further to submodules in order to factor out the repeated structure accessing constructs and common string prefixes. So, add versions for GuC, HuC and GuC CTB as well. This patch set updates all the gt/uc files to use the new helpers as a first step. The intention would be to convert all output messages that have access to a GT structure. v2: Go back to using lower case names, add more wrapper sets (combined review feedback). Also, wrap up probe injection and WARN entries. Signed-off-by: John Harrison John Harrison (5): drm/i915/gt: Start adding module oriented dmesg output drm/i915/huc: Add HuC specific debug print wrappers drm/i915/guc: Add GuC specific debug print wrappers drm/i915/guc: Add GuC CT specific debug print wrappers drm/i915/uc: Update the gt/uc code to use gt_err and friends drivers/gpu/drm/i915/gt/intel_gt.c | 96 ++++---- drivers/gpu/drm/i915/gt/intel_gt.h | 35 +++ drivers/gpu/drm/i915/gt/uc/intel_guc.c | 32 +-- drivers/gpu/drm/i915/gt/uc/intel_guc.h | 35 +++ drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c | 8 +- .../gpu/drm/i915/gt/uc/intel_guc_capture.c | 48 ++-- drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c | 222 +++++++++--------- drivers/gpu/drm/i915/gt/uc/intel_guc_fw.c | 19 +- drivers/gpu/drm/i915/gt/uc/intel_guc_log.c | 37 ++- drivers/gpu/drm/i915/gt/uc/intel_guc_rc.c | 7 +- drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c | 55 ++--- .../gpu/drm/i915/gt/uc/intel_guc_submission.c | 62 +++-- drivers/gpu/drm/i915/gt/uc/intel_huc.c | 31 +-- drivers/gpu/drm/i915/gt/uc/intel_huc.h | 23 ++ drivers/gpu/drm/i915/gt/uc/intel_uc.c | 108 ++++----- drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c | 98 ++++---- drivers/gpu/drm/i915/gt/uc/selftest_guc.c | 34 +-- .../drm/i915/gt/uc/selftest_guc_hangcheck.c | 22 +- .../drm/i915/gt/uc/selftest_guc_multi_lrc.c | 10 +- 19 files changed, 507 insertions(+), 475 deletions(-)