| Message ID | 20221221231943.1961117-1-marijn.suijten@somainline.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | drm/msm: DSC Electric Boogaloo for sm8[12]50 | expand |
On Thu, Dec 22, 2022 at 12:19:35AM +0100, Marijn Suijten wrote: > This preliminary Display Stream Compression support package for > (initially tested on) sm8[12]50 is based on comparing DSC behaviour > between downstream and mainline. Some new callbacks are added (for > binding blocks on active CTLs), logic bugs are corrected, zeroed struct > members are now assigned proper values, and RM allocation and hw block > retrieval now hand out (or not) DSC blocks without causing null-pointer > dereferences. > > Unfortunately it is not yet enough to get rid of completely corrupted > display output on the boards I tested here: > - Sony Xperia 1 (sm8150), 1644x3840 or 1096x2560 pixels; > - Sony Xperia 5II (sm8250), 1080x2520, at 60 or 120Hz; > - (can include more Xperia boards if desired) > > Both devices use the DUALPIPE_DSCMERGE topology downstream: dual LM, PP > and DSC, but only a single INTF/encoder/DSI-link. > > Hopefully this spawns some community/upstream interest to help rootcause > our corruption issues (after we open a drm/msm report on GitLab for more > appropriate tracking). > > The Sony Xperia XZ3 (sdm845) was fully tested and validated with this > series to not cause any regressions (and one of the math fixes now > allows us to change slice_count in the panel driver, which would corrupt > previously). > > Changes since v1: > > - Split patch 6 into two separately backportable Fixes: patches; > - Additionally remove num_enc from msm_display_topology in favour of > num_dsc; > - Reorder patches to have all Fixes: at the beginning for easier > picking; > - Fix existing multiline comment while editing it anyway; > - Add missing Signed-off-by to patch 5. Please note that Electric Boogaloo/Boogaloo Boys has been appropriated by US alt-right groups, and so is really not a great thing to put into the cover letter for your patch series. For the next round, please use a meme that isn't tarnished like this. Thanks, Daniel > > v1: https://lore.kernel.org/linux-arm-msm/20221213232207.113607-1-marijn.suijten@somainline.org/T/#u > > Marijn Suijten (8): > drm/msm/dpu: Wire up DSC mask for active CTL configuration > drm/msm/dsi: Use DSC slice(s) packet size to compute word count > drm/msm/dsi: Flip greater-than check for slice_count and > slice_per_intf > drm/msm/dpu: Disallow unallocated resources to be returned > drm/msm/dpu: Reject topologies for which no DSC blocks are available > drm/msm/dpu: Remove num_enc from topology struct in favour of num_dsc > drm/msm/dpu: Implement DSC binding to PP block for CTL V1 > drm/msm/dpu: Add DSC configuration for SM8150 and SM8250 > > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 12 +++++---- > .../drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 1 + > .../drm/msm/disp/dpu1/dpu_encoder_phys_vid.c | 1 + > .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 23 +++++++++++----- > .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 9 +++++++ > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.c | 27 +++++++++++++++++++ > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.h | 4 +++ > drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 14 ++++++++-- > drivers/gpu/drm/msm/dsi/dsi_host.c | 7 ++--- > drivers/gpu/drm/msm/msm_drv.h | 2 -- > 10 files changed, 82 insertions(+), 18 deletions(-) > > -- > 2.39.0 >
On 2023-01-05 15:49:58, Daniel Vetter wrote: > On Thu, Dec 22, 2022 at 12:19:35AM +0100, Marijn Suijten wrote: > > [..] > > Please note that Electric Boogaloo/Boogaloo Boys has been appropriated by > US alt-right groups, and so is really not a great thing to put into the > cover letter for your patch series. For the next round, please use a meme > that isn't tarnished like this. Apologies for that, I wasn't aware of this abuse as a non-US citizen and hope this series is not offending anyone. As far as I recall this series was set to be applied for 6.3 yet Dmitry seems to have just posted some additional comments. May have been confusion on my end. Hence we do now need another cheeky title, conveying that we're already on the second round of fixes for DSC and it is still not working on major SoCs/boards. - Marijn
On Thu, 22 Dec 2022 00:19:35 +0100, Marijn Suijten wrote: > This preliminary Display Stream Compression support package for > (initially tested on) sm8[12]50 is based on comparing DSC behaviour > between downstream and mainline. Some new callbacks are added (for > binding blocks on active CTLs), logic bugs are corrected, zeroed struct > members are now assigned proper values, and RM allocation and hw block > retrieval now hand out (or not) DSC blocks without causing null-pointer > dereferences. > > [...] Applied, thanks! [1/8] drm/msm/dpu: Wire up DSC mask for active CTL configuration https://gitlab.freedesktop.org/lumag/msm/-/commit/c2d2c62da1fc [2/8] drm/msm/dsi: Use DSC slice(s) packet size to compute word count https://gitlab.freedesktop.org/lumag/msm/-/commit/bbd1bccdcf4e [3/8] drm/msm/dsi: Flip greater-than check for slice_count and slice_per_intf https://gitlab.freedesktop.org/lumag/msm/-/commit/85b5a40991dd [5/8] drm/msm/dpu: Reject topologies for which no DSC blocks are available https://gitlab.freedesktop.org/lumag/msm/-/commit/f52b965c9434 [6/8] drm/msm/dpu: Remove num_enc from topology struct in favour of num_dsc https://gitlab.freedesktop.org/lumag/msm/-/commit/9ce765395f41 [7/8] drm/msm/dpu: Implement DSC binding to PP block for CTL V1 https://gitlab.freedesktop.org/lumag/msm/-/commit/086116ae1410 [8/8] drm/msm/dpu: Add DSC configuration for SM8150 and SM8250 https://gitlab.freedesktop.org/lumag/msm/-/commit/8cc4c9de15f4 Best regards,
This preliminary Display Stream Compression support package for (initially tested on) sm8[12]50 is based on comparing DSC behaviour between downstream and mainline. Some new callbacks are added (for binding blocks on active CTLs), logic bugs are corrected, zeroed struct members are now assigned proper values, and RM allocation and hw block retrieval now hand out (or not) DSC blocks without causing null-pointer dereferences. Unfortunately it is not yet enough to get rid of completely corrupted display output on the boards I tested here: - Sony Xperia 1 (sm8150), 1644x3840 or 1096x2560 pixels; - Sony Xperia 5II (sm8250), 1080x2520, at 60 or 120Hz; - (can include more Xperia boards if desired) Both devices use the DUALPIPE_DSCMERGE topology downstream: dual LM, PP and DSC, but only a single INTF/encoder/DSI-link. Hopefully this spawns some community/upstream interest to help rootcause our corruption issues (after we open a drm/msm report on GitLab for more appropriate tracking). The Sony Xperia XZ3 (sdm845) was fully tested and validated with this series to not cause any regressions (and one of the math fixes now allows us to change slice_count in the panel driver, which would corrupt previously). Changes since v1: - Split patch 6 into two separately backportable Fixes: patches; - Additionally remove num_enc from msm_display_topology in favour of num_dsc; - Reorder patches to have all Fixes: at the beginning for easier picking; - Fix existing multiline comment while editing it anyway; - Add missing Signed-off-by to patch 5. v1: https://lore.kernel.org/linux-arm-msm/20221213232207.113607-1-marijn.suijten@somainline.org/T/#u Marijn Suijten (8): drm/msm/dpu: Wire up DSC mask for active CTL configuration drm/msm/dsi: Use DSC slice(s) packet size to compute word count drm/msm/dsi: Flip greater-than check for slice_count and slice_per_intf drm/msm/dpu: Disallow unallocated resources to be returned drm/msm/dpu: Reject topologies for which no DSC blocks are available drm/msm/dpu: Remove num_enc from topology struct in favour of num_dsc drm/msm/dpu: Implement DSC binding to PP block for CTL V1 drm/msm/dpu: Add DSC configuration for SM8150 and SM8250 drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 12 +++++---- .../drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 1 + .../drm/msm/disp/dpu1/dpu_encoder_phys_vid.c | 1 + .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 23 +++++++++++----- .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 9 +++++++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.c | 27 +++++++++++++++++++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.h | 4 +++ drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 14 ++++++++-- drivers/gpu/drm/msm/dsi/dsi_host.c | 7 ++--- drivers/gpu/drm/msm/msm_drv.h | 2 -- 10 files changed, 82 insertions(+), 18 deletions(-) -- 2.39.0