[RFC,v3,0/3] drm/mipi-dsi: 16-bit Brightness Endianness Fix

Message

Richard Acayan Jan. 16, 2023, 10:49 p.m. UTC

Changes since v2 ([e-mail]):
 - patch vtdr6130 to use _large (3/3)
 - remove Change-Id again (1/3)
 - change patch subject (1-2/3)
 - correct function name in patch description (2/3)
 - add Tested-by tags (1-2/3)

Changes since v1 ([e-mail]):
 - move 16-bit brightness handling to new functions and revert API
   change (1/2)
 - remove Change-Id in compliance with checkpatch.pl (1/2)
 - separate panel driver changes (2/2)

This series adds proper support for 16-bit MIPI DSI brightness and
cleans up existing panel drivers with 16-bit brightness.

Both setting and getting works on an external S6E3FA7
(max_brightness = 1023) panel driver with the first patch.

Even though this originally fixed both 8-bit and 16-bit brightness, the
8-bit fix is omitted for now because it affects ~13 panels that would
need to be tested:

    panel-asus-z00t-tm5p5-n35596.c
    panel-boe-bf060y8m-aj0.c
    panel-dsi-cm.c
    panel-ebbg-ft8719.c
    panel-jdi-fhd-r63452.c
    panel-jdi-lt070me05000.c
    panel-novatek-nt35510.c
    panel-novatek-nt35560.c
    panel-orisetech-otm8009a.c
    panel-raydium-rm67191.c
    panel-samsung-s6e63j0x03.c
    panel-sony-acx565akm.c
    panel-sony-tulip-truly-nt35521.c

Daniel Mentz (1):
  drm/mipi-dsi: Fix byte order of 16-bit DCS set/get brightness

Richard Acayan (2):
  drm/panel: sofef00: Use 16-bit brightness function
  drm/panel: vtdr6130: Use 16-bit brightness function

 drivers/gpu/drm/drm_mipi_dsi.c                | 52 +++++++++++++++++++
 drivers/gpu/drm/panel/panel-samsung-sofef00.c |  9 +---
 .../gpu/drm/panel/panel-visionox-vtdr6130.c   |  5 +-
 include/drm/drm_mipi_dsi.h                    |  4 ++
 4 files changed, 59 insertions(+), 11 deletions(-)

Comments

Sam Ravnborg Jan. 19, 2023, 7:14 a.m. UTC | #1

Hi Richard.
On Mon, Jan 16, 2023 at 05:49:06PM -0500, Richard Acayan wrote:
> Changes since v2 ([e-mail]):
>  - patch vtdr6130 to use _large (3/3)
>  - remove Change-Id again (1/3)
>  - change patch subject (1-2/3)
>  - correct function name in patch description (2/3)
>  - add Tested-by tags (1-2/3)
> 
> Changes since v1 ([e-mail]):
>  - move 16-bit brightness handling to new functions and revert API
>    change (1/2)
>  - remove Change-Id in compliance with checkpatch.pl (1/2)
>  - separate panel driver changes (2/2)
> 
> This series adds proper support for 16-bit MIPI DSI brightness and
> cleans up existing panel drivers with 16-bit brightness.

The series is:
Reviewed-by: Sam Ravnborg <[e-mail]>

Neil - I hope you can land this in drm-misc.

	Sam

Neil Armstrong Jan. 19, 2023, 7:24 a.m. UTC | #2

Hi,

On Mon, 16 Jan 2023 17:49:06 -0500, Richard Acayan wrote:
> Changes since v2 ([e-mail]):
>  - patch vtdr6130 to use _large (3/3)
>  - remove Change-Id again (1/3)
>  - change patch subject (1-2/3)
>  - correct function name in patch description (2/3)
>  - add Tested-by tags (1-2/3)
> 
> [...]

Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-next)

[1/3] drm/mipi-dsi: Fix byte order of 16-bit DCS set/get brightness
      https://cgit.freedesktop.org/drm/drm-misc/commit/?id=c9d27c6be518b4ef2966d9564654ef99292ea1b3
[2/3] drm/panel: sofef00: Use 16-bit brightness function
      https://cgit.freedesktop.org/drm/drm-misc/commit/?id=fd40749a4f62a03d0aebe6eb446ea84a9901795a
[3/3] drm/panel: vtdr6130: Use 16-bit brightness function
      https://cgit.freedesktop.org/drm/drm-misc/commit/?id=9402cde9347eca050e14ea9e47270e84a6899162

Neil Armstrong Jan. 19, 2023, 7:24 a.m. UTC | #3

On 19/01/2023 08:14, Sam Ravnborg wrote:
> Hi Richard.
> On Mon, Jan 16, 2023 at 05:49:06PM -0500, Richard Acayan wrote:
>> Changes since v2 ([e-mail]):
>>   - patch vtdr6130 to use _large (3/3)
>>   - remove Change-Id again (1/3)
>>   - change patch subject (1-2/3)
>>   - correct function name in patch description (2/3)
>>   - add Tested-by tags (1-2/3)
>>
>> Changes since v1 ([e-mail]):
>>   - move 16-bit brightness handling to new functions and revert API
>>     change (1/2)
>>   - remove Change-Id in compliance with checkpatch.pl (1/2)
>>   - separate panel driver changes (2/2)
>>
>> This series adds proper support for 16-bit MIPI DSI brightness and
>> cleans up existing panel drivers with 16-bit brightness.
> 
> The series is:
> Reviewed-by: Sam Ravnborg <[e-mail]>
> 
> Neil - I hope you can land this in drm-misc.

Sure, done !

Thanks,
Neil

> 
> 	Sam