| Message ID | 20230208103709.116896-1-angelogioacchino.delregno@collabora.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Panfrost: Improve and add MediaTek SoCs support | expand |
On 08/02/2023 10:37, AngeloGioacchino Del Regno wrote: > This series adds support for new MediaTek SoCs (MT8186/MT8192/MT8195) > and improves MT8183 support: since the mtk-regulator-coupler driver > was picked, it is now useless for Panfrost to look for, and manage, > two regulators (GPU Vcore and GPU SRAM) on MediaTek; Yay! ;) I never did like Panfrost dealing with two regulators. > The aforementioned driver will take care of keeping the voltage > relation (/constraints) of the two regulators on its own when a > voltage change request is sent to the Vcore, solving the old time > issue with not working DVFS on Panfrost+MediaTek (due to devfreq > supporting only single regulator). > > In the specific case of MT8183, in order to not break the ABI, it > was necessary to add a new compatible for enabling DVFS. It's a shame to need a new compatible, but it seems sensible to me. For the panfrost changes: Reviewed-by: Steven Price <steven.price@arm.com> I'll let others comment on the DT binding changes. Thanks, Steve > Alyssa Rosenzweig (3): > drm/panfrost: Increase MAX_PM_DOMAINS to 5 > drm/panfrost: Add the MT8192 GPU ID > drm/panfrost: Add mediatek,mt8192-mali compatible > > AngeloGioacchino Del Regno (6): > dt-bindings: gpu: mali-bifrost: Don't allow sram-supply by default > dt-bindings: gpu: mali-bifrost: Allow up to 5 power domains for MT8192 > dt-bindings: gpu: mali-bifrost: Add compatible for MT8195 SoC > dt-bindings: gpu: mali-bifrost: Add new MT8183 compatible > dt-bindings: gpu: mali-bifrost: Add a compatible for MediaTek MT8186 > drm/panfrost: Add new compatible for Mali on the MT8183 SoC > > .../bindings/gpu/arm,mali-bifrost.yaml | 68 +++++++++++++++++-- > drivers/gpu/drm/panfrost/panfrost_device.h | 2 +- > drivers/gpu/drm/panfrost/panfrost_drv.c | 28 ++++++++ > drivers/gpu/drm/panfrost/panfrost_gpu.c | 8 +++ > 4 files changed, 99 insertions(+), 7 deletions(-) >
On Wed, Feb 8, 2023 at 6:37 PM AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> wrote: > > This series adds support for new MediaTek SoCs (MT8186/MT8192/MT8195) > and improves MT8183 support: since the mtk-regulator-coupler driver > was picked, it is now useless for Panfrost to look for, and manage, > two regulators (GPU Vcore and GPU SRAM) on MediaTek; > > The aforementioned driver will take care of keeping the voltage > relation (/constraints) of the two regulators on its own when a > voltage change request is sent to the Vcore, solving the old time > issue with not working DVFS on Panfrost+MediaTek (due to devfreq > supporting only single regulator). > > In the specific case of MT8183, in order to not break the ABI, it > was necessary to add a new compatible for enabling DVFS. Tested on MT8183 Juniper (Kukui-based device), MT8192 Hayato (Asurada-based), and MT8195 Tomato (Cherry-based). GPU probed. When running glmark-es2-drm, observed state transitions in /sys/class/devfreq/13040000.gpu/trans_stat , as well as actual changes to values for regulators and clocks. Tested-by: Chen-Yu Tsai <wenst@chromium.org> Also observed that sometimes when glmark terminated, the GPU would not be brought down to the lowest OPP.