| Message ID | 20230312191751.183450-1-hdegoede@redhat.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | drm/amd/display: Pass proper parent for DM backlight device v3 | expand |
On 3/12/23 13:17, Hans de Goede wrote: > Hi All, > > Here is version 3 of my patch series to pass the proper parent device > to backlight_device_register(). > > Changes in v3: > - Make amdgpu_dm_register_backlight_device() check bl_idx != 1 before > registering the backlight since amdgpu_dm_connector_late_register() > now calls it for _all_ connectors. > > Changes in v2: > - Patches 1 - 5 are new, reworking the code a bit to allow delaying > the registering, so this has turned from a single patch into > a 6 patch set. > - Patch 6 now delays the registering of the backlight_dev till > after the drm_connector is registered by doing it from > drm_connector_funcs.late_register. > > Note this no longer is RFC since this has been successfully > tested on 3 laptops which hit the affected code path. > > Version 3 has also been tested on my personal AMD Ryzen 7 5700G APU > desktop machine and now no longer tries to register a backlight > device for each connector there. > > Regards, > > Hans > > > Hans de Goede (6): > drm/amd/display/amdgpu_dm: Fix backlight_device_register() error > handling > drm/amd/display/amdgpu_dm: Refactor register_backlight_device() > drm/amd/display/amdgpu_dm: Add a bl_idx to amdgpu_dm_connector > drm/amd/display/amdgpu_dm: Move most backlight setup into > setup_backlight_device() > drm/amd/display/amdgpu_dm: Make amdgpu_dm_register_backlight_device() > take an amdgpu_dm_connector > drm/amd/display/amdgpu_dm: Pass proper parent for backlight device > registration v3 > > .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 100 ++++++++---------- > .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 1 + > 2 files changed, 46 insertions(+), 55 deletions(-) > Hi, First of all, thanks a lot for this patchset. I run your series in our CI (IGT-based), and I also conducted some manual tests in my ASICs. Everything looks fine. I also reviewed this series, and it LGTM: Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com> Finally, I pushed it to amd-staging-drm-next. Thanks Siqueira
Hi, On 3/16/23 15:57, Rodrigo Siqueira Jordao wrote: > > > On 3/12/23 13:17, Hans de Goede wrote: >> Hi All, >> >> Here is version 3 of my patch series to pass the proper parent device >> to backlight_device_register(). >> >> Changes in v3: >> - Make amdgpu_dm_register_backlight_device() check bl_idx != 1 before >> registering the backlight since amdgpu_dm_connector_late_register() >> now calls it for _all_ connectors. >> >> Changes in v2: >> - Patches 1 - 5 are new, reworking the code a bit to allow delaying >> the registering, so this has turned from a single patch into >> a 6 patch set. >> - Patch 6 now delays the registering of the backlight_dev till >> after the drm_connector is registered by doing it from >> drm_connector_funcs.late_register. >> >> Note this no longer is RFC since this has been successfully >> tested on 3 laptops which hit the affected code path. >> >> Version 3 has also been tested on my personal AMD Ryzen 7 5700G APU >> desktop machine and now no longer tries to register a backlight >> device for each connector there. >> >> Regards, >> >> Hans >> >> >> Hans de Goede (6): >> drm/amd/display/amdgpu_dm: Fix backlight_device_register() error >> handling >> drm/amd/display/amdgpu_dm: Refactor register_backlight_device() >> drm/amd/display/amdgpu_dm: Add a bl_idx to amdgpu_dm_connector >> drm/amd/display/amdgpu_dm: Move most backlight setup into >> setup_backlight_device() >> drm/amd/display/amdgpu_dm: Make amdgpu_dm_register_backlight_device() >> take an amdgpu_dm_connector >> drm/amd/display/amdgpu_dm: Pass proper parent for backlight device >> registration v3 >> >> .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 100 ++++++++---------- >> .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 1 + >> 2 files changed, 46 insertions(+), 55 deletions(-) >> > > Hi, > > First of all, thanks a lot for this patchset. > > I run your series in our CI (IGT-based), and I also conducted some manual tests in my ASICs. Everything looks fine. > > I also reviewed this series, and it LGTM: > > Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com> > > Finally, I pushed it to amd-staging-drm-next. Great, thank you. Regards, Hans
Hi All, Here is version 3 of my patch series to pass the proper parent device to backlight_device_register(). Changes in v3: - Make amdgpu_dm_register_backlight_device() check bl_idx != 1 before registering the backlight since amdgpu_dm_connector_late_register() now calls it for _all_ connectors. Changes in v2: - Patches 1 - 5 are new, reworking the code a bit to allow delaying the registering, so this has turned from a single patch into a 6 patch set. - Patch 6 now delays the registering of the backlight_dev till after the drm_connector is registered by doing it from drm_connector_funcs.late_register. Note this no longer is RFC since this has been successfully tested on 3 laptops which hit the affected code path. Version 3 has also been tested on my personal AMD Ryzen 7 5700G APU desktop machine and now no longer tries to register a backlight device for each connector there. Regards, Hans Hans de Goede (6): drm/amd/display/amdgpu_dm: Fix backlight_device_register() error handling drm/amd/display/amdgpu_dm: Refactor register_backlight_device() drm/amd/display/amdgpu_dm: Add a bl_idx to amdgpu_dm_connector drm/amd/display/amdgpu_dm: Move most backlight setup into setup_backlight_device() drm/amd/display/amdgpu_dm: Make amdgpu_dm_register_backlight_device() take an amdgpu_dm_connector drm/amd/display/amdgpu_dm: Pass proper parent for backlight device registration v3 .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 100 ++++++++---------- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 1 + 2 files changed, 46 insertions(+), 55 deletions(-)