mbox series

[v2,0/2] Add support for dumping error captures via kernel logging

Message ID 20230418181744.3251240-1-John.C.Harrison@Intel.com (mailing list archive)
Headers show
Series Add support for dumping error captures via kernel logging | expand

Message

John Harrison April 18, 2023, 6:17 p.m. UTC 
From: John Harrison <John.C.Harrison@Intel.com>

Sometimes, the only effective way to debug an issue is to dump all the
interesting information at the point of failure. So add support for
doing that.

v2: Extra CONFIG wrapping (review feedback from Rodrigo)

Signed-off-by: John Harrison <John.C.Harrison@Intel.com>


John Harrison (2):
  drm/i915: Dump error capture to kernel log
  drm/i915/guc: Dump error capture to dmesg on CTB error

 drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c |  53 +++++++++
 drivers/gpu/drm/i915/gt/uc/intel_guc_ct.h |   6 +
 drivers/gpu/drm/i915/i915_gpu_error.c     | 132 ++++++++++++++++++++++
 drivers/gpu/drm/i915/i915_gpu_error.h     |  10 ++
 4 files changed, 201 insertions(+)

Comments

Vinay Belgaumkar May 16, 2023, 6:54 p.m. UTC | #1 
On 4/18/2023 11:17 AM, John.C.Harrison@Intel.com wrote:
> From: John Harrison <John.C.Harrison@Intel.com>
>
> Sometimes, the only effective way to debug an issue is to dump all the
> interesting information at the point of failure. So add support for
> doing that.
>
> v2: Extra CONFIG wrapping (review feedback from Rodrigo)
>
> Signed-off-by: John Harrison <John.C.Harrison@Intel.com>

series LGTM,

Reviewed-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com>

>
>
> John Harrison (2):
>    drm/i915: Dump error capture to kernel log
>    drm/i915/guc: Dump error capture to dmesg on CTB error
>
>   drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c |  53 +++++++++
>   drivers/gpu/drm/i915/gt/uc/intel_guc_ct.h |   6 +
>   drivers/gpu/drm/i915/i915_gpu_error.c     | 132 ++++++++++++++++++++++
>   drivers/gpu/drm/i915/i915_gpu_error.h     |  10 ++
>   4 files changed, 201 insertions(+)
>