From patchwork Fri Apr 28 18:56:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Harrison X-Patchwork-Id: 13226692 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B4143C77B7E for ; Fri, 28 Apr 2023 18:56:47 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0162F10E370; Fri, 28 Apr 2023 18:56:35 +0000 (UTC) Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id E1FA410E138; Fri, 28 Apr 2023 18:56:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1682708192; x=1714244192; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=eDkW2cR9Wen7PMb6wrUVyK1dCDz4YixjYNAAg+P69pQ=; b=NXaraPH9OMghNim81yEmad8tStlBRDd5uYusflAkhWaPy8Y7LZkIuzIR 5jkGrSGVVFxwNLcb8bcPeLyI8oCvwQ9UctLCTV8AVAJKKDZOS7TnHysZY CW8j62N4WlEMKsKKqj5EockJLxDanJ0amYMz8iWi9dkM6rQKt8gWJ+JX3 uj25bUg+mP4YEWAZtyP+ygMuCnZC12TnbL/XVpQ3wBMfDJercS0WDNOJQ s70TP62wd4pt/ZfEzF3waAJm2lK6L8kgznOunE5PdL227S7IJ0bxyisDT J6rgRNMDby12PEFCgN3nXXOKfJ0kQStmlZshwE1NPuXuHCzkWGiHyjVUt g==; X-IronPort-AV: E=McAfee;i="6600,9927,10694"; a="410934511" X-IronPort-AV: E=Sophos;i="5.99,235,1677571200"; d="scan'208";a="410934511" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Apr 2023 11:56:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10694"; a="869291576" X-IronPort-AV: E=Sophos;i="5.99,235,1677571200"; d="scan'208";a="869291576" Received: from relo-linux-5.jf.intel.com ([10.165.21.152]) by orsmga005.jf.intel.com with ESMTP; 28 Apr 2023 11:56:30 -0700 From: John.C.Harrison@Intel.com To: Intel-GFX@Lists.FreeDesktop.Org Subject: [PATCH v2 0/4] Improvements to GuC error capture Date: Fri, 28 Apr 2023 11:56:32 -0700 Message-Id: <20230428185636.457407-1-John.C.Harrison@Intel.com> X-Mailer: git-send-email 2.39.1 MIME-Version: 1.0 Organization: Intel Corporation (UK) Ltd. - Co. Reg. #1134945 - Pipers Way, Swindon SN3 1RJ X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: John Harrison , DRI-Devel@Lists.FreeDesktop.Org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" From: John Harrison The GuC error capture list creation was including Gen8 registers on Xe platforms. While fixing that, it was noticed that there were other issues. The platform naming was wrong, the naming of lists was misleading, the steered register code was duplicated and steered registers were not included on all supported platforms. Separately, it was noticed that the capture list search was broken for virtual engines. So fix that up too. v2: Swuash the split patches into a single patch ready for merge. Also include an extra patch about capture lists and virtual engines. Signed-off-by: John Harrison John Harrison (4): drm/i915/guc: Don't capture Gen8 regs on Xe devices drm/i915/guc: Consolidate duplicated capture list code drm/i915/guc: Capture list naming clean up drm/i915/guc: Fix error capture for virtual engines .../gpu/drm/i915/gt/uc/intel_guc_capture.c | 242 ++++++++---------- .../gpu/drm/i915/gt/uc/intel_guc_capture.h | 3 + .../gpu/drm/i915/gt/uc/intel_guc_submission.c | 32 ++- drivers/gpu/drm/i915/i915_gpu_error.c | 11 +- 4 files changed, 149 insertions(+), 139 deletions(-)