mbox series

[v3,00/11] MediaTek DDP GAMMA - 12-bit LUT support

Message ID 20230506123549.101727-1-angelogioacchino.delregno@collabora.com (mailing list archive)
Headers show
Series MediaTek DDP GAMMA - 12-bit LUT support | expand

Message

AngeloGioacchino Del Regno May 6, 2023, 12:35 p.m. UTC
Changes in v3:
 - Fixed issues due to variables renaming during cleanup (oops)
 - This is actually the right series, since v2 was taken from the
   wrong kernel tree.... :-)

Changes in v2:
 - Added explicit inclusion of linux/bitfield.h in patch [06/11]

This series adds support for GAMMA IP requiring and/or supporting
a 12-bits LUT using a slightly different register layout and programming
sequence for multiple LUT banks: this IP version is currently found
on a number of SoCs, not only including the Chromebook/IoT oriented
Kompanio 1200/1380 MT8195/MT8195T, but also Smartphone chips such as
the Dimensity 9200 (MT6985) and others.

This series was tested on MT8195, MT8192, MT8173, MT6795:
 * MT6795, MT8192, MT8173: No regression, works fine.
 * MT8195: Color correction is finally working!


AngeloGioacchino Del Regno (10):
  drm/mediatek: gamma: Reduce indentation in mtk_gamma_set_common()
  drm/mediatek: gamma: Support SoC specific LUT size
  drm/mediatek: gamma: Improve and simplify HW LUT calculation
  drm/mediatek: gamma: Enable the Gamma LUT table only after programming
  drm/mediatek: gamma: Use bitfield macros
  drm/mediatek: gamma: Support specifying number of bits per LUT
    component
  drm/mediatek: gamma: Support multi-bank gamma LUT
  drm/mediatek: gamma: Add support for 12-bit LUT and MT8195
  drm/mediatek: gamma: Make sure relay mode is disabled
  drm/mediatek: gamma: Program gamma LUT type for descending or rising

Jason-JH.Lin (1):
  drm/mediatek: gamma: Adjust mtk_drm_gamma_set_common parameters

 drivers/gpu/drm/mediatek/mtk_disp_aal.c     |   2 +-
 drivers/gpu/drm/mediatek/mtk_disp_drv.h     |   3 +-
 drivers/gpu/drm/mediatek/mtk_disp_gamma.c   | 197 +++++++++++++++++---
 drivers/gpu/drm/mediatek/mtk_drm_crtc.c     |   4 +-
 drivers/gpu/drm/mediatek/mtk_drm_crtc.h     |   1 -
 drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c |   1 +
 drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h |   9 +
 7 files changed, 181 insertions(+), 36 deletions(-)

Comments

Jason-JH Lin (林睿祥) May 9, 2023, 2:35 p.m. UTC | #1
Hi Angelo,

Just reminder there is a dt-binding patch [1]
[1] dt-bindings: mediatek: Add gamma compatible for mt8195

https://patchwork.kernel.org/project/linux-mediatek/patch/20220912013006.27541-3-jason-jh.lin@mediatek.com/

On Sat, 2023-05-06 at 14:35 +0200, AngeloGioacchino Del Regno wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> Changes in v3:
>  - Fixed issues due to variables renaming during cleanup (oops)
>  - This is actually the right series, since v2 was taken from the
>    wrong kernel tree.... :-)
> 
> Changes in v2:
>  - Added explicit inclusion of linux/bitfield.h in patch [06/11]
> 
> This series adds support for GAMMA IP requiring and/or supporting
> a 12-bits LUT using a slightly different register layout and
> programming
> sequence for multiple LUT banks: this IP version is currently found
> on a number of SoCs, not only including the Chromebook/IoT oriented
> Kompanio 1200/1380 MT8195/MT8195T, but also Smartphone chips such as
> the Dimensity 9200 (MT6985) and others.
> 
> This series was tested on MT8195, MT8192, MT8173, MT6795:
>  * MT6795, MT8192, MT8173: No regression, works fine.
>  * MT8195: Color correction is finally working!

Thanks for your help :)

Regards,
Jason-JH.Lin

> 
> AngeloGioacchino Del Regno (10):
>   drm/mediatek: gamma: Reduce indentation in mtk_gamma_set_common()
>   drm/mediatek: gamma: Support SoC specific LUT size
>   drm/mediatek: gamma: Improve and simplify HW LUT calculation
>   drm/mediatek: gamma: Enable the Gamma LUT table only after
> programming
>   drm/mediatek: gamma: Use bitfield macros
>   drm/mediatek: gamma: Support specifying number of bits per LUT
>     component
>   drm/mediatek: gamma: Support multi-bank gamma LUT
>   drm/mediatek: gamma: Add support for 12-bit LUT and MT8195
>   drm/mediatek: gamma: Make sure relay mode is disabled
>   drm/mediatek: gamma: Program gamma LUT type for descending or
> rising
> 
> Jason-JH.Lin (1):
>   drm/mediatek: gamma: Adjust mtk_drm_gamma_set_common parameters
> 
>  drivers/gpu/drm/mediatek/mtk_disp_aal.c     |   2 +-
>  drivers/gpu/drm/mediatek/mtk_disp_drv.h     |   3 +-
>  drivers/gpu/drm/mediatek/mtk_disp_gamma.c   | 197 +++++++++++++++++-
> --
>  drivers/gpu/drm/mediatek/mtk_drm_crtc.c     |   4 +-
>  drivers/gpu/drm/mediatek/mtk_drm_crtc.h     |   1 -
>  drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c |   1 +
>  drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h |   9 +
>  7 files changed, 181 insertions(+), 36 deletions(-)
> 
> --
> 2.40.1
> 
>