From patchwork Sat May 6 19:24:47 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adam Ford X-Patchwork-Id: 13233599 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9F6D0C77B7F for ; Sat, 6 May 2023 19:25:23 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 47EF010E0BE; Sat, 6 May 2023 19:25:22 +0000 (UTC) Received: from mail-io1-xd2d.google.com (mail-io1-xd2d.google.com [IPv6:2607:f8b0:4864:20::d2d]) by gabe.freedesktop.org (Postfix) with ESMTPS id C77C310E0BE for ; Sat, 6 May 2023 19:25:19 +0000 (UTC) Received: by mail-io1-xd2d.google.com with SMTP id ca18e2360f4ac-763c3429a8cso82632039f.2 for ; Sat, 06 May 2023 12:25:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683401118; x=1685993118; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=DtqE7gru9L7aUI9DrBovms89ZLUDI+niZ6Hbhs/0ig8=; b=meePf845x5onCP3jHrfUx2bLn3pgUagH/loKAiW3P+8FoLTOI1EHMYA+i6SwKOYS5X DmxUZWBUkop6/nXsPk9RVReL4pHGw5V+aJP1eaioYu+htGeNYQTrbGJb68x06brnIfVo pA06BnbCQwe67H09Oaj3I+VHnLG2MBu+b7nCyBaOo4JKo8oGiwoc/T82MmfwWE7VmxLN dEJQS5rVgEU/sjGCCwblneX+oDVd3yaaumbJp2Gw1eyzb2zbSRrTT2F0Ko6VeqooxRLt vj4RseBmCqhnKo4nNXfsct3IwRGCyaqDqyezR6jgP+lqbPx0Cs2G6IMCT8PY3wx16PSo zPWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683401118; x=1685993118; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=DtqE7gru9L7aUI9DrBovms89ZLUDI+niZ6Hbhs/0ig8=; b=SjazNFDSqjGn11rODfEbqNaeBVL251VYIyoMVia6fjCG4afa6RkTvqlboXKOlOn5dM RzGam+iGv/KPC//pc8ctrQ2aN2xJNpbdFpuKFBcr6mxMHFFHz6iBgDt7JYs/BdkGAf3J FvTSoSCs7P62rJenKTcMnsRXbbXWlUQyZVIaQJVulO/02Kp93DU+XZicUX1BuPdNnnBJ JiCOv3RutveDN6BO4djEAkmDwJJv5RBHHD5B8V/Ut7WHZekiAerioxe6dDT0BldF4e++ YRE/k6mpMTwk9A7sbuS31SGyN+b27udf73QW8uazKu6syF52bs0iXUDI3+jmAenRLYp2 jThQ== X-Gm-Message-State: AC+VfDzOQtc0QN6vgY/HB8m4LOFYZNlI5q3Qwk56OYdCjAQ6DrIPcs5O DP5RlHiuxM5TPu/jQew+hD2qsZ2P5+YBGQ== X-Google-Smtp-Source: ACHHUZ4dcKKPwYUA5qy9tz+3ej5+IshZTlk/SCv0lDxO8AxW+LCiJQ0VbHVnEzi3plh/aoKvj4xKig== X-Received: by 2002:a05:6e02:68d:b0:331:4865:c891 with SMTP id o13-20020a056e02068d00b003314865c891mr3291971ils.24.1683401118042; Sat, 06 May 2023 12:25:18 -0700 (PDT) Received: from aford-B741.lan ([2601:447:d001:897f:5e49:1bed:79d0:5c25]) by smtp.gmail.com with ESMTPSA id z18-20020a05663822b200b0041631393ac9sm847824jas.18.2023.05.06.12.25.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 May 2023 12:25:17 -0700 (PDT) From: Adam Ford To: dri-devel@lists.freedesktop.org Subject: [PATCH V5 0/6] drm: bridge: samsung-dsim: Support variable clocking Date: Sat, 6 May 2023 14:24:47 -0500 Message-Id: <20230506192453.725621-1-aford173@gmail.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Neil Armstrong , Robert Foss , Jonas Karlman , aford@beaconembedded.com, Jernej Skrabec , Frieder Schrempf , Laurent Pinchart , Andrzej Hajda , Marek Szyprowski , Adam Ford , linux-kernel@vger.kernel.org, Jagan Teki Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" This series fixes the blanking packet size and the PMS calculation. According to Lucas, "The blanking packets are MIPI long packets, so 4 byte header, payload, 2 bytes footer." It also dds support to allows the DSIM to dynamically DPHY clocks, and support non-burst mode while allowing the removal of the hard-coded clock values for the PLL for imx8m mini/nano/plus, and it allows the removal of the burst-clock device tree entry when burst-mode isn't supported by connected devices like a brige. In that event, the HS clock is set to the value requested by the bridge chip. This has been tested on both an i.MX8M Nano and i.MX8M Plus, and should work on i.MX8M Mini as well based on feedback from other users. Adam Ford (5): drm: bridge: samsung-dsim: Fix PMS Calculator on imx8m[mnp] drm: bridge: samsung-dsim: Fetch pll-clock-frequency automatically drm: bridge: samsung-dsim: Select GENERIC_PHY_MIPI_DPHY drm: bridge: samsung-dsim: Dynamically configure DPHY timing drm: bridge: samsung-dsim: Support non-burst mode Lucas Stach (1): drm: bridge: samsung-dsim: fix blanking packet size calculation drivers/gpu/drm/bridge/Kconfig | 1 + drivers/gpu/drm/bridge/samsung-dsim.c | 160 ++++++++++++++++++++++---- include/drm/bridge/samsung-dsim.h | 5 + 3 files changed, 143 insertions(+), 23 deletions(-) --- V5: Update error message to dev_info and change them to indicate what is happening without sounding like an error when optional device tree entries are missing. V4: Undo some accidental whitespace changes, rename PS_TO_CYCLE variables to ps and hz from PS and MHz. Remove if check before the samsung_dsim_set_phy_ctrl call since it's unnecessary. Added additional tested-by and reviewed-by comments. Squash patches 6 and 7 together since the supporting non-burst (patch 6) mode doesn't really work until patch 7 was applied. V3: When checking if the bust-clock is present, only check for it in the device tree, and don't check the presence of the MIPI_DSI_MODE_VIDEO_BURST flag as it breaks an existing Exynos board. Add a new patch to the series to select GENERIC_PHY_MIPI_DPHY in Kconfig otherwise the build breaks on the 32-bit Exynos. Change vco_min variable name to min_freq Added tested-by from Chen-Yu Tsai V2: Instead of using my packet blanking calculation, this integrates on from Lucas Stach which gets modified later in the series to cache the value of the HS-clock instead of having to do the calucations again. Instead of completely eliminating the PLL clock frequency from the device tree, this makes it optional to avoid breaking some Samsung devices. When the samsung,pll-clock-frequency is not found, it reads the value of the clock named "sclk_mipi" This also maintains backwords compatibility with older device trees. This also changes the DPHY calcuation from a Look-up table, a reverse engineered algorithm which uses phy_mipi_dphy_get_default_config to determine the standard nominal values and calculates the cycles necessary to update the DPHY timings accordingly.