| Message ID | 20230612090157.68205-1-angelogioacchino.delregno@collabora.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | MediaTek DDP GAMMA - 12-bit LUT support | expand |
Il 12/06/23 11:01, AngeloGioacchino Del Regno ha scritto: > Changes in v6: > - Fixed smatch warning in patch 11/11, ref.: > https://lore.kernel.org/all/202306101458.lRXHEE0Z-lkp@intel.com/ > This series is fully ready. CK, can we get this one and the mtk-dp series [1] in -next for this cycle please? Those are the last pieces that would allow enabling display on MT8195 Chromebooks. [1]: https://lore.kernel.org/lkml/20230404104800.301150-1-angelogioacchino.delregno@collabora.com/ Thanks, Angelo > Changes in v5: > - Removed incorrect comment on default LUT size and bits > - Removed useless check for num_lut_banks > - Added comment about CMDQ implementation on patch 5 > - Evaluated passing lut size/bits from AAL, idea discarded as > the implementation would be rather tricky while bringing no > benefits. > > Changes in v4: > - Fixed assignment typo appeared in v3 > > Changes in v3: > - Fixed issues due to variables renaming during cleanup (oops) > - This is actually the right series, since v2 was taken from the > wrong kernel tree.... :-) > > Changes in v2: > - Added explicit inclusion of linux/bitfield.h in patch [06/11] > > This series adds support for GAMMA IP requiring and/or supporting > a 12-bits LUT using a slightly different register layout and programming > sequence for multiple LUT banks: this IP version is currently found > on a number of SoCs, not only including the Chromebook/IoT oriented > Kompanio 1200/1380 MT8195/MT8195T, but also Smartphone chips such as > the Dimensity 9200 (MT6985) and others. > > This series was tested on MT8195, MT8192, MT8173, MT6795: > * MT6795, MT8192, MT8173: No regression, works fine. > * MT8195: Color correction is finally working! > > AngeloGioacchino Del Regno (10): > drm/mediatek: gamma: Reduce indentation in mtk_gamma_set_common() > drm/mediatek: gamma: Support SoC specific LUT size > drm/mediatek: gamma: Improve and simplify HW LUT calculation > drm/mediatek: gamma: Enable the Gamma LUT table only after programming > drm/mediatek: gamma: Use bitfield macros > drm/mediatek: gamma: Support specifying number of bits per LUT > component > drm/mediatek: gamma: Support multi-bank gamma LUT > drm/mediatek: gamma: Add support for 12-bit LUT and MT8195 > drm/mediatek: gamma: Make sure relay mode is disabled > drm/mediatek: gamma: Program gamma LUT type for descending or rising > > Jason-JH.Lin (1): > drm/mediatek: gamma: Adjust mtk_drm_gamma_set_common parameters > > drivers/gpu/drm/mediatek/mtk_disp_aal.c | 2 +- > drivers/gpu/drm/mediatek/mtk_disp_drv.h | 3 +- > drivers/gpu/drm/mediatek/mtk_disp_gamma.c | 193 ++++++++++++++++---- > drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 4 +- > drivers/gpu/drm/mediatek/mtk_drm_crtc.h | 1 - > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 1 + > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h | 9 + > 7 files changed, 177 insertions(+), 36 deletions(-) >
Changes in v6: - Fixed smatch warning in patch 11/11, ref.: https://lore.kernel.org/all/202306101458.lRXHEE0Z-lkp@intel.com/ Changes in v5: - Removed incorrect comment on default LUT size and bits - Removed useless check for num_lut_banks - Added comment about CMDQ implementation on patch 5 - Evaluated passing lut size/bits from AAL, idea discarded as the implementation would be rather tricky while bringing no benefits. Changes in v4: - Fixed assignment typo appeared in v3 Changes in v3: - Fixed issues due to variables renaming during cleanup (oops) - This is actually the right series, since v2 was taken from the wrong kernel tree.... :-) Changes in v2: - Added explicit inclusion of linux/bitfield.h in patch [06/11] This series adds support for GAMMA IP requiring and/or supporting a 12-bits LUT using a slightly different register layout and programming sequence for multiple LUT banks: this IP version is currently found on a number of SoCs, not only including the Chromebook/IoT oriented Kompanio 1200/1380 MT8195/MT8195T, but also Smartphone chips such as the Dimensity 9200 (MT6985) and others. This series was tested on MT8195, MT8192, MT8173, MT6795: * MT6795, MT8192, MT8173: No regression, works fine. * MT8195: Color correction is finally working! AngeloGioacchino Del Regno (10): drm/mediatek: gamma: Reduce indentation in mtk_gamma_set_common() drm/mediatek: gamma: Support SoC specific LUT size drm/mediatek: gamma: Improve and simplify HW LUT calculation drm/mediatek: gamma: Enable the Gamma LUT table only after programming drm/mediatek: gamma: Use bitfield macros drm/mediatek: gamma: Support specifying number of bits per LUT component drm/mediatek: gamma: Support multi-bank gamma LUT drm/mediatek: gamma: Add support for 12-bit LUT and MT8195 drm/mediatek: gamma: Make sure relay mode is disabled drm/mediatek: gamma: Program gamma LUT type for descending or rising Jason-JH.Lin (1): drm/mediatek: gamma: Adjust mtk_drm_gamma_set_common parameters drivers/gpu/drm/mediatek/mtk_disp_aal.c | 2 +- drivers/gpu/drm/mediatek/mtk_disp_drv.h | 3 +- drivers/gpu/drm/mediatek/mtk_disp_gamma.c | 193 ++++++++++++++++---- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 4 +- drivers/gpu/drm/mediatek/mtk_drm_crtc.h | 1 - drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 1 + drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h | 9 + 7 files changed, 177 insertions(+), 36 deletions(-)