From patchwork Tue Jul 11 21:34:55 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Almeida?= X-Patchwork-Id: 13309393 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C8EB4EB64DD for ; Tue, 11 Jul 2023 21:35:48 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 01BB010E432; Tue, 11 Jul 2023 21:35:47 +0000 (UTC) Received: from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56]) by gabe.freedesktop.org (Postfix) with ESMTPS id BB50010E036; Tue, 11 Jul 2023 21:35:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID: Date:Subject:Cc:To:From:Sender:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=zxO2JUIk0+qcytPvORKjR4DXSclXMm1DGFD/RYtrULs=; b=hXyqhIfbhMl1hyi6fpooEVg7aG vc0Jq3WEj44nQhxddDYXuY1tI9OMYqU4WMBWGnxDcktpU6Fh4k0A7gRZ+6H+racLX+nDrolqEaMyl XNc+tgEgEnx8t90fDMLEprhMR1alVokirVMLzTmQXJFWOYbhmdboiJWnr25knb510mE5sVShcAeo+ 5JVZeaIzo2XvWEOUSkfbJL8mRnHWK1ezp/ETAUkiauFJW8Oeqcp7GXx+wbcJ6uLB7VaSdTVogLbAL a8uqc4zDcDVjDqDHx5awi49ACoCZHwcGAWUP4HEMM5gEtdHZY73W4XoA3UsREznZfMIGui4ZPE7Jj don4WyOg==; Received: from [187.74.70.209] (helo=steammachine.lan) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim) id 1qJL1H-00Cl0M-N0; Tue, 11 Jul 2023 23:35:40 +0200 From: =?utf-8?q?Andr=C3=A9_Almeida?= To: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH 0/6] drm/amdgpu: Add new reset option and rework coredump Date: Tue, 11 Jul 2023 18:34:55 -0300 Message-ID: <20230711213501.526237-1-andrealmeid@igalia.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: pierre-eric.pelloux-prayer@amd.com, =?utf-8?q?Andr=C3=A9_Almeida?= , =?utf-8?b?J01hcmVr?= =?utf-8?b?IE9sxaHDoWsn?= , =?utf-8?q?Timur_Krist=C3=B3f?= , michel.daenzer@mailbox.org, Samuel Pitoiset , kernel-dev@igalia.com, alexander.deucher@amd.com, christian.koenig@amd.com Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi, The goal of this patchset is to improve debugging device resets on amdgpu. The first patch creates a new module parameter to disable soft recoveries, ensuring every recovery go through the full device reset, making easier to generate resets from userspace tools like [0] and [1]. This is important to validate how the stack behaves on resets, from end-to-end. The second patch is a small addition to mark guilty jobs that causes soft recoveries for API consistency. The last patches are a rework to store more information at devcoredump files, making it more useful to be attached to bug reports. The new coredump content look like this: **** AMDGPU Device Coredump **** version: 1 kernel: 6.4.0-rc7-tony+ module: amdgpu time: 702.743534320 process_name: vulkan-triangle PID: 4561 IBs: [0] 0xffff800100545000 [1] 0xffff800100001000 ring name: gfx_0.0.0 Due to nested IBs, this may not be the one that really caused the hang, but it gives some direction. Thanks, André [0] https://gitlab.freedesktop.org/andrealmeid/gpu-timeout [1] https://github.com/andrealmeid/vulkan-triangle-v1 André Almeida (6): drm/amdgpu: Create a module param to disable soft recovery drm/amdgpu: Mark contexts guilty for causing soft recoveries drm/amdgpu: Rework coredump to use memory dynamically drm/amdgpu: Limit info in coredump for kernel threads drm/amdgpu: Log IBs and ring name at coredump drm/amdgpu: Create version number for coredumps drivers/gpu/drm/amd/amdgpu/amdgpu.h | 21 +++-- drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c | 6 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 99 +++++++++++++++++----- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 9 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c | 6 +- 5 files changed, 112 insertions(+), 29 deletions(-)