From patchwork Fri Jul 28 14:58:21 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13332026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 65EC9C0015E for ; Fri, 28 Jul 2023 14:58:48 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7E4C010E712; Fri, 28 Jul 2023 14:58:47 +0000 (UTC) Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by gabe.freedesktop.org (Postfix) with ESMTPS id 322AE10E711 for ; Fri, 28 Jul 2023 14:58:44 +0000 (UTC) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qPOvL-00030M-Om; Fri, 28 Jul 2023 16:58:36 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1qPOvH-002jO6-Bc; Fri, 28 Jul 2023 16:58:31 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1qPOvG-008WkJ-Mm; Fri, 28 Jul 2023 16:58:30 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Javier Martinez Canillas , David Airlie , Daniel Vetter , Helge Deller , Andy Shevchenko , Benjamin Mugnier , Thomas Zimmermann , Jilin Yuan , Thierry Reding Subject: [PATCH 0/3] pwm: Drop useless member "pwm" from struct pwm_device Date: Fri, 28 Jul 2023 16:58:21 +0200 Message-Id: <20230728145824.616687-1-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1462; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=GgA+H1Gx/aannDv0LuSsWcVQWboA8zqkq9tUQR7Z/Sw=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBkw9eH3uUGN77+Vb2x0Jv1uy0u6Gs5UinZWoelT nMFN7o49rSJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZMPXhwAKCRCPgPtYfRL+ TlJOB/45E9Q/4YPkfxStlxoyeLTuVRuH3gCksc56vWUC2p4S/LuW3GOQQzq1xi2EwE66OsCSdi5 oE2B1dcsd31s5x+P4tB+7A5+Jsjq/x4VCYiYn9BlFnVIHYIMrqKBrwFY5AZMl55B53uEa/ynhLD JEf0q4Frgt5btp9o90ShFYe7OpSv0fdbzB3evwhMLclXCgwP+DfsKys6+3BcIOhgx7BwvICH4RD 81/v6GV0JYh5qDmjAzXB7NYl0fMsp5Gv0qtIb4qLsKen6I6N84u0smJOeslMRHdplem6tIlCLYr rLyh0AiI1GHnbAtO3h5JMge8iikd4V1ytdj0ss/OOMvnJvQR X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: dri-devel@lists.freedesktop.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-pwm@vger.kernel.org, linux-fbdev@vger.kernel.org, kernel@pengutronix.de, dri-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hello, there are only two users of struct pwm_device::pwm in the tree; both use it for some dev_dbg output. While this number allows to identify the PWM, it's not trivial, for example the data currently available in /sys/kernel/debug/pwm isn't enough. (You have to look in /sys/class/pwm, pick the pwmchip with the highest number that isn't bigger than the PWM's number.) To be honest the label isn't always usefull either, but it's easy to use and should be enough to identify the used PWM. The parent device + hwid might be more useful?! On the other hand using that for a dev_dbg that is probably only looked at by someone debugging the driver and thus knowing the used PWM anyhow is of little value either. Assuming this change is still considered worthwile I suggest that patches #1 and #2 go in via their respective maintainer trees and I resend patch #3 to go via the pwm tree once these two are "in". Best regards Uwe Uwe Kleine-König (3): drm/ssd130x: Print the PWM's label instead of its number video: fbdev: ssd1307fb: Print the PWM's label instead of its number pwm: Drop unused member "pwm" from struct pwm_device drivers/gpu/drm/solomon/ssd130x.c | 4 ++-- drivers/pwm/core.c | 1 - drivers/video/fbdev/ssd1307fb.c | 4 ++-- include/linux/pwm.h | 1 - 4 files changed, 4 insertions(+), 6 deletions(-) base-commit: 06c2afb862f9da8dc5efa4b6076a0e48c3fbaaa5