mbox series

[0/3] pll-video0 notifier for v6.5+

Message ID 20230807-a64_pll_video0_notifier-v1-0-8a7ccdc14c79@oltmanns.dev (mailing list archive)
Headers show
Series pll-video0 notifier for v6.5+ | expand

Message

Frank Oltmanns Aug. 7, 2023, 9:36 a.m. UTC
Hi Icenowy,

it is my understanding that you are the original author of the following
patches are in Ondřej's 6.4 branch [1] [2] [3] but not in his 6.5
branch. I assume it is because of merge conflicts as the part about
setting the parent has already been fixed in the 6.5 release candidates.

Therefore I've removed those parts and adopted the commit message of
PATCH 2. I've removed your SoB, because I think you'd need to sign of
the revised version. Especially patch 2 has become a bit simpler and I'm
wondering if it makes sense to try to upstream the three patches now.
What do you think?

Thank you for your amazing work!

Best regards,
  Frank

[1]: https://github.com/megous/linux/commit/2cd3d57adf83e2d091baed77e1aafc01d545d123
[2]: https://github.com/megous/linux/commit/c9c7bfe22f0fefdfc1dc2ce84b452964112399d7
[3]: https://github.com/megous/linux/commit/e19ccee10a8492535b6cda1ba97cccc2074d6e65

Signed-off-by: Frank Oltmanns <frank@oltmanns.dev>
---
Icenowy Zheng (3):
      clk: sunxi-ng: add support for rate resetting notifier
      clk: sunxi-ng: a64: keep tcon0 clock rate when pll-video0's rate changes
      drm/sun4i: tcon: hand over the duty to keep TCON0 clock to CCU on A64

 drivers/clk/sunxi-ng/ccu-sun50i-a64.c | 15 +++++++++++++++
 drivers/clk/sunxi-ng/ccu_common.c     | 22 ++++++++++++++++++++++
 drivers/clk/sunxi-ng/ccu_common.h     | 12 ++++++++++++
 drivers/gpu/drm/sun4i/sun4i_tcon.c    | 15 +++++++++++++--
 drivers/gpu/drm/sun4i/sun4i_tcon.h    |  1 +
 5 files changed, 63 insertions(+), 2 deletions(-)
---
base-commit: 1cf5c37ee3c2334a964c65e52b4e0c59b4332d7c
change-id: 20230807-a64_pll_video0_notifier-164cbc78b341

Best regards,

Comments

Chen-Yu Tsai Aug. 10, 2023, 1:18 p.m. UTC | #1
On Mon, Aug 7, 2023 at 5:36 PM Frank Oltmanns <frank@oltmanns.dev> wrote:
>
> Hi Icenowy,
>
> it is my understanding that you are the original author of the following
> patches are in Ondřej's 6.4 branch [1] [2] [3] but not in his 6.5
> branch. I assume it is because of merge conflicts as the part about
> setting the parent has already been fixed in the 6.5 release candidates.
>
> Therefore I've removed those parts and adopted the commit message of
> PATCH 2. I've removed your SoB, because I think you'd need to sign of
> the revised version. Especially patch 2 has become a bit simpler and I'm
> wondering if it makes sense to try to upstream the three patches now.
> What do you think?
>
> Thank you for your amazing work!
>
> Best regards,
>   Frank

Please send to all maintainers and relevant mailing lists (as given
by get_maintainers.pl).


> [1]: https://github.com/megous/linux/commit/2cd3d57adf83e2d091baed77e1aafc01d545d123
> [2]: https://github.com/megous/linux/commit/c9c7bfe22f0fefdfc1dc2ce84b452964112399d7
> [3]: https://github.com/megous/linux/commit/e19ccee10a8492535b6cda1ba97cccc2074d6e65
>
> Signed-off-by: Frank Oltmanns <frank@oltmanns.dev>
> ---
> Icenowy Zheng (3):
>       clk: sunxi-ng: add support for rate resetting notifier
>       clk: sunxi-ng: a64: keep tcon0 clock rate when pll-video0's rate changes
>       drm/sun4i: tcon: hand over the duty to keep TCON0 clock to CCU on A64
>
>  drivers/clk/sunxi-ng/ccu-sun50i-a64.c | 15 +++++++++++++++
>  drivers/clk/sunxi-ng/ccu_common.c     | 22 ++++++++++++++++++++++
>  drivers/clk/sunxi-ng/ccu_common.h     | 12 ++++++++++++
>  drivers/gpu/drm/sun4i/sun4i_tcon.c    | 15 +++++++++++++--
>  drivers/gpu/drm/sun4i/sun4i_tcon.h    |  1 +
>  5 files changed, 63 insertions(+), 2 deletions(-)
> ---
> base-commit: 1cf5c37ee3c2334a964c65e52b4e0c59b4332d7c
> change-id: 20230807-a64_pll_video0_notifier-164cbc78b341
>
> Best regards,
> --
> Frank Oltmanns <frank@oltmanns.dev>
>
>
Frank Oltmanns Aug. 12, 2023, 8:36 a.m. UTC | #2
On 2023-08-10 at 21:18:12 +0800, Chen-Yu Tsai <wens@kernel.org> wrote:
> On Mon, Aug 7, 2023 at 5:36 PM Frank Oltmanns <frank@oltmanns.dev> wrote:
>>
>> Hi Icenowy,
>>
>> it is my understanding that you are the original author of the following
>> patches are in Ondřej's 6.4 branch [1] [2] [3] but not in his 6.5
>> branch. I assume it is because of merge conflicts as the part about
>> setting the parent has already been fixed in the 6.5 release candidates.
>>
>> Therefore I've removed those parts and adopted the commit message of
>> PATCH 2. I've removed your SoB, because I think you'd need to sign of
>> the revised version. Especially patch 2 has become a bit simpler and I'm
>> wondering if it makes sense to try to upstream the three patches now.
>> What do you think?
>>
>> Thank you for your amazing work!
>>
>> Best regards,
>>   Frank
>
> Please send to all maintainers and relevant mailing lists (as given
> by get_maintainers.pl).
>

Thank you for pointing this out. This was actually intended as an RFC
specifically for Icenowy, but I forgot to mark it as such.

Furthermore, I decided to cc the two lists because I had trouble
receiving Icenowy's mails in the past and I wanted to make sure I could
at least browse the archives for responses.

I'll take more care next time.

Thanks,
  Frank

>
>
>> [1]: https://github.com/megous/linux/commit/2cd3d57adf83e2d091baed77e1aafc01d545d123
>> [2]: https://github.com/megous/linux/commit/c9c7bfe22f0fefdfc1dc2ce84b452964112399d7
>> [3]: https://github.com/megous/linux/commit/e19ccee10a8492535b6cda1ba97cccc2074d6e65
>>
>> Signed-off-by: Frank Oltmanns <frank@oltmanns.dev>
>> ---
>> Icenowy Zheng (3):
>>       clk: sunxi-ng: add support for rate resetting notifier
>>       clk: sunxi-ng: a64: keep tcon0 clock rate when pll-video0's rate changes
>>       drm/sun4i: tcon: hand over the duty to keep TCON0 clock to CCU on A64
>>
>>  drivers/clk/sunxi-ng/ccu-sun50i-a64.c | 15 +++++++++++++++
>>  drivers/clk/sunxi-ng/ccu_common.c     | 22 ++++++++++++++++++++++
>>  drivers/clk/sunxi-ng/ccu_common.h     | 12 ++++++++++++
>>  drivers/gpu/drm/sun4i/sun4i_tcon.c    | 15 +++++++++++++--
>>  drivers/gpu/drm/sun4i/sun4i_tcon.h    |  1 +
>>  5 files changed, 63 insertions(+), 2 deletions(-)
>> ---
>> base-commit: 1cf5c37ee3c2334a964c65e52b4e0c59b4332d7c
>> change-id: 20230807-a64_pll_video0_notifier-164cbc78b341
>>
>> Best regards,
>> --
>> Frank Oltmanns <frank@oltmanns.dev>
>>
>>