From patchwork Fri Mar 1 00:12:06 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= X-Patchwork-Id: 13577769 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 69A2AC54798 for ; Fri, 1 Mar 2024 00:12:19 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8EB3C10E72D; Fri, 1 Mar 2024 00:12:18 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=collabora.com header.i=@collabora.com header.b="D7Km4Ojv"; dkim-atps=neutral Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) by gabe.freedesktop.org (Postfix) with ESMTPS id BD02910E732 for ; Fri, 1 Mar 2024 00:12:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1709251935; bh=ddNDXXuct86kt9fa1yOGg6EFSRsJaqUkVKYspL0iIzM=; h=From:Subject:Date:To:Cc:From; b=D7Km4Ojv9tZIrYtyn+iT03V9mKDPM3/jf96hLHKZ2I7VHIJlrFZ2LNgA5CgKz+J0D 8JfN9NZDqnwudR/RkCWIAgWbCKmO8G2GKznUx3fXrtw8F1cDLviJmnMz5APg6BYUrv VGbqPYn4i3VgW/IWXZtltgImXg4QX90KUosiMqBMqg3qp0Zj1aQx0VoulGbmfmwSW1 N67HKyN6WTLX8imZP2NXsfDjmjXETOvgB/9Yz0Lts76bH5kq6nyiYOba0VfFStWSkL Xw/1FmRAFWmiV8FY9ZRAjCqXum9BhKGUivMyMovnjEdlAx54OfL+6IvykySSMEiKpj M815uNpg3QwaA== Received: from [192.168.1.205] (zone.collabora.co.uk [167.235.23.81]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nfraprado) by madrid.collaboradmins.com (Postfix) with ESMTPSA id 49B4A378000E; Fri, 1 Mar 2024 00:12:09 +0000 (UTC) From: =?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= Subject: [PATCH v2 0/9] drm: Switch from dev_err to dev_err_probe for missing DSI host error path Date: Thu, 29 Feb 2024 19:12:06 -0500 Message-Id: <20240229-anx7625-defer-log-no-dsi-host-v2-0-00506941049a@collabora.com> MIME-Version: 1.0 X-B4-Tracking: v=1; b=H4sIAFYd4WUC/43NQQ6CMBCF4auYrh1DBwR05T0Mi3aYQhPsmJYQD OHuVk7g8nuL/20qcfSc1P20qciLT15CBp5PikYTBgbfZysssCoQazBhbWq8Qs+OI0wyQBDok4d R0gxUuhuRJYtto3LjHdn59eg/u+zRp1ni57hb9G/9t7xo0IAVWm1cqdu2epBMk7ESzYXkpbp93 79ZrL/tzgAAAA== To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , owen , Jagan Teki , Marek Vasut , Adrien Grassein , Srinivas Kandagatla , Sam Ravnborg , Bjorn Andersson , Vinod Koul , Dmitry Baryshkov , Vinay Simha BN , Christopher Vollo , Jessica Zhang , Marijn Suijten , AngeloGioacchino Del Regno Cc: kernel@collabora.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, AngeloGioacchino Del Regno , =?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= X-Mailer: b4 0.13.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" This series changes every occurence of the following pattern: dsi_host = of_find_mipi_dsi_host_by_node(dsi); if (!dsi_host) { dev_err(dev, "failed to find dsi host\n"); return -EPROBE_DEFER; } into dsi_host = of_find_mipi_dsi_host_by_node(dsi); if (!dsi_host) return dev_err_probe(dev, -EPROBE_DEFER, "failed to find dsi host\n"); This registers the defer probe reason (so it can later be printed by the driver core or checked on demand through the devices_deferred file in debugfs) and prevents errors to be spammed in the kernel log every time the driver retries to probe, unnecessarily alerting userspace about something that is a normal part of the boot process. I have omitted a Fixes: tag in the last patch, for the truly-nt35597 panel, because it predates the dev_err_probe() helper. Changes in v2: - Added patches 2 onwards to fix all occurences of this pattern instead of just for the anx7625 driver - Link to v1: https://lore.kernel.org/r/20240226-anx7625-defer-log-no-dsi-host-v1-1-242b1af31884@collabora.com Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: Laurent Pinchart --- Nícolas F. R. A. Prado (9): drm/bridge: anx7625: Don't log an error when DSI host can't be found drm/bridge: icn6211: Don't log an error when DSI host can't be found drm/bridge: lt8912b: Don't log an error when DSI host can't be found drm/bridge: lt9611: Don't log an error when DSI host can't be found drm/bridge: lt9611uxc: Don't log an error when DSI host can't be found drm/bridge: tc358775: Don't log an error when DSI host can't be found drm/bridge: dpc3433: Don't log an error when DSI host can't be found drm/panel: novatek-nt35950: Don't log an error when DSI host can't be found drm/panel: truly-nt35597: Don't log an error when DSI host can't be found drivers/gpu/drm/bridge/analogix/anx7625.c | 6 ++---- drivers/gpu/drm/bridge/chipone-icn6211.c | 6 ++---- drivers/gpu/drm/bridge/lontium-lt8912b.c | 6 ++---- drivers/gpu/drm/bridge/lontium-lt9611.c | 6 ++---- drivers/gpu/drm/bridge/lontium-lt9611uxc.c | 6 ++---- drivers/gpu/drm/bridge/tc358775.c | 6 ++---- drivers/gpu/drm/bridge/ti-dlpc3433.c | 17 +++++++++-------- drivers/gpu/drm/panel/panel-novatek-nt35950.c | 6 ++---- drivers/gpu/drm/panel/panel-truly-nt35597.c | 6 ++---- 9 files changed, 25 insertions(+), 40 deletions(-) --- base-commit: 2ae0a045e6814c8c1d676d6153c605a65746aa29 change-id: 20240226-anx7625-defer-log-no-dsi-host-c3f9ccbcb287 Best regards,