From patchwork Fri Mar 22 13:22:21 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Abel Vesa X-Patchwork-Id: 13600065 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 44B35C54E71 for ; Fri, 22 Mar 2024 13:22:40 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4AE5A10EEE3; Fri, 22 Mar 2024 13:22:39 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="dc4hRkTL"; dkim-atps=neutral Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com [209.85.167.47]) by gabe.freedesktop.org (Postfix) with ESMTPS id B930D10EEE3 for ; Fri, 22 Mar 2024 13:22:37 +0000 (UTC) Received: by mail-lf1-f47.google.com with SMTP id 2adb3069b0e04-51381021af1so3352699e87.0 for ; Fri, 22 Mar 2024 06:22:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1711113756; x=1711718556; darn=lists.freedesktop.org; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:from:to:cc:subject:date:message-id:reply-to; bh=zarOYxCOo5GM/MnqDwI9RHuDvosKvb8moWuxJ17HxLw=; b=dc4hRkTLbsrgddZYqKlvhpNCF/0rPbwzvg+2iXccO80bO22Kf5pJ/VC7yP61Teq0OW l0GbUeCx1322BhSb9jhL2HofN10sW9/GEbw++m9eF/TeQavhL1zHHu+1/GQWlH0p5VDl bq6G0aplp5+yrr0O2laiLy75yT+yJu4to9qL82ZMHHG1WcdDxffXABUhq7Py5jFOrTzP 1rbcK8eD9yiV5uJMONRqAqaeW7aOQ/R6rTA+xoLfdU9yyOzXJdfcf4iVD7PMHemrg2sm 5mJk7NViMSE5LxUaSJhh2Dxd//93AczJFM2Grp3lwwziP1wMG246Ss/E8DkqGqEEm1pk Hmmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711113756; x=1711718556; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=zarOYxCOo5GM/MnqDwI9RHuDvosKvb8moWuxJ17HxLw=; b=NzrSHzfPz37JZMG3YPCLzklq65tSrIrBPLD4XODQXM+EHvMXzlGmIXvQSBR/xQ0d1p euGl5RvV+Eha5x4fmWxQi6oufFcsGi/+PS8odzV31H3WlYLxjyFRBwzf2nSz/hAwXlDE ByzioGa4S/1RveMMXlhsxNKLmFB0OvYOZTcy4SddMi2VQsNzbYZwgCm5xD8UuMF0KfsB HP3VnZcHnHOzP91w6+LKOBt9zyIpWYIC+PzzVjtBGwL6x08TJSiY0jfPDZV+sxrwtF2/ e3qPOuL+OP0sYyuvRT5puymYuZUmK2LerDF6gJl3BxFe5c8h5OLtTq+FUKtMB0NPXuJ1 yUVw== X-Forwarded-Encrypted: i=1; AJvYcCVhzEnEp49Td+hOLTa6opIQsGBjxaFRJv1UVLhisce4n8sqYWXzRfdE9xoVuJLxhEL9IfkBHQGgCf0I2El9gMAH0Z5+AMr0gcAMxcKE9fnw X-Gm-Message-State: AOJu0YxaHHQ87BNW4QU5ZNt5BzmhruxtRbzYea5msNBDI8Us4kKgkxVs ODvKURsPlDuxT8Bw0EJp/0ajN80uNjSR5mSyuprpMf4DOJ4cHqSukIv/5swQrjo= X-Google-Smtp-Source: AGHT+IFOFbvWvo7GMTukyJv89a/PooUGqfLkHCaYymF5MM/BdYjldHx0hPdF4ae4qIO3iRk/f3uQpA== X-Received: by 2002:a19:9116:0:b0:512:d5e4:1aa4 with SMTP id t22-20020a199116000000b00512d5e41aa4mr2133765lfd.60.1711113753386; Fri, 22 Mar 2024 06:22:33 -0700 (PDT) Received: from [127.0.1.1] ([79.114.172.194]) by smtp.gmail.com with ESMTPSA id m22-20020a170906721600b00a461e206c00sm1014176ejk.20.2024.03.22.06.22.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Mar 2024 06:22:32 -0700 (PDT) From: Abel Vesa Subject: [PATCH v3 0/2] drm/msm/dp: Rework the eDP/DP modes and add support for X1E80100 Date: Fri, 22 Mar 2024 15:22:21 +0200 Message-Id: <20240322-x1e80100-display-refactor-connector-v3-0-af14c29af665@linaro.org> MIME-Version: 1.0 X-B4-Tracking: v=1; b=H4sIAA2G/WUC/43NTQqDMBAF4KtI1k3JjD/VrnqP0kWcjBqQRJIii nj3Rlftrrt5w+N7m4gcLEdxzzYReLbRepdCfskEDdr1LK1JWaDCHBAauQDXCpSSxsZp1KsM3Gl 6+yDJO8fnxUBVVRY1ac5FkqbUscu58nylPNiYaus5OsPxPfxCIcJf/gxSyboixcCtKZkeo3U6+ KsPvTgGZvxG8T8UE9qaApqb6Yh1+4Pu+/4BWL5LkiwBAAA= To: Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , Marijn Suijten , David Airlie , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Kuogee Hsieh , Bjorn Andersson , Konrad Dybcio , Dmitry Baryshkov , Johan Hovold Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2044; i=abel.vesa@linaro.org; h=from:subject:message-id; bh=edVU3jeCTQ3gGUgwZ920jvPlnNbROZnf5Iox4JZ+SFg=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBl/YYOECUpQjcuKiiQsDAY//fbkHQz0j5YwGNFT YkbKSr8N/6JAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCZf2GDgAKCRAbX0TJAJUV VgFvD/9JHvp+vLlvhfZV9N12OsXJkgnbx/YBQ/QCk+Gnx2JKan+BKphy4bxGFAxjrP5wf7YOygz h0amEA1YCAbUi9h6lJYnVYieS7YXm1ZBI66s1gZYP3x5vXIbEzdZjc6ayXZwXgDz37OuDtif7F4 rxZYEHAxIwTqyv6AMr3k5gc32Raw0msPXhxpbIVNIBX9XtE0dyGFW8iu7bA6CPlPwz+nJAcNN1N RD6a62szt1gWxjHtWHdM7KadZ23TDHCZwZ0cKneOSrdjTsx+qo+ZqDlez+FZY8fD8JkHrSIGhnN HAnqZDC3OVhkj+Of2CiOfaIof9ShJACVm2WFW6miOFiTZmf/Mb3x5Lk6fkUWN5Fm/UhP3fmrkTS YdAY9OTqXqY8UgzVFfFvFh30t+Tw7DKyMVvU88OYvuxFCNzGoWyU/G0K78ujaDKrBNqpKWLxewX gBcHk/Q/Q2wEvl1tvmiS5X2RWwGzhn1aQi9/mNYdLyU3nzARtk6cJMBPo2B7oZltyyUJFFlpH9G IGk+tTcrobTt6zrr6dNpBTlo0GB36578MB14XFuvXHar6Um2YmDvx07vht1HbGFR1FeQ6yhWZWl m46W1tBRcLELNn9XtUUjs95M4TGNnu1uQFsW9HiGSdEBzriuu94O7tj7JNaxELNUm9LdM/kWAw0 TIF6CO6P5Bixzvw== X-Developer-Key: i=abel.vesa@linaro.org; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Since this new platform supports both DP and eDP, it's the perfect time to drop the dual compatible (eDP and DP) and figure out a different way to specify the mode. After some off-list discussion, one suggested way was to add a 'is-edp' property to the controller node, but that approach has been dropped due to bindings concerns. So now we lookup the panel node in DT and based on it's presence we can safely say if it is eDP or not. The PHY counterpart patchset is here: https://lore.kernel.org/all/20240220-x1e80100-phy-edp-compatible-refactor-v5-0-e8658adf5461@linaro.org/ Signed-off-by: Abel Vesa --- Changes in v3: - Dropped the bindings patch as this new solution doesn't involve bindings update. - Dropped R-b tags as this has been entirely reworked - Reworked to lookup the panel node in DT and set the is_edp and connector type based on panel node presence - Link to v2: https://lore.kernel.org/r/20240222-x1e80100-display-refactor-connector-v2-0-bd4197dfceab@linaro.org Changes in v2: - Added Dmitry's R-b tag to both driver patches - Dropped the if statement around assigning the is_edp in dp_display_probe, and fixed said assignment by using the connector type from match data instead. - Moved the qcom,x1e80100-dp compatible where it belongs - Re-worded the bindings commit message to follow Bjorn's suggestion - Dropped the RFC tag as the approach doesn't seem to be questioned anymore - Link to v1: https://lore.kernel.org/r/20240221-x1e80100-display-refactor-connector-v1-0-86c0e1ebd5ec@linaro.org --- Abel Vesa (2): drm/msm/dp: Add support for determining the eDP/DP mode from DT drm/msm/dp: Add support for the X1E80100 drivers/gpu/drm/msm/dp/dp_display.c | 52 ++++++++++++++++++++++++++++++++++--- 1 file changed, 48 insertions(+), 4 deletions(-) --- base-commit: e7528c088874326d3060a46f572252be43755a86 change-id: 20231219-x1e80100-display-refactor-connector-e1c66548cae3 Best regards,