mbox series

[v3,0/6] Add DSC support to DSI video panel

Message ID 20240403-msm-drm-dsc-dsi-video-upstream-v1-0-db5036443545@linaro.org (mailing list archive)
Headers show
Series Add DSC support to DSI video panel | expand

Message

Jun Nie April 3, 2024, 9:10 a.m. UTC
This is follow up update to Jonathan's patch set.

Changes vs V2:
- Rebase to latest mainline.
- Drop the INTF_CFG2_DATA_HCTL_EN change as it is handled in
    latest mainline code.
- Drop the bonded DSI patch as I do not have device to test it.
- Address comments from version 2.

Signed-off-by: Jun Nie <jun.nie@linaro.org>
---
Jonathan Marek (5):
      drm/msm/dpu: fix video mode DSC for DSI
      drm/msm/dsi: set video mode widebus enable bit when widebus is enabled
      drm/msm/dsi: set VIDEO_COMPRESSION_MODE_CTRL_WC (fix video mode DSC)
      drm/msm/dsi: add a comment to explain pkt_per_line encoding
      drm/msm/dsi: support DSC configurations with slice_per_pkt > 1

Jun Nie (1):
      drm/display: Add slice_per_pkt for dsc

 .../gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c   |  9 +++++
 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c        |  8 +++++
 drivers/gpu/drm/msm/dsi/dsi.xml.h                  |  1 +
 drivers/gpu/drm/msm/dsi/dsi_host.c                 | 42 +++++++++++-----------
 include/drm/display/drm_dsc.h                      |  4 +++
 5 files changed, 44 insertions(+), 20 deletions(-)
---
base-commit: b1e6ec0a0fd0252af046e542f91234cd6c30b2cb
change-id: 20240403-msm-drm-dsc-dsi-video-upstream-1156d110a53d

Best regards,

Comments

Dmitry Baryshkov April 3, 2024, 9:49 a.m. UTC | #1
On Wed, 3 Apr 2024 at 12:11, Jun Nie <jun.nie@linaro.org> wrote:
>
> This is follow up update to Jonathan's patch set.
>
> Changes vs V2:
> - Rebase to latest mainline.
> - Drop the INTF_CFG2_DATA_HCTL_EN change as it is handled in
>     latest mainline code.
> - Drop the bonded DSI patch as I do not have device to test it.
> - Address comments from version 2.

Which comments? "Adress comments" is the worst case of changelog.

Also, what do you consider as version 2? Jonathan Marek has only sent v1.

>
> Signed-off-by: Jun Nie <jun.nie@linaro.org>
> ---
> Jonathan Marek (5):
>       drm/msm/dpu: fix video mode DSC for DSI
>       drm/msm/dsi: set video mode widebus enable bit when widebus is enabled
>       drm/msm/dsi: set VIDEO_COMPRESSION_MODE_CTRL_WC (fix video mode DSC)
>       drm/msm/dsi: add a comment to explain pkt_per_line encoding
>       drm/msm/dsi: support DSC configurations with slice_per_pkt > 1
>
> Jun Nie (1):
>       drm/display: Add slice_per_pkt for dsc
>
>  .../gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c   |  9 +++++
>  drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c        |  8 +++++
>  drivers/gpu/drm/msm/dsi/dsi.xml.h                  |  1 +
>  drivers/gpu/drm/msm/dsi/dsi_host.c                 | 42 +++++++++++-----------
>  include/drm/display/drm_dsc.h                      |  4 +++
>  5 files changed, 44 insertions(+), 20 deletions(-)
> ---
> base-commit: b1e6ec0a0fd0252af046e542f91234cd6c30b2cb
> change-id: 20240403-msm-drm-dsc-dsi-video-upstream-1156d110a53d
>
> Best regards,
> --
> Jun Nie <jun.nie@linaro.org>
>


--
With best wishes
Dmitry
Jun Nie April 3, 2024, 2:27 p.m. UTC | #2
Dmitry Baryshkov <dmitry.baryshkov@linaro.org> 于2024年4月3日周三 17:49写道:
>
> On Wed, 3 Apr 2024 at 12:11, Jun Nie <jun.nie@linaro.org> wrote:
> >
> > This is follow up update to Jonathan's patch set.
> >
> > Changes vs V2:
> > - Rebase to latest mainline.
> > - Drop the INTF_CFG2_DATA_HCTL_EN change as it is handled in
> >     latest mainline code.
> > - Drop the bonded DSI patch as I do not have device to test it.
> > - Address comments from version 2.
>
> Which comments? "Adress comments" is the worst case of changelog.
Adopted. Will add more details in next version.
>
> Also, what do you consider as version 2? Jonathan Marek has only sent v1.

It's wired. I see v2 in patch title of below link. Just notice that
there is v1 in the link address.
https://patchwork.freedesktop.org/patch/567518/?series=126430&rev=1

>
> >
> > Signed-off-by: Jun Nie <jun.nie@linaro.org>
> > ---
> > Jonathan Marek (5):
> >       drm/msm/dpu: fix video mode DSC for DSI
> >       drm/msm/dsi: set video mode widebus enable bit when widebus is enabled
> >       drm/msm/dsi: set VIDEO_COMPRESSION_MODE_CTRL_WC (fix video mode DSC)
> >       drm/msm/dsi: add a comment to explain pkt_per_line encoding
> >       drm/msm/dsi: support DSC configurations with slice_per_pkt > 1
> >
> > Jun Nie (1):
> >       drm/display: Add slice_per_pkt for dsc
> >
> >  .../gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c   |  9 +++++
> >  drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c        |  8 +++++
> >  drivers/gpu/drm/msm/dsi/dsi.xml.h                  |  1 +
> >  drivers/gpu/drm/msm/dsi/dsi_host.c                 | 42 +++++++++++-----------
> >  include/drm/display/drm_dsc.h                      |  4 +++
> >  5 files changed, 44 insertions(+), 20 deletions(-)
> > ---
> > base-commit: b1e6ec0a0fd0252af046e542f91234cd6c30b2cb
> > change-id: 20240403-msm-drm-dsc-dsi-video-upstream-1156d110a53d
> >
> > Best regards,
> > --
> > Jun Nie <jun.nie@linaro.org>
> >
>
>
> --
> With best wishes
> Dmitry
Dmitry Baryshkov April 3, 2024, 2:32 p.m. UTC | #3
On Wed, 3 Apr 2024 at 17:27, Jun Nie <jun.nie@linaro.org> wrote:
>
> Dmitry Baryshkov <dmitry.baryshkov@linaro.org> 于2024年4月3日周三 17:49写道:
> >
> > On Wed, 3 Apr 2024 at 12:11, Jun Nie <jun.nie@linaro.org> wrote:
> > >
> > > This is follow up update to Jonathan's patch set.
> > >
> > > Changes vs V2:
> > > - Rebase to latest mainline.
> > > - Drop the INTF_CFG2_DATA_HCTL_EN change as it is handled in
> > >     latest mainline code.
> > > - Drop the bonded DSI patch as I do not have device to test it.
> > > - Address comments from version 2.
> >
> > Which comments? "Adress comments" is the worst case of changelog.
> Adopted. Will add more details in next version.
> >
> > Also, what do you consider as version 2? Jonathan Marek has only sent v1.
>
> It's wired. I see v2 in patch title of below link. Just notice that
> there is v1 in the link address.
> https://patchwork.freedesktop.org/patch/567518/?series=126430&rev=1
>

Ack, I didn't remember that there was v2. Please excuse me then.