| Message ID | 20240415-anx7625-defer-log-no-dsi-host-v3-0-619a28148e5c@collabora.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | drm: Switch from dev_err to dev_err_probe for missing DSI host error path | expand |
On Mon, 15 Apr 2024 17:49:28 -0400, Nícolas F. R. A. Prado wrote: > This series changes every occurrence of the following pattern: > > dsi_host = of_find_mipi_dsi_host_by_node(dsi); > if (!dsi_host) { > dev_err(dev, "failed to find dsi host\n"); > return -EPROBE_DEFER; > } > > [...] Applied, thanks! [1/9] drm/bridge: anx7625: Don't log an error when DSI host can't be found https://cgit.freedesktop.org/drm/drm-misc/commit/?id=ef4a9204d594 [2/9] drm/bridge: icn6211: Don't log an error when DSI host can't be found https://cgit.freedesktop.org/drm/drm-misc/commit/?id=275fafe58faa [3/9] drm/bridge: lt8912b: Don't log an error when DSI host can't be found https://cgit.freedesktop.org/drm/drm-misc/commit/?id=b3b4695ff47c [4/9] drm/bridge: lt9611: Don't log an error when DSI host can't be found https://cgit.freedesktop.org/drm/drm-misc/commit/?id=cd0a2c6a081f [5/9] drm/bridge: lt9611uxc: Don't log an error when DSI host can't be found https://cgit.freedesktop.org/drm/drm-misc/commit/?id=6d9e877cde7e [6/9] drm/bridge: tc358775: Don't log an error when DSI host can't be found https://cgit.freedesktop.org/drm/drm-misc/commit/?id=272377aa0e3d [7/9] drm/bridge: dpc3433: Don't log an error when DSI host can't be found https://cgit.freedesktop.org/drm/drm-misc/commit/?id=24f4f575214d [8/9] drm/panel: novatek-nt35950: Don't log an error when DSI host can't be found https://cgit.freedesktop.org/drm/drm-misc/commit/?id=5ff5505b9a2d [9/9] drm/panel: truly-nt35597: Don't log an error when DSI host can't be found https://cgit.freedesktop.org/drm/drm-misc/commit/?id=c1e4d3a6de48 Rob
This series changes every occurrence of the following pattern: dsi_host = of_find_mipi_dsi_host_by_node(dsi); if (!dsi_host) { dev_err(dev, "failed to find dsi host\n"); return -EPROBE_DEFER; } into dsi_host = of_find_mipi_dsi_host_by_node(dsi); if (!dsi_host) return dev_err_probe(dev, -EPROBE_DEFER, "failed to find dsi host\n"); This registers the defer probe reason (so it can later be printed by the driver core or checked on demand through the devices_deferred file in debugfs) and prevents errors to be spammed in the kernel log every time the driver retries to probe, unnecessarily alerting userspace about something that is a normal part of the boot process. I have omitted a Fixes: tag in the last patch, for the truly-nt35597 panel, because it predates the dev_err_probe() helper. Changes in v3: - Added trailers - Rebased on next-20240415 - Link to v2: https://lore.kernel.org/r/20240229-anx7625-defer-log-no-dsi-host-v2-0-00506941049a@collabora.com Changes in v2: - Added patches 2 onwards to fix all occurences of this pattern instead of just for the anx7625 driver - Link to v1: https://lore.kernel.org/r/20240226-anx7625-defer-log-no-dsi-host-v1-1-242b1af31884@collabora.com --- Nícolas F. R. A. Prado (9): drm/bridge: anx7625: Don't log an error when DSI host can't be found drm/bridge: icn6211: Don't log an error when DSI host can't be found drm/bridge: lt8912b: Don't log an error when DSI host can't be found drm/bridge: lt9611: Don't log an error when DSI host can't be found drm/bridge: lt9611uxc: Don't log an error when DSI host can't be found drm/bridge: tc358775: Don't log an error when DSI host can't be found drm/bridge: dpc3433: Don't log an error when DSI host can't be found drm/panel: novatek-nt35950: Don't log an error when DSI host can't be found drm/panel: truly-nt35597: Don't log an error when DSI host can't be found drivers/gpu/drm/bridge/analogix/anx7625.c | 6 ++---- drivers/gpu/drm/bridge/chipone-icn6211.c | 6 ++---- drivers/gpu/drm/bridge/lontium-lt8912b.c | 6 ++---- drivers/gpu/drm/bridge/lontium-lt9611.c | 6 ++---- drivers/gpu/drm/bridge/lontium-lt9611uxc.c | 6 ++---- drivers/gpu/drm/bridge/tc358775.c | 6 ++---- drivers/gpu/drm/bridge/ti-dlpc3433.c | 17 +++++++++-------- drivers/gpu/drm/panel/panel-novatek-nt35950.c | 6 ++---- drivers/gpu/drm/panel/panel-truly-nt35597.c | 6 ++---- 9 files changed, 25 insertions(+), 40 deletions(-) --- base-commit: 6bd343537461b57f3efe5dfc5fc193a232dfef1e change-id: 20240226-anx7625-defer-log-no-dsi-host-c3f9ccbcb287 Best regards,