| Message ID | 20241016-upstream-v6-v6-0-4d93a0c46de1@ite.com.tw (mailing list archive) |
|---|---|
| Headers | show |
| Series | drm/bridge: it6505: fix HDCP CTS fail items and add MCCS support | expand |
Hi Hermes, On Wed, Oct 16, 2024 at 3:54 AM Hermes Wu via B4 Relay <devnull+Hermes.wu.ite.com.tw@kernel.org> wrote: > > This is a v6 patch-set. > > There are lots of failure items while running HDCP CTS using UNIGRAF DPR-100. > In Order to fix those failures, HDCP flow needs to be changed. > > The DisplayPort AUX protocol supports I2C transport. > In Order to support MCCS via the aux channel, the aux-i2c operation is added. > > v5->v6: > -keep the commit message wrapped at 72-75 chars. > -[10/10] fix return variable being used without being initialized > > v4->v5: > -add more messages for changes. > -[2/10] modified AUX transfer data size judgment. > change for-loop to do-while. > -[7/10] change for-loop to do-while. > -[9/10] change wait timer with timer_after() > > links: > https://lore.kernel.org/all/20240926074755.22176-4-Hermes.Wu@ite.com.tw/ > https://lore.kernel.org/all/20240926075134.22394-1-Hermes.Wu@ite.com.tw/ > > v3->v4: > -split changes into patches. > > v2->v3: > -split aux read KSV function to a patch. > -[1/3] new in v3 > -[2/3] add description of patch > > v1->v2: > - ignored. > > Hermes Wu (10): > drm/bridge: it6505: Change definition of AUX_FIFO_MAX_SIZE > drm/bridge: it6505: improve AUX operation for edid read > drm/bridge: it6505: add AUX operation for HDCP KSV list read > drm/bridge: it6505: Change definition MAX_HDCP_DOWN_STREAM_COUNT > drm/bridge: it6505: fix HDCP Bstatus check > drm/bridge: it6505: fix HDCP encryption when R0 ready > drm/bridge: it6505: fix HDCP CTS KSV list read with UNIGRAF DPR-100. > drm/bridge: it6505: fix HDCP CTS compare V matching > drm/bridge: it6505: fix HDCP CTS KSV list wait timer > drm/bridge: it6505: add I2C functionality on AUX > > Change-Id: Iad0c056d72abf2655081357cf40c3b0d3df916b5 > Signed-off-by: Hermes Wu <Hermes.wu@ite.com.tw> > --- > Hermes Wu (10): > drm/bridge: it6505: Change definition of AUX_FIFO_MAX_SIZE > drm/bridge: it6505: improve AUX operation for edid read > drm/bridge: it6505: add AUX operation for HDCP KSV list read > drm/bridge: it6505: Change definition MAX_HDCP_DOWN_STREAM_COUNT > drm/bridge: it6505: fix HDCP Bstatus check > drm/bridge: it6505: fix HDCP encryption when R0 ready > drm/bridge: it6505: fix HDCP CTS KSV list read with UNIGRAF DPR-100. > drm/bridge: it6505: fix HDCP CTS compare V matching > drm/bridge: it6505: fix HDCP CTS KSV list wait timer > drm/bridge: it6505: add I2C functionality on AUX > > drivers/gpu/drm/bridge/ite-it6505.c | 334 ++++++++++++++++++++++++++++++------ > 1 file changed, 277 insertions(+), 57 deletions(-) > --- > base-commit: b8128f7815ff135f0333c1b46dcdf1543c41b860 > change-id: 20241015-upstream-v6-9f4b015fecf7 > > Best regards, > -- > Hermes Wu <Hermes.wu@ite.com.tw> > > I'm not sure if this requires a re-spin, but you are supposed to collect the reviewed-by tags you received when you send out a new version. i.e., put the "Reviewed-by:" lines you received before your "Signed-off-by:" line. Regards, Pin-yen
> > >-----Original Message----- >From: Pin-yen Lin <treapking@chromium.org> >Sent: Thursday, October 17, 2024 5:52 AM >To: Hermes Wu (吳佳宏) <Hermes.Wu@ite.com.tw> >Cc: Andrzej Hajda <andrzej.hajda@intel.com>; Neil Armstrong <neil.armstrong@linaro.org>; Robert Foss <rfoss@kernel.org>; Laurent Pinchart <Laurent.pinchart@ideasonboard.com>; Jonas Karlman <jonas@kwiboo.se>; Jernej Skrabec <jernej.skrabec@gmail.com>; Maarten Lankhorst <maarten.lankhorst@linux.intel.com>; Maxime Ripard <mripard@kernel.org>; Thomas Zimmermann <tzimmermann@suse.de>; David Airlie <airlied@gmail.com>; Simona Vetter <simona@ffwll.ch>; AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>; dri-devel@lists.freedesktop.org; linux-kernel@vger.kernel.org; Kenneth Hung (洪家倫) <Kenneth.Hung@ite.com.tw>; Pet Weng (翁玉芬) <Pet.Weng@ite.com.tw> >Subject: Re: [PATCH v6 00/10] drm/bridge: it6505: fix HDCP CTS fail items and add MCCS support > >Hi Hermes, > >On Wed, Oct 16, 2024 at 3:54 AM Hermes Wu via B4 Relay <devnull+Hermes.wu.ite.com.tw@kernel.org> wrote: >> >> This is a v6 patch-set. >> >> There are lots of failure items while running HDCP CTS using UNIGRAF DPR-100. >> In Order to fix those failures, HDCP flow needs to be changed. >> >> The DisplayPort AUX protocol supports I2C transport. >> In Order to support MCCS via the aux channel, the aux-i2c operation is added. >> >> v5->v6: >> -keep the commit message wrapped at 72-75 chars. >> -[10/10] fix return variable being used without being >> initialized >> >> v4->v5: >> -add more messages for changes. >> -[2/10] modified AUX transfer data size judgment. >> change for-loop to do-while. >> -[7/10] change for-loop to do-while. >> -[9/10] change wait timer with timer_after() >> >> links: >> https://urldefense.com/v3/__https://lore.kernel.org/all/20240926074755.22176-4-Hermes.Wu@ite.com.tw/__;!!HtnLE8A!H06km5WNa8VgoR25MvWuNAGYuJGScCXQx0tQwni_NPHKwOqT4hNpaCrFZPPMVKeqBXXHTRoGj1C2pZazumE8vA$ >> >> https://urldefense.com/v3/__https://lore.kernel.org/all/20240926075134 >> .22394-1-Hermes.Wu@ite.com.tw/__;!!HtnLE8A!H06km5WNa8VgoR25MvWuNAGYuJG >> ScCXQx0tQwni_NPHKwOqT4hNpaCrFZPPMVKeqBXXHTRoGj1C2pZb7YFr4mw$ >> >> v3->v4: >> -split changes into patches. >> >> v2->v3: >> -split aux read KSV function to a patch. >> -[1/3] new in v3 >> -[2/3] add description of patch >> >> v1->v2: >> - ignored. >> >> Hermes Wu (10): >> drm/bridge: it6505: Change definition of AUX_FIFO_MAX_SIZE >> drm/bridge: it6505: improve AUX operation for edid read >> drm/bridge: it6505: add AUX operation for HDCP KSV list read >> drm/bridge: it6505: Change definition MAX_HDCP_DOWN_STREAM_COUNT >> drm/bridge: it6505: fix HDCP Bstatus check >> drm/bridge: it6505: fix HDCP encryption when R0 ready >> drm/bridge: it6505: fix HDCP CTS KSV list read with UNIGRAF DPR-100. >> drm/bridge: it6505: fix HDCP CTS compare V matching >> drm/bridge: it6505: fix HDCP CTS KSV list wait timer >> drm/bridge: it6505: add I2C functionality on AUX >> >> Change-Id: Iad0c056d72abf2655081357cf40c3b0d3df916b5 >> Signed-off-by: Hermes Wu <Hermes.wu@ite.com.tw> >> --- >> Hermes Wu (10): >> drm/bridge: it6505: Change definition of AUX_FIFO_MAX_SIZE >> drm/bridge: it6505: improve AUX operation for edid read >> drm/bridge: it6505: add AUX operation for HDCP KSV list read >> drm/bridge: it6505: Change definition MAX_HDCP_DOWN_STREAM_COUNT >> drm/bridge: it6505: fix HDCP Bstatus check >> drm/bridge: it6505: fix HDCP encryption when R0 ready >> drm/bridge: it6505: fix HDCP CTS KSV list read with UNIGRAF DPR-100. >> drm/bridge: it6505: fix HDCP CTS compare V matching >> drm/bridge: it6505: fix HDCP CTS KSV list wait timer >> drm/bridge: it6505: add I2C functionality on AUX >> >> drivers/gpu/drm/bridge/ite-it6505.c | 334 >> ++++++++++++++++++++++++++++++------ >> 1 file changed, 277 insertions(+), 57 deletions(-) >> --- >> base-commit: b8128f7815ff135f0333c1b46dcdf1543c41b860 >> change-id: 20241015-upstream-v6-9f4b015fecf7 >> >> Best regards, >> -- >> Hermes Wu <Hermes.wu@ite.com.tw> >> >> > >I'm not sure if this requires a re-spin, but you are supposed to collect the reviewed-by tags you received when you send out a new version. i.e., put the "Reviewed-by:" lines you received before your "Signed-off-by:" line. only cover-letter or all patches? need "RESEND" for same v6 patch header? >Regards, >Pin-yen BR, Hermes
Hi, On Wed, Oct 16, 2024 at 10:10 PM <Hermes.Wu@ite.com.tw> wrote: > > > > > > >-----Original Message----- > >From: Pin-yen Lin <treapking@chromium.org> > >Sent: Thursday, October 17, 2024 5:52 AM > >To: Hermes Wu (吳佳宏) <Hermes.Wu@ite.com.tw> > >Cc: Andrzej Hajda <andrzej.hajda@intel.com>; Neil Armstrong <neil.armstrong@linaro.org>; Robert Foss <rfoss@kernel.org>; Laurent Pinchart <Laurent.pinchart@ideasonboard.com>; Jonas Karlman <jonas@kwiboo.se>; Jernej Skrabec <jernej.skrabec@gmail.com>; Maarten Lankhorst <maarten.lankhorst@linux.intel.com>; Maxime Ripard <mripard@kernel.org>; Thomas Zimmermann <tzimmermann@suse.de>; David Airlie <airlied@gmail.com>; Simona Vetter <simona@ffwll.ch>; AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>; dri-devel@lists.freedesktop.org; linux-kernel@vger.kernel.org; Kenneth Hung (洪家倫) <Kenneth.Hung@ite.com.tw>; Pet Weng (翁玉芬) <Pet.Weng@ite.com.tw> > >Subject: Re: [PATCH v6 00/10] drm/bridge: it6505: fix HDCP CTS fail items and add MCCS support > > > >Hi Hermes, > > > >On Wed, Oct 16, 2024 at 3:54 AM Hermes Wu via B4 Relay <devnull+Hermes.wu.ite.com.tw@kernel.org> wrote: > >> > >> This is a v6 patch-set. > >> > >> There are lots of failure items while running HDCP CTS using UNIGRAF DPR-100. > >> In Order to fix those failures, HDCP flow needs to be changed. > >> > >> The DisplayPort AUX protocol supports I2C transport. > >> In Order to support MCCS via the aux channel, the aux-i2c operation is added. > >> > >> v5->v6: > >> -keep the commit message wrapped at 72-75 chars. > >> -[10/10] fix return variable being used without being > >> initialized > >> > >> v4->v5: > >> -add more messages for changes. > >> -[2/10] modified AUX transfer data size judgment. > >> change for-loop to do-while. > >> -[7/10] change for-loop to do-while. > >> -[9/10] change wait timer with timer_after() > >> > >> links: > >> https://urldefense.com/v3/__https://lore.kernel.org/all/20240926074755.22176-4-Hermes.Wu@ite.com.tw/__;!!HtnLE8A!H06km5WNa8VgoR25MvWuNAGYuJGScCXQx0tQwni_NPHKwOqT4hNpaCrFZPPMVKeqBXXHTRoGj1C2pZazumE8vA$ > >> > >> https://urldefense.com/v3/__https://lore.kernel.org/all/20240926075134 > >> .22394-1-Hermes.Wu@ite.com.tw/__;!!HtnLE8A!H06km5WNa8VgoR25MvWuNAGYuJG > >> ScCXQx0tQwni_NPHKwOqT4hNpaCrFZPPMVKeqBXXHTRoGj1C2pZb7YFr4mw$ > >> > >> v3->v4: > >> -split changes into patches. > >> > >> v2->v3: > >> -split aux read KSV function to a patch. > >> -[1/3] new in v3 > >> -[2/3] add description of patch > >> > >> v1->v2: > >> - ignored. > >> > >> Hermes Wu (10): > >> drm/bridge: it6505: Change definition of AUX_FIFO_MAX_SIZE > >> drm/bridge: it6505: improve AUX operation for edid read > >> drm/bridge: it6505: add AUX operation for HDCP KSV list read > >> drm/bridge: it6505: Change definition MAX_HDCP_DOWN_STREAM_COUNT > >> drm/bridge: it6505: fix HDCP Bstatus check > >> drm/bridge: it6505: fix HDCP encryption when R0 ready > >> drm/bridge: it6505: fix HDCP CTS KSV list read with UNIGRAF DPR-100. > >> drm/bridge: it6505: fix HDCP CTS compare V matching > >> drm/bridge: it6505: fix HDCP CTS KSV list wait timer > >> drm/bridge: it6505: add I2C functionality on AUX > >> > >> Change-Id: Iad0c056d72abf2655081357cf40c3b0d3df916b5 > >> Signed-off-by: Hermes Wu <Hermes.wu@ite.com.tw> > >> --- > >> Hermes Wu (10): > >> drm/bridge: it6505: Change definition of AUX_FIFO_MAX_SIZE > >> drm/bridge: it6505: improve AUX operation for edid read > >> drm/bridge: it6505: add AUX operation for HDCP KSV list read > >> drm/bridge: it6505: Change definition MAX_HDCP_DOWN_STREAM_COUNT > >> drm/bridge: it6505: fix HDCP Bstatus check > >> drm/bridge: it6505: fix HDCP encryption when R0 ready > >> drm/bridge: it6505: fix HDCP CTS KSV list read with UNIGRAF DPR-100. > >> drm/bridge: it6505: fix HDCP CTS compare V matching > >> drm/bridge: it6505: fix HDCP CTS KSV list wait timer > >> drm/bridge: it6505: add I2C functionality on AUX > >> > >> drivers/gpu/drm/bridge/ite-it6505.c | 334 > >> ++++++++++++++++++++++++++++++------ > >> 1 file changed, 277 insertions(+), 57 deletions(-) > >> --- > >> base-commit: b8128f7815ff135f0333c1b46dcdf1543c41b860 > >> change-id: 20241015-upstream-v6-9f4b015fecf7 > >> > >> Best regards, > >> -- > >> Hermes Wu <Hermes.wu@ite.com.tw> > >> > >> > > > >I'm not sure if this requires a re-spin, but you are supposed to collect the reviewed-by tags you received when you send out a new version. i.e., put the "Reviewed-by:" lines you received before your "Signed-off-by:" line. > > only cover-letter or all patches? need "RESEND" for same v6 patch header? You should add the review tags to the individual patches that have not changed since the previous review. For this series, I think you can wait a few days and collect feedbacks from the community first. > > >Regards, > >Pin-yen > > > > BR, > Hermes Pin-yen
Hi, >Hi, > >On Wed, Oct 16, 2024 at 10:10 PM <Hermes.Wu@ite.com.tw> wrote: >> >> > >> > >> >-----Original Message----- >> >From: Pin-yen Lin <treapking@chromium.org> >> >Sent: Thursday, October 17, 2024 5:52 AM >> >To: Hermes Wu (吳佳宏) <Hermes.Wu@ite.com.tw> >> >Cc: Andrzej Hajda <andrzej.hajda@intel.com>; Neil Armstrong >> ><neil.armstrong@linaro.org>; Robert Foss <rfoss@kernel.org>; Laurent >> >Pinchart <Laurent.pinchart@ideasonboard.com>; Jonas Karlman >> ><jonas@kwiboo.se>; Jernej Skrabec <jernej.skrabec@gmail.com>; Maarten >> >Lankhorst <maarten.lankhorst@linux.intel.com>; Maxime Ripard >> ><mripard@kernel.org>; Thomas Zimmermann <tzimmermann@suse.de>; David >> >Airlie <airlied@gmail.com>; Simona Vetter <simona@ffwll.ch>; >> >AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>; >> >dri-devel@lists.freedesktop.org; linux-kernel@vger.kernel.org; >> >Kenneth Hung (洪家倫) <Kenneth.Hung@ite.com.tw>; Pet Weng (翁玉芬) >> ><Pet.Weng@ite.com.tw> >> >Subject: Re: [PATCH v6 00/10] drm/bridge: it6505: fix HDCP CTS fail >> >items and add MCCS support >> > >> >Hi Hermes, >> > >> >On Wed, Oct 16, 2024 at 3:54 AM Hermes Wu via B4 Relay <devnull+Hermes.wu.ite.com.tw@kernel.org> wrote: >> >> >> >> This is a v6 patch-set. >> >> >> >> There are lots of failure items while running HDCP CTS using UNIGRAF DPR-100. >> >> In Order to fix those failures, HDCP flow needs to be changed. >> >> >> >> The DisplayPort AUX protocol supports I2C transport. >> >> In Order to support MCCS via the aux channel, the aux-i2c operation is added. >> >> >> >> v5->v6: >> >> -keep the commit message wrapped at 72-75 chars. >> >> -[10/10] fix return variable being used without being >> >> initialized >> >> >> >> v4->v5: >> >> -add more messages for changes. >> >> -[2/10] modified AUX transfer data size judgment. >> >> change for-loop to do-while. >> >> -[7/10] change for-loop to do-while. >> >> -[9/10] change wait timer with timer_after() >> >> >> >> links: >> >> >> >> https://urldefense.com/v3/__https://lore.kernel.org/all/20240926074 >> >> 755.22176-4-Hermes.Wu@ite.com.tw/__;!!HtnLE8A!H06km5WNa8VgoR25MvWuN >> >> AGYuJGScCXQx0tQwni_NPHKwOqT4hNpaCrFZPPMVKeqBXXHTRoGj1C2pZazumE8vA$ >> >> >> >> https://urldefense.com/v3/__https://lore.kernel.org/all/20240926075 >> >> 134 >> >> .22394-1-Hermes.Wu@ite.com.tw/__;!!HtnLE8A!H06km5WNa8VgoR25MvWuNAGY >> >> uJG ScCXQx0tQwni_NPHKwOqT4hNpaCrFZPPMVKeqBXXHTRoGj1C2pZb7YFr4mw$ >> >> >> >> v3->v4: >> >> -split changes into patches. >> >> >> >> v2->v3: >> >> -split aux read KSV function to a patch. >> >> -[1/3] new in v3 >> >> -[2/3] add description of patch >> >> >> >> v1->v2: >> >> - ignored. >> >> >> >> Hermes Wu (10): >> >> drm/bridge: it6505: Change definition of AUX_FIFO_MAX_SIZE >> >> drm/bridge: it6505: improve AUX operation for edid read >> >> drm/bridge: it6505: add AUX operation for HDCP KSV list read >> >> drm/bridge: it6505: Change definition MAX_HDCP_DOWN_STREAM_COUNT >> >> drm/bridge: it6505: fix HDCP Bstatus check >> >> drm/bridge: it6505: fix HDCP encryption when R0 ready >> >> drm/bridge: it6505: fix HDCP CTS KSV list read with UNIGRAF DPR-100. >> >> drm/bridge: it6505: fix HDCP CTS compare V matching >> >> drm/bridge: it6505: fix HDCP CTS KSV list wait timer >> >> drm/bridge: it6505: add I2C functionality on AUX >> >> >> >> Change-Id: Iad0c056d72abf2655081357cf40c3b0d3df916b5 >> >> Signed-off-by: Hermes Wu <Hermes.wu@ite.com.tw> >> >> --- >> >> Hermes Wu (10): >> >> drm/bridge: it6505: Change definition of AUX_FIFO_MAX_SIZE >> >> drm/bridge: it6505: improve AUX operation for edid read >> >> drm/bridge: it6505: add AUX operation for HDCP KSV list read >> >> drm/bridge: it6505: Change definition MAX_HDCP_DOWN_STREAM_COUNT >> >> drm/bridge: it6505: fix HDCP Bstatus check >> >> drm/bridge: it6505: fix HDCP encryption when R0 ready >> >> drm/bridge: it6505: fix HDCP CTS KSV list read with UNIGRAF DPR-100. >> >> drm/bridge: it6505: fix HDCP CTS compare V matching >> >> drm/bridge: it6505: fix HDCP CTS KSV list wait timer >> >> drm/bridge: it6505: add I2C functionality on AUX >> >> >> >> drivers/gpu/drm/bridge/ite-it6505.c | 334 >> >> ++++++++++++++++++++++++++++++------ >> >> 1 file changed, 277 insertions(+), 57 deletions(-) >> >> --- >> >> base-commit: b8128f7815ff135f0333c1b46dcdf1543c41b860 >> >> change-id: 20241015-upstream-v6-9f4b015fecf7 >> >> >> >> Best regards, >> >> -- >> >> Hermes Wu <Hermes.wu@ite.com.tw> >> >> >> >> >> > >> >I'm not sure if this requires a re-spin, but you are supposed to collect the reviewed-by tags you received when you send out a new version. i.e., put the "Reviewed-by:" lines you received before your "Signed-off-by:" line. >> >> only cover-letter or all patches? need "RESEND" for same v6 patch header? > >You should add the review tags to the individual patches that have not changed since the previous review. For this series, I think you can wait a few days and collect feedbacks from the community first. >> ok, thanks. >> >Regards, >> >Pin-yen >> >> >> >> BR, >> Hermes > >Pin-yen > BR, Hermes
On Wed, Oct 16, 2024 at 03:54:12PM +0800, Hermes Wu via B4 Relay wrote: > This is a v6 patch-set. > > There are lots of failure items while running HDCP CTS using UNIGRAF DPR-100. > In Order to fix those failures, HDCP flow needs to be changed. > > The DisplayPort AUX protocol supports I2C transport. > In Order to support MCCS via the aux channel, the aux-i2c operation is added. > > v5->v6: > -keep the commit message wrapped at 72-75 chars. > -[10/10] fix return variable being used without being initialized I have reviewed the patches that I could review, but I lack deep HDCP knowledge, so I can not review patches 5, 6, 8, 9. Hopefully somebody else can step up. > > v4->v5: > -add more messages for changes. > -[2/10] modified AUX transfer data size judgment. > change for-loop to do-while. > -[7/10] change for-loop to do-while. > -[9/10] change wait timer with timer_after() > > links: > https://lore.kernel.org/all/20240926074755.22176-4-Hermes.Wu@ite.com.tw/ > https://lore.kernel.org/all/20240926075134.22394-1-Hermes.Wu@ite.com.tw/ > > v3->v4: > -split changes into patches. > > v2->v3: > -split aux read KSV function to a patch. > -[1/3] new in v3 > -[2/3] add description of patch > > v1->v2: > - ignored. > > Hermes Wu (10): > drm/bridge: it6505: Change definition of AUX_FIFO_MAX_SIZE > drm/bridge: it6505: improve AUX operation for edid read > drm/bridge: it6505: add AUX operation for HDCP KSV list read > drm/bridge: it6505: Change definition MAX_HDCP_DOWN_STREAM_COUNT > drm/bridge: it6505: fix HDCP Bstatus check > drm/bridge: it6505: fix HDCP encryption when R0 ready > drm/bridge: it6505: fix HDCP CTS KSV list read with UNIGRAF DPR-100. > drm/bridge: it6505: fix HDCP CTS compare V matching > drm/bridge: it6505: fix HDCP CTS KSV list wait timer > drm/bridge: it6505: add I2C functionality on AUX > > Change-Id: Iad0c056d72abf2655081357cf40c3b0d3df916b5 > Signed-off-by: Hermes Wu <Hermes.wu@ite.com.tw> > --- > Hermes Wu (10): > drm/bridge: it6505: Change definition of AUX_FIFO_MAX_SIZE > drm/bridge: it6505: improve AUX operation for edid read > drm/bridge: it6505: add AUX operation for HDCP KSV list read > drm/bridge: it6505: Change definition MAX_HDCP_DOWN_STREAM_COUNT > drm/bridge: it6505: fix HDCP Bstatus check > drm/bridge: it6505: fix HDCP encryption when R0 ready > drm/bridge: it6505: fix HDCP CTS KSV list read with UNIGRAF DPR-100. > drm/bridge: it6505: fix HDCP CTS compare V matching > drm/bridge: it6505: fix HDCP CTS KSV list wait timer > drm/bridge: it6505: add I2C functionality on AUX > > drivers/gpu/drm/bridge/ite-it6505.c | 334 ++++++++++++++++++++++++++++++------ > 1 file changed, 277 insertions(+), 57 deletions(-) > --- > base-commit: b8128f7815ff135f0333c1b46dcdf1543c41b860 > change-id: 20241015-upstream-v6-9f4b015fecf7 > > Best regards, > -- > Hermes Wu <Hermes.wu@ite.com.tw> > >
hi >-----Original Message----- >From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> >Sent: Sunday, October 20, 2024 9:57 PM >To: Hermes Wu (吳佳宏) <Hermes.Wu@ite.com.tw> >Cc: Andrzej Hajda <andrzej.hajda@intel.com>; Neil Armstrong <neil.armstrong@linaro.org>; Robert Foss <rfoss@kernel.org>; Laurent Pinchart <Laurent.pinchart@ideasonboard.com>; Jonas Karlman <jonas@kwiboo.se>; Jernej Skrabec <jernej.skrabec@gmail.com>; Maarten Lankhorst <maarten.lankhorst@linux.intel.com>; Maxime Ripard <mripard@kernel.org>; Thomas Zimmermann <tzimmermann@suse.de>; David Airlie <airlied@gmail.com>; Simona Vetter <simona@ffwll.ch>; AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>; Pin-yen Lin <treapking@chromium.org>; dri-devel@lists.freedesktop.org; linux-kernel@vger.kernel.org; Kenneth Hung (洪家倫) <Kenneth.Hung@ite.com.tw>; Pet Weng (翁玉芬) <Pet.Weng@ite.com.tw> >Subject: Re: [PATCH v6 00/10] drm/bridge: it6505: fix HDCP CTS fail items and add MCCS support > >On Wed, Oct 16, 2024 at 03:54:12PM +0800, Hermes Wu via B4 Relay wrote: >> This is a v6 patch-set. >> >> There are lots of failure items while running HDCP CTS using UNIGRAF DPR-100. >> In Order to fix those failures, HDCP flow needs to be changed. >> >> The DisplayPort AUX protocol supports I2C transport. >> In Order to support MCCS via the aux channel, the aux-i2c operation is added. >> >> v5->v6: >> -keep the commit message wrapped at 72-75 chars. >> -[10/10] fix return variable being used without being initialized > >I have reviewed the patches that I could review, but I lack deep HDCP knowledge, so I can not review patches 5, 6, 8, 9. Hopefully somebody else can step up. > thank you. >> v4->v5: >> -add more messages for changes. >> -[2/10] modified AUX transfer data size judgment. >> change for-loop to do-while. >> -[7/10] change for-loop to do-while. >> -[9/10] change wait timer with timer_after() >> >> links: >> https://urldefense.com/v3/__https://lore.kernel.org/all/20240926074755.22176-4-Hermes.Wu@ite.com.tw/__;!!HtnLE8A!HOwy05_egTbj5U7vrjfPhJC21VK_Jxll8UWNOcGEzNSDxnKQjE6QSLhamd-IROE-SxGOrzFS_SLfixtORjLLBTjdL3SV$ >> >> https://urldefense.com/v3/__https://lore.kernel.org/all/20240926075134 >> .22394-1-Hermes.Wu@ite.com.tw/__;!!HtnLE8A!HOwy05_egTbj5U7vrjfPhJC21VK >> _Jxll8UWNOcGEzNSDxnKQjE6QSLhamd-IROE-SxGOrzFS_SLfixtORjLLBTc_Yg8R$ >> >> v3->v4: >> -split changes into patches. >> >> v2->v3: >> -split aux read KSV function to a patch. >> -[1/3] new in v3 >> -[2/3] add description of patch >> >> v1->v2: >> - ignored. >> >> Hermes Wu (10): >> drm/bridge: it6505: Change definition of AUX_FIFO_MAX_SIZE >> drm/bridge: it6505: improve AUX operation for edid read >> drm/bridge: it6505: add AUX operation for HDCP KSV list read >> drm/bridge: it6505: Change definition MAX_HDCP_DOWN_STREAM_COUNT >> drm/bridge: it6505: fix HDCP Bstatus check >> drm/bridge: it6505: fix HDCP encryption when R0 ready >> drm/bridge: it6505: fix HDCP CTS KSV list read with UNIGRAF DPR-100. >> drm/bridge: it6505: fix HDCP CTS compare V matching >> drm/bridge: it6505: fix HDCP CTS KSV list wait timer >> drm/bridge: it6505: add I2C functionality on AUX >> >> Change-Id: Iad0c056d72abf2655081357cf40c3b0d3df916b5 >> Signed-off-by: Hermes Wu <Hermes.wu@ite.com.tw> >> --- >> Hermes Wu (10): >> drm/bridge: it6505: Change definition of AUX_FIFO_MAX_SIZE >> drm/bridge: it6505: improve AUX operation for edid read >> drm/bridge: it6505: add AUX operation for HDCP KSV list read >> drm/bridge: it6505: Change definition MAX_HDCP_DOWN_STREAM_COUNT >> drm/bridge: it6505: fix HDCP Bstatus check >> drm/bridge: it6505: fix HDCP encryption when R0 ready >> drm/bridge: it6505: fix HDCP CTS KSV list read with UNIGRAF DPR-100. >> drm/bridge: it6505: fix HDCP CTS compare V matching >> drm/bridge: it6505: fix HDCP CTS KSV list wait timer >> drm/bridge: it6505: add I2C functionality on AUX >> >> drivers/gpu/drm/bridge/ite-it6505.c | 334 >> ++++++++++++++++++++++++++++++------ >> 1 file changed, 277 insertions(+), 57 deletions(-) >> --- >> base-commit: b8128f7815ff135f0333c1b46dcdf1543c41b860 >> change-id: 20241015-upstream-v6-9f4b015fecf7 >> >> Best regards, >> -- >> Hermes Wu <Hermes.wu@ite.com.tw> >> >> > >-- >With best wishes >Dmitry > BR, Hermes
This is a v6 patch-set. There are lots of failure items while running HDCP CTS using UNIGRAF DPR-100. In Order to fix those failures, HDCP flow needs to be changed. The DisplayPort AUX protocol supports I2C transport. In Order to support MCCS via the aux channel, the aux-i2c operation is added. v5->v6: -keep the commit message wrapped at 72-75 chars. -[10/10] fix return variable being used without being initialized v4->v5: -add more messages for changes. -[2/10] modified AUX transfer data size judgment. change for-loop to do-while. -[7/10] change for-loop to do-while. -[9/10] change wait timer with timer_after() links: https://lore.kernel.org/all/20240926074755.22176-4-Hermes.Wu@ite.com.tw/ https://lore.kernel.org/all/20240926075134.22394-1-Hermes.Wu@ite.com.tw/ v3->v4: -split changes into patches. v2->v3: -split aux read KSV function to a patch. -[1/3] new in v3 -[2/3] add description of patch v1->v2: - ignored. Hermes Wu (10): drm/bridge: it6505: Change definition of AUX_FIFO_MAX_SIZE drm/bridge: it6505: improve AUX operation for edid read drm/bridge: it6505: add AUX operation for HDCP KSV list read drm/bridge: it6505: Change definition MAX_HDCP_DOWN_STREAM_COUNT drm/bridge: it6505: fix HDCP Bstatus check drm/bridge: it6505: fix HDCP encryption when R0 ready drm/bridge: it6505: fix HDCP CTS KSV list read with UNIGRAF DPR-100. drm/bridge: it6505: fix HDCP CTS compare V matching drm/bridge: it6505: fix HDCP CTS KSV list wait timer drm/bridge: it6505: add I2C functionality on AUX Change-Id: Iad0c056d72abf2655081357cf40c3b0d3df916b5 Signed-off-by: Hermes Wu <Hermes.wu@ite.com.tw> --- Hermes Wu (10): drm/bridge: it6505: Change definition of AUX_FIFO_MAX_SIZE drm/bridge: it6505: improve AUX operation for edid read drm/bridge: it6505: add AUX operation for HDCP KSV list read drm/bridge: it6505: Change definition MAX_HDCP_DOWN_STREAM_COUNT drm/bridge: it6505: fix HDCP Bstatus check drm/bridge: it6505: fix HDCP encryption when R0 ready drm/bridge: it6505: fix HDCP CTS KSV list read with UNIGRAF DPR-100. drm/bridge: it6505: fix HDCP CTS compare V matching drm/bridge: it6505: fix HDCP CTS KSV list wait timer drm/bridge: it6505: add I2C functionality on AUX drivers/gpu/drm/bridge/ite-it6505.c | 334 ++++++++++++++++++++++++++++++------ 1 file changed, 277 insertions(+), 57 deletions(-) --- base-commit: b8128f7815ff135f0333c1b46dcdf1543c41b860 change-id: 20241015-upstream-v6-9f4b015fecf7 Best regards,