mbox series

[0/5] Fixes etc for fence merging

Message ID 20241115102153.1980-1-tursulin@igalia.com (mailing list archive)
Headers show
Series Fixes etc for fence merging | expand

Message

Tvrtko Ursulin Nov. 15, 2024, 10:21 a.m. UTC 
From: Tvrtko Ursulin <tvrtko.ursulin@igalia.com>

Consolidated series as an simpler alternative to
https://lore.kernel.org/dri-devel/20241024124159.4519-3-christian.koenig@amd.com/.

Hopefully fixes https://gitlab.freedesktop.org/drm/amd/-/issues/3617.

First two patches are fixes followed by one optimisation and then Christian's
and my selftest additions.

Cover letter now because it grew to five patches.

Please test and/or suggest more test cases to look at.

Cc: Christian König <christian.koenig@amd.com>
Cc: Friedrich Vock <friedrich.vock@gmx.de

Christian König (1):
  dma-buf: add selftest for fence order after merge

Tvrtko Ursulin (4):
  dma-fence: Fix reference leak on fence merge failure path
  dma-fence: Use kernel's sort for merging fences
  dma-fence: Add a single fence fast path for fence merging
  dma-fence: Add some more fence-merge-unwrap tests

 drivers/dma-buf/dma-fence-unwrap.c    | 137 ++++++-------
 drivers/dma-buf/st-dma-fence-unwrap.c | 268 +++++++++++++++++++++++++-
 2 files changed, 335 insertions(+), 70 deletions(-)

Comments

Christian König Nov. 18, 2024, 9:47 a.m. UTC | #1 
Am 15.11.24 um 11:21 schrieb Tvrtko Ursulin:
> From: Tvrtko Ursulin <tvrtko.ursulin@igalia.com>
>
> Consolidated series as an simpler alternative to
> https://lore.kernel.org/dri-devel/20241024124159.4519-3-christian.koenig@amd.com/.
>
> Hopefully fixes https://gitlab.freedesktop.org/drm/amd/-/issues/3617.
>
> First two patches are fixes followed by one optimisation and then Christian's
> and my selftest additions.
>
> Cover letter now because it grew to five patches.
>
> Please test and/or suggest more test cases to look at.
>
> Cc: Christian König <christian.koenig@amd.com>
> Cc: Friedrich Vock <friedrich.vock@gmx.de

Reviewed-by: Christian König <christian.koenig@amd.com> for the entire 
series.

I've already pushed the first two patch to drm-misc-fixes on Friday, 
going to request a backmerge as soon as those land upstream so that we 
can push drm-misc-next as well.

>
> Christian König (1):
>    dma-buf: add selftest for fence order after merge
>
> Tvrtko Ursulin (4):
>    dma-fence: Fix reference leak on fence merge failure path
>    dma-fence: Use kernel's sort for merging fences
>    dma-fence: Add a single fence fast path for fence merging
>    dma-fence: Add some more fence-merge-unwrap tests
>
>   drivers/dma-buf/dma-fence-unwrap.c    | 137 ++++++-------
>   drivers/dma-buf/st-dma-fence-unwrap.c | 268 +++++++++++++++++++++++++-
>   2 files changed, 335 insertions(+), 70 deletions(-)
>