From patchwork Tue Dec 3 08:50:17 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jocelyn Falempe X-Patchwork-Id: 13892035 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 187ABD49797 for ; Tue, 3 Dec 2024 09:29:05 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7228710E9A9; Tue, 3 Dec 2024 09:29:04 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.b="MpxDW1Bj"; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id BA01410E99C for ; Tue, 3 Dec 2024 09:29:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1733218141; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=F2f8WGdinxkKeIjuZL8rVRbdkdX4e9z6nxeN+NAj5Jo=; b=MpxDW1BjktqRKcgUKn0NrWavZx+YX9RnxIPPYQbIE78kgeYw7UXSG9ZD1hKTlCTSGyqG/r s9wAsiVZ4Q9QrELt0mtMU67H+9MFhzqX1jYwdNve3Fyrrpf7a6hO+50B8zFpu1rkhrC5Rw FqVaCCa7Hs2+oCa5LqLhsF2/tNtUh3I= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-387-EyGH7FZuNKyc-0mETd87KA-1; Tue, 03 Dec 2024 04:28:58 -0500 X-MC-Unique: EyGH7FZuNKyc-0mETd87KA-1 X-Mimecast-MFC-AGG-ID: EyGH7FZuNKyc-0mETd87KA Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 9F47C19560A2; Tue, 3 Dec 2024 09:28:56 +0000 (UTC) Received: from hydra.redhat.com (unknown [10.39.193.255]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id E05AE1955D45; Tue, 3 Dec 2024 09:28:52 +0000 (UTC) From: Jocelyn Falempe To: Jani Nikula , Rodrigo Vivi , Joonas Lahtinen , Tvrtko Ursulin , David Airlie , Simona Vetter , intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: Jocelyn Falempe Subject: [RFC PATCH v2 0/5] drm/i915: Add drm_panic support Date: Tue, 3 Dec 2024 09:50:17 +0100 Message-ID: <20241203092836.426422-1-jfalempe@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" This is a first draft of drm_panic support for i915. I've tested it on the 3 intel laptops I have at my disposal. one Haswell with 128MB of eDRAM, one Cometlake and one Alderlake. I tested panic in both fbdev console and gnome desktop. I still have an issue with Alderlake, and it doesn't work when in gnome desktop. If I disable tiling on a framebuffer using DPT, then it displays some other memory location. As DPT is enabled only for tiled framebuffer, there might be some hardware limitations? I think it can be worked around by drawing the image tiled, (like what I've done on nouveau https://patchwork.freedesktop.org/series/133963/), but maybe there is another way? Best regards, v2: * Add the proper abstractions to build also for Xe. * Fix dim checkpatch issues. Jocelyn Falempe (5): drm/i915/fbdev: Add intel_fbdev_get_vaddr() drm/i915/display/i9xx: Add a disable_tiling() for i9xx planes drm/i915/display: Add a disable_tiling() for skl planes drm/i915/gem: Add i915_gem_object_panic_map() drm/i915: Add drm_panic support drivers/gpu/drm/i915/display/i9xx_plane.c | 23 +++++ .../gpu/drm/i915/display/intel_atomic_plane.c | 85 ++++++++++++++++++- drivers/gpu/drm/i915/display/intel_bo.c | 10 +++ drivers/gpu/drm/i915/display/intel_bo.h | 2 + .../drm/i915/display/intel_display_types.h | 2 + drivers/gpu/drm/i915/display/intel_fb_pin.c | 5 ++ drivers/gpu/drm/i915/display/intel_fb_pin.h | 1 + drivers/gpu/drm/i915/display/intel_fbdev.c | 5 ++ drivers/gpu/drm/i915/display/intel_fbdev.h | 6 ++ .../drm/i915/display/skl_universal_plane.c | 20 +++++ drivers/gpu/drm/i915/gem/i915_gem_object.h | 2 + drivers/gpu/drm/i915/gem/i915_gem_pages.c | 25 ++++++ drivers/gpu/drm/i915/i915_vma.h | 5 ++ drivers/gpu/drm/xe/display/intel_bo.c | 11 +++ drivers/gpu/drm/xe/display/xe_fb_pin.c | 5 ++ 15 files changed, 206 insertions(+), 1 deletion(-) base-commit: 44cff6c5b0b17a78bc0b30372bcd816cf6dd282a