From patchwork Mon Mar 3 22:00:16 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Cavitt X-Patchwork-Id: 13999526 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AF5B8C282CD for ; Mon, 3 Mar 2025 22:00:25 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D721210E254; Mon, 3 Mar 2025 22:00:24 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="Ei/DfZmB"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.21]) by gabe.freedesktop.org (Postfix) with ESMTPS id F404510E235; Mon, 3 Mar 2025 22:00:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1741039223; x=1772575223; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=E9MLl/J52nZm7gl3ev1RijbSfIuQGJ+nkwdwabMWcyY=; b=Ei/DfZmBcXULgMwKM+J8q1fHKDsWSAk6roAcTAXVkllB7sJfgXdCNRwK UExVQzxQngv6teLJOnGgyzdPrZOJm5SbxBfV0uG3TCetRjxKW8lUMjCum 8YiJ4NxCcnJqm2V3SpLouB1GzPr/sRRaof39bMU6nsoc87ShSxs2ZwjzY hbRV0/5+6TQg1JUyRyIZgr1+gs5BM4aD2h3Rqd72vt+VVYBrQlEpXYcag aro08d3ml5/7NRnC2MlJCU74wUISYbCOMCGr4YPmiuPTSL1/52G8HgdvY QKxbE9yHkJ6JQbuH/ce/9nbpM6zd+rLE1cu9qJI8ZAw6vTbe0zlQVU9oN Q==; X-CSE-ConnectionGUID: ibu5Ff7xRoaXI9hntbj4gg== X-CSE-MsgGUID: GarWIWvURaiyGnzmTUoIcQ== X-IronPort-AV: E=McAfee;i="6700,10204,11362"; a="41846103" X-IronPort-AV: E=Sophos;i="6.13,330,1732608000"; d="scan'208";a="41846103" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Mar 2025 14:00:23 -0800 X-CSE-ConnectionGUID: TjajnIp2RDG/r4IT5sBDSg== X-CSE-MsgGUID: 8O4/rLD0T5mcMhC/BDPPfQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,224,1728975600"; d="scan'208";a="118020883" Received: from dut4025lnl.fm.intel.com ([10.105.8.176]) by orviesa010-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Mar 2025 14:00:22 -0800 From: Jonathan Cavitt To: intel-xe@lists.freedesktop.org Cc: saurabhg.gupta@intel.com, alex.zuo@intel.com, jonathan.cavitt@intel.com, joonas.lahtinen@linux.intel.com, matthew.brost@intel.com, jianxun.zhang@intel.com, dri-devel@lists.freedesktop.org Subject: [PATCH v4 0/6] drm/xe/xe_vm: Implement xe_vm_get_property_ioctl Date: Mon, 3 Mar 2025 22:00:16 +0000 Message-ID: <20250303220022.67200-1-jonathan.cavitt@intel.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Add additional information to each VM so they can report up to the last 50 seen pagefaults. Only failed pagefaults are saved this way, as successful pagefaults should recover and not need to be reported to userspace. Additionally, add a new ioctl - xe_vm_get_property_ioctl - that allows the user to query these pagefaults v2: (Matt Brost) - Break full ban list request into a separate property. - Reformat drm_xe_vm_get_property struct. - Remove need for drm_xe_faults helper struct. - Separate data pointer and scalar return value in ioctl. - Get address type on pagefault report and save it to the pagefault. - Correctly reject writes to read-only VMAs. - Miscellaneous formatting fixes. v3: (Matt Brost) - Only allow querying of failed pagefaults v4: - Remove unnecessary size parameter from helper function, as it is a property of the arguments. (jcavitt) - Remove unnecessary copy_from_user (Jainxun) - Set address_precision to 1 (Jainxun) - Report max size instead of dynamic size for memory allocation purposes. Total memory usage is reported separately. Signed-off-by: Jonathan Cavitt Suggested-by: Joonas Lahtinen Suggested-by: Matthew Brost CC: Zhang Jianxun Jonathan Cavitt (6): drm/xe/xe_gt_pagefault: Disallow writes to read-only VMAs drm/xe/xe_gt_pagefault: Migrate pagefault struct to header drm/xe/xe_vm: Add per VM pagefault info drm/xe/uapi: Define drm_xe_vm_get_property drm/xe/xe_gt_pagefault: Add address_type field to pagefaults drm/xe/xe_vm: Implement xe_vm_get_property_ioctl drivers/gpu/drm/xe/xe_device.c | 3 + drivers/gpu/drm/xe/xe_gt_pagefault.c | 66 +++++++-------- drivers/gpu/drm/xe/xe_gt_pagefault.h | 29 +++++++ drivers/gpu/drm/xe/xe_vm.c | 122 +++++++++++++++++++++++++++ drivers/gpu/drm/xe/xe_vm.h | 8 ++ drivers/gpu/drm/xe/xe_vm_types.h | 20 +++++ include/uapi/drm/xe_drm.h | 67 +++++++++++++++ 7 files changed, 281 insertions(+), 34 deletions(-)