From patchwork Wed Mar 5 13:05:49 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Philipp Stanner X-Patchwork-Id: 14002599 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 05172C19F32 for ; Wed, 5 Mar 2025 13:06:04 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 62B9C10E09B; Wed, 5 Mar 2025 13:06:04 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="V5XF2zMK"; dkim-atps=neutral Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4A02010E09B for ; Wed, 5 Mar 2025 13:06:03 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 823B95C6859; Wed, 5 Mar 2025 13:03:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 91318C4CEE2; Wed, 5 Mar 2025 13:05:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1741179962; bh=LRCjF4OfWgUdrLVSHUh/AiNipL4Jl4BHFHjUmsczaPc=; h=From:To:Cc:Subject:Date:From; b=V5XF2zMKMXEtPOdlVG7l7pd12VGChbIQNQ5AB5iEyS+tHuTnHqnjeiqbcCAXikmNu gyXxqunjIf6fq1tDfRtjCtu64Zl2cuc0n+RZdRhODtQsxqWlf+ye8GliRJUn0z0dBI sTaWbdVoKHA0UuG+KQKl3FFecJQVi24DiKEAUYFkdYB3/9iBjvOWdExKg9LSK6IJz/ e6Iw+y6VGsbVMwAqb4U+x8we0SgXWrEqcgvnBeN//AJzi5Cf1UVFzehkqdF7Xl/nGX smA8zlr+LH53gXy/LtkAw8I9VnfskSaRkdhO1av+M8nKi6FylC/LM6R2AqlVvNvEjd cEOzc2mjJiPDg== From: Philipp Stanner To: Matthew Brost , Danilo Krummrich , Philipp Stanner , =?utf-8?q?Christian_K=C3=B6nig?= , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Sumit Semwal Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v7 0/3] drm/sched: Documentation and refcount improvements Date: Wed, 5 Mar 2025 14:05:49 +0100 Message-ID: <20250305130551.136682-2-phasta@kernel.org> X-Mailer: git-send-email 2.48.1 MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Changes in v7: - Add Christian's info about violated dma_fence rules. (Christian) - Fix some typos Changes in v6: - Switch patches 1 and 2. (Maira) - Move section related to run_job() out of timedout_job() patch. (Maira). - Fix some places for correct crosslink references. - Add comment to inform about run_job() incrementing the refcount. (Danilo) Changes in v5: - Fix broken enumarated list in timedout_job's docu. - Add TODO for documenting the dma_fence rules in timedout_job one day. Changes in v4: - Remove mention of vague "dma_fence rules" in timedout_job() again since I couldn't get input on what those rules precisely are. - Address a forgotten TODO. (Me) - Reposition "Return:" statements to make them congruent with the official kernel style. (Tvrtko) - Change formatting a bit because of crazy make htmldocs errors. (Me) Changes in v3: - timedout_job(): various docu wording improvements. (Danilo) - Use the term "ring" consistently. (Danilo) - Add fully fledged docu for enum drm_gpu_sched_stat. (Danilo) Changes in v2: - Document what run_job() is allowed to return. (Tvrtko) - Delete confusing comment about putting the fence. (Danilo) - Apply Danilo's RB to patch 1. - Delete info about job recovery for entities in patch 3. (Danilo, me) - Set the term "ring" as fix term for both HW rings and FW rings. A ring shall always be the thingy on the CPU ;) (Danilo) - Many (all) other comments improvements in patch 3. (Danilo) This is as series succeeding my previous patch [1]. I recognized that we are still referring to a non-existing function and a deprecated one in the callback docu. We should probably also point out the important distinction between hardware and firmware schedulers more cleanly. Please give me feedback, especially on the RFC comments in patch3. (This series still fires docu-build-warnings. I want to gather feedback on the opion questions first and will solve them in v2.) Thank you, Philipp [1] https://lore.kernel.org/all/20241220124515.93169-2-phasta@kernel.org/ Philipp Stanner (3): drm/sched: Adjust outdated docu for run_job() drm/sched: Document run_job() refcount hazard drm/sched: Update timedout_job()'s documentation drivers/gpu/drm/scheduler/sched_main.c | 9 +- include/drm/gpu_scheduler.h | 112 +++++++++++++++++-------- 2 files changed, 83 insertions(+), 38 deletions(-)