From patchwork Fri Mar 7 17:01:11 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Tvrtko Ursulin X-Patchwork-Id: 14006786 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 25BBCC19F32 for ; Fri, 7 Mar 2025 17:01:26 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9697110E197; Fri, 7 Mar 2025 17:01:25 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=igalia.com header.i=@igalia.com header.b="LxqKiN8j"; dkim-atps=neutral Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6]) by gabe.freedesktop.org (Postfix) with ESMTPS id CB93E10E0CC for ; Fri, 7 Mar 2025 17:01:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID: Date:Subject:Cc:To:From:Sender:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=6uITEncsPYnDONKjSuzOGxZj6vcBxdDZYBFVUOoW6Y0=; b=LxqKiN8jWAkkmUWytnxPNhL6/V 0pRa2jFEys13gS4Qza3LFma6CRMrgXieCx114YhKJxLFqMoREEWwwbmkyKm2wZ5uPaZUfMWH4JbHR XqQTUagMBzBLNl+UOE5bSiYD8RFZJqQ1oNIRR+WdbtWewUaM6c7jdwTtSAJ8qLNCWL6ltnHDSrwFD g01V1eSAjAmzNSdn5IZralIL9qJdFa92bIf/L8Fdqdtt/N43gt8HeYKbqP8TxF9TlInVEV9YuiGAv mZmALNtHWXEipgm+FcKrKvk2MGc6i2XOnbyo/jlhYaf0glo/DBahi93PpXw8f3MhUbB1xyAA9QdLn 0cooRnLA==; Received: from [90.241.98.187] (helo=localhost) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim) id 1tqb4W-005RUH-Qb; Fri, 07 Mar 2025 18:01:22 +0100 From: Tvrtko Ursulin To: dri-devel@lists.freedesktop.org Cc: kernel-dev@igalia.com, Tvrtko Ursulin , =?utf-8?q?Christian_K=C3=B6nig?= , Danilo Krummrich , Matthew Brost , Philipp Stanner Subject: [PATCH v5 0/5] DRM scheduler kunit tests Date: Fri, 7 Mar 2025 17:01:11 +0000 Message-ID: <20250307170116.32415-1-tvrtko.ursulin@igalia.com> X-Mailer: git-send-email 2.48.0 MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" There has repeatedly been quite a bit of apprehension when any change to the DRM scheduler is proposed, with two main reasons being code base is considered fragile, not well understood and not very well documented, and secondly the lack of systematic testing outside the vendor specific tests suites and/or test farms. This series is an attempt to dislodge this status quo by adding some unit tests using the kunit framework. General approach is that there is a mock "hardware" backend which can be controlled from tests, which in turn allows exercising various scheduler code paths. Only some simple basic tests get added in the series and hopefully it is easy to understand what tests are doing. An obligatory "screenshot" for reference: [14:29:37] ============ drm_sched_basic_tests (3 subtests) ============ [14:29:38] [PASSED] drm_sched_basic_submit [14:29:38] ================== drm_sched_basic_test =================== [14:29:38] [PASSED] A queue of jobs in a single entity [14:29:38] [PASSED] A chain of dependent jobs across multiple entities [14:29:38] [PASSED] Multiple independent job queues [14:29:38] [PASSED] Multiple inter-dependent job queues [14:29:38] ============== [PASSED] drm_sched_basic_test =============== [14:29:38] [PASSED] drm_sched_basic_entity_cleanup [14:29:38] ============== [PASSED] drm_sched_basic_tests ============== [14:29:38] ======== drm_sched_basic_timeout_tests (1 subtest) ========= [14:29:40] [PASSED] drm_sched_basic_timeout [14:29:40] ========== [PASSED] drm_sched_basic_timeout_tests ========== [14:29:40] ======= drm_sched_basic_priority_tests (2 subtests) ======== [14:29:42] [PASSED] drm_sched_priorities [14:29:42] [PASSED] drm_sched_change_priority [14:29:42] ========= [PASSED] drm_sched_basic_priority_tests ========== [14:29:42] ====== drm_sched_basic_modify_sched_tests (1 subtest) ====== [14:29:43] [PASSED] drm_sched_test_modify_sched [14:29:43] ======= [PASSED] drm_sched_basic_modify_sched_tests ======== [14:29:43] ============================================================ [14:29:43] Testing complete. Ran 10 tests: passed: 10 [14:29:43] Elapsed time: 13.330s total, 0.001s configuring, 4.005s building, 9.276s running v2: * Parameterize a bunch of similar tests. * Improve test commentary. * Rename TDR test to timeout. (Christian) * Improve quality and consistency of naming. (Philipp) RFC v2 -> series v1: * Rebased for drm_sched_init changes. * Fixed modular build. * Added some comments. * Filename renames. (Philipp) v2: * Dealt with a bunch of checkpatch warnings. v3: * Some mock API renames, kerneldoc grammar fixes and indentation fixes. v4: * Fix use after free caused by relying on scheduler fence for querying status. * Kerneldoc fixes. v5: * Cleanup in-flight jobs on scheduler shutdown. * Change hang_limit to 1. Cc: Christian König Cc: Danilo Krummrich Cc: Matthew Brost Cc: Philipp Stanner Tvrtko Ursulin (5): drm: Move some options to separate new Kconfig drm/scheduler: Add scheduler unit testing infrastructure and some basic tests drm/scheduler: Add a simple timeout test drm/scheduler: Add basic priority tests drm/scheduler: Add a basic test for modifying entities scheduler list drivers/gpu/drm/Kconfig | 109 +---- drivers/gpu/drm/Kconfig.debug | 115 +++++ drivers/gpu/drm/scheduler/.kunitconfig | 12 + drivers/gpu/drm/scheduler/Makefile | 2 + drivers/gpu/drm/scheduler/tests/Makefile | 7 + .../gpu/drm/scheduler/tests/mock_scheduler.c | 335 ++++++++++++++ drivers/gpu/drm/scheduler/tests/sched_tests.h | 224 ++++++++++ drivers/gpu/drm/scheduler/tests/tests_basic.c | 418 ++++++++++++++++++ 8 files changed, 1118 insertions(+), 104 deletions(-) create mode 100644 drivers/gpu/drm/Kconfig.debug create mode 100644 drivers/gpu/drm/scheduler/.kunitconfig create mode 100644 drivers/gpu/drm/scheduler/tests/Makefile create mode 100644 drivers/gpu/drm/scheduler/tests/mock_scheduler.c create mode 100644 drivers/gpu/drm/scheduler/tests/sched_tests.h create mode 100644 drivers/gpu/drm/scheduler/tests/tests_basic.c